From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer Date: Tue, 27 Oct 2020 08:27:11 +0100 Message-ID: <87lffsruwg.fsf@gnus.org> References: <87lffu9zye.fsf@gnus.org> <87a6wa8d1w.fsf@gnus.org> <87sga1477z.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12590"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Kangas , 44202@debbugs.gnu.org To: Kevin Foley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 27 08:28:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXJOu-0003Av-1s for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Oct 2020 08:28:12 +0100 Original-Received: from localhost ([::1]:54070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXJOt-000489-03 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Oct 2020 03:28:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXJOk-00044G-0X for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2020 03:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXJOj-0004OH-Lb for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2020 03:28:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kXJOj-0001AN-HQ for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2020 03:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Oct 2020 07:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44202 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44202-submit@debbugs.gnu.org id=B44202.16037836454424 (code B ref 44202); Tue, 27 Oct 2020 07:28:01 +0000 Original-Received: (at 44202) by debbugs.gnu.org; 27 Oct 2020 07:27:25 +0000 Original-Received: from localhost ([127.0.0.1]:42624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXJO8-00019I-OP for submit@debbugs.gnu.org; Tue, 27 Oct 2020 03:27:24 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:53414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXJO7-000193-Ix for 44202@debbugs.gnu.org; Tue, 27 Oct 2020 03:27:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZO0QIR5FguMVdeGT8nF+hO6n5Azlfe9QEIyEjrJH2R4=; b=mpNw1oyCwQDN4d5geeiUb1oUna QQiwSNKJxqE37X/KAQXQtdTtuzD48IeEtIioahUOd9YwjyCxGOaJbEruajhvHJRm8aojSE2ttoAzA fAnjmrffCRB2nE+w2t7Qb4auMTZZdMN8reZyr2PE5fLzBHzkJfFmam88pK+kDkMhWwII=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXJNx-0003fx-AD; Tue, 27 Oct 2020 08:27:16 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEWpYhtZLB7pohnu 0aH///80edrZAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QKGwcXLcm69W0AAAGVSURBVDjLVVOBkcMw CAN+AfwT8M4Gzf67vQQ2tX29pkWRABlE6ujAEZk8eIjKqCNis04gHgB4EJ+z4/mtQAMydsT5OxmU tx3GD+MT2jEaqDwqBhExda3csfIjCBUK4eOdhMDAu6hI9awKefl/rD4kmmIqTu0CXL6cBEYSL6mp JkvKbwAyXl6xhiu5/CagN8PwWjKUzZwmoiCfDkDY4bwQj18qjsPdQozeKqo642Vmmu4ScgEBH7Jc i5uCu0hLPC/nRhLA9ZJ/SMEvISEmtNTim4N+7ZLwTisRkMzEptL5FC2AHg7ebwGBEIZhVlnrezti 4cHb0hW3LlUScBrs3tOb9iaD+kOOsY5hkSKunFXfhiHYgJ/e0/fY+1GWNdIAOZ0jb36Pj+49Y+u5 IQkIut8eRt1O7pmWI6tBkJ7P3DnYUiE27ZkHIH/LEyi9JNJbmMKWZHb6txiSyyY7O4Sedw31SIZJ ZSclh4EgWvUCsKbTXuEgYnH9u+3ZxlszSrT3CsCDHD+i69ZHlcu7TUaNg/aCcint+fwD5Chalzzb s+IAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMTAtMjdUMDc6MjM6NDUrMDA6MDBYZBDBAAAAJXRF WHRkYXRlOm1vZGlmeQAyMDIwLTEwLTI3VDA3OjIzOjQ1KzAwOjAwKTmofQAAAABJRU5ErkJggg== X-Now-Playing: Prince's _Sign 'O' the Times (2)_: "The Cross" In-Reply-To: (Kevin Foley's message of "Mon, 26 Oct 2020 18:05:03 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191704 Archived-At: Kevin Foley writes: > So would the solution be to remove the prompt all together? Or would it > the approach used in the patch to provide an option to control it > specifically for *Help*? I looked at the VC log for the *Help* function to see whether there was a particular reason this function required confirmation (when most other non-file buffer reverting functions didn't), and I couldn't find anything. My guess is that since the revert-buffer functions have a NOCONFIRM parameter, then it was just implemented that way without, since that seems logical. (And it would be, if the NOCONFIRM parameter was more... logical.) So I've just removed the prompting in *Help* unconditionally on the trunk now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no