From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#64799: [PATCH] Add 'project-prompt-key' face Date: Wed, 26 Jul 2023 07:50:26 +0300 Message-ID: <87jzun5l9p.fsf@protesilaos.com> References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29960"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64799@debbugs.gnu.org To: Dmitry Gutov , Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 26 06:51:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qOWUj-0007ZK-VX for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Jul 2023 06:51:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qOWUR-0004Qu-Iy; Wed, 26 Jul 2023 00:51:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOWUI-0004QF-UU for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2023 00:51:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qOWUI-0007TS-Mq for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2023 00:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qOWUI-00008F-5T for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2023 00:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jul 2023 04:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64799-submit@debbugs.gnu.org id=B64799.1690347039472 (code B ref 64799); Wed, 26 Jul 2023 04:51:02 +0000 Original-Received: (at 64799) by debbugs.gnu.org; 26 Jul 2023 04:50:39 +0000 Original-Received: from localhost ([127.0.0.1]:47330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOWTu-00007Y-Um for submit@debbugs.gnu.org; Wed, 26 Jul 2023 00:50:39 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:41495) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOWTs-00007D-7x for 64799@debbugs.gnu.org; Wed, 26 Jul 2023 00:50:37 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 04928E0003; Wed, 26 Jul 2023 04:50:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1690347029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q+oU8hixBNSzuqduPQhuBDObgpB1eKE+oujwANMvQWY=; b=ps2YYLL0MeRwFLRq21AMHZMalFtRnGeC+8vbrFWGPfKIGz5+yVjG396GdeBRjCPBYRYlg8 3eW5vp2FBcCT5W2qZDgRtdORSmRCxw3m+AFPKRi21UzPPGaox2FzxetieOADy2BYdZWdRx MFeKOTqULdbwTIqBp6NSY/PPr4uj7WNcJuFlj55TPbRO2VI1SSA+LxUXEhaJLV9Gl4PfCI wvsaT8tswJlhdOTbDXgstFZF3oJPo6hwmmUEgzEL/pWLVr+k7cSFr4XDrVMObIbUpL6Psu 9d7lCmraPBRriUDn9X48DVxYFBCb06aYuUcdZbmre5VZ1XjR3989CpFDeq81gQ== In-Reply-To: <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> X-GND-Sasl: public@protesilaos.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266102 Archived-At: > From: Dmitry Gutov > Date: Tue, 25 Jul 2023 16:05:15 +0300 > [... 13 lines elided] >> Alternatively, we could add a version/facep check and always prefer >> `help-key-binding' if it is available, otherwise fall-back to the >> current option. > > That works for me. Me too! >>>> Perhaps a user option for the whole 'format' would be better? >>> >>> We can add a user option. But while we could also apply 'face' >>> property on that option's string value, that doesn't seem like a very >>> user-friendly approach toward someone who will want to change the face >>> used (it will require some Lisp knowledge from the user). >>> >>> But a user option to change how the prompt text is constructed -- why >>> not. E.g. one defaulting to "[%s] %s". >> >> Is there really such a wide range of options that users might be >> interested in here? > > Protesilaos wanted to use a different format? For my use, and Emacs 28+, I want this: (format "%s %s" (propertize (key-description key) 'face 'project-prompt-key) label) The reason I mentioned the possibility of a user option is because without the square brackets the bold face will not have the same effect as the current design. The square brackets help add structure and make it easier to identify the keys. The use of 'bold' without the square brackets may make it more difficult for users to spot the keys. -- Protesilaos Stavrou https://protesilaos.com