From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 35564@debbugs.gnu.org, Noam Postavsky <npostavs@gmail.com>,
Juri Linkov <juri@linkov.net>,
Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#35564: [PATCH v5] Tweak dired warning about "wildcard" characters
Date: Tue, 22 Oct 2019 23:32:18 +0200 [thread overview]
Message-ID: <87imogtqjh.fsf@gmail.com> (raw)
In-Reply-To: <87zhhsd8eq.fsf@web.de> (Michael Heerdegen's message of "Tue, 22 Oct 2019 18:58:21 +0200")
Michael Heerdegen <michael_heerdegen@web.de> writes:
> Without having had a look yet - your last version addresses everything
> brought up so far and can be considered final, right?
I think so. Going over for bug#28969 and bug#35564, here are the
discussion points I could identify:
- y-or-n-p propertizing its prompt rigidly: out of scope, since we use
read-multiple-choice now.
- The prompt getting too long: it's now much shorter than the
four(!)-line version I came up with in v4; it concisely spells out the
issue (some characters will not be substituted) and invites the user
to ask for more details if needed.
- Asking the user whether they'd like to actually substitute these
characters: out of scope; not sure it's necessary, since the new
"details" buffer explains how to work around this for '?' (using
backquotes).
(Though no such workaround exists for '*'. Allowing '*' to be
isolated with backquotes just like '?' would be a natural thing to do
IMO, but that's unrelated to fixing this confusing prompt.)
- Ensuring accessibility: users who cannot distinguish the 'warning'
face are now invited to add optional '^' markers.
- Preventing '`' being linked to the backquote macro in the docstring
for dired-do-shell-command: still no idea how to fix that, but that
can be investigated independently.
Here are some remaining issues I can think of:
- The code that toggles the '^' markers does not check that the command
is not wrapped/truncated (i.e. that the window is wide enough).
- The details window might not be tall enough, in which case maybe I
should add [f]orward-/[b]ackward-page actions like nsm.el does.
- In dired--no-subst-confirm, I did my best to make the window-popping
dance as graceful as possible (unwind-protect so that the details
buffer is killed even after C-g, save-window-excursion to restore the
window configuration…), but maybe it falls apart in cases I haven't
considered.
- UI bikeshedding: maybe drop the leading "Warning:", add the underline
face to the mix…
- Code quality: some of the small functions I wrote exist for no other
reason than I found the resulting code to be easier to follow; they
could probably be inlined if others do not share my preferences.
next prev parent reply other threads:[~2019-10-22 21:32 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 18:01 bug#35564: 27.0.50; [PATCH] Tweak dired-do-shell-command warning about "wildcard" characters Kévin Le Gouguec
2019-05-05 8:44 ` martin rudalics
2019-05-06 19:40 ` Kévin Le Gouguec
2019-05-07 8:15 ` martin rudalics
2019-05-07 13:19 ` Drew Adams
2019-05-08 20:42 ` Kévin Le Gouguec
2019-05-08 22:39 ` Drew Adams
2019-05-09 8:13 ` martin rudalics
2019-05-09 14:17 ` Drew Adams
2019-05-09 17:51 ` martin rudalics
2019-05-09 20:04 ` Drew Adams
2019-06-09 11:08 ` bug#35564: [PATCH v2] Tweak dired " Kévin Le Gouguec
2019-06-12 12:23 ` Noam Postavsky
2019-06-12 14:29 ` Stefan Monnier
2019-06-13 6:19 ` Kévin Le Gouguec
2019-06-13 7:58 ` Stefan Monnier
2019-06-13 16:53 ` npostavs
2019-06-18 8:52 ` Kévin Le Gouguec
2019-06-19 0:12 ` Noam Postavsky
2019-06-26 6:16 ` bug#35564: [PATCH v3] " Kévin Le Gouguec
2019-06-26 13:27 ` Drew Adams
2019-06-27 5:58 ` Kévin Le Gouguec
2019-06-26 14:33 ` Stefan Monnier
2019-06-27 6:15 ` Kévin Le Gouguec
2019-06-27 23:31 ` Noam Postavsky
2019-06-28 6:15 ` Kévin Le Gouguec
2019-06-28 15:35 ` Drew Adams
2019-06-28 17:58 ` Kévin Le Gouguec
2019-06-28 18:43 ` Drew Adams
2019-06-29 13:48 ` Noam Postavsky
2019-06-29 14:30 ` Drew Adams
2019-06-29 14:13 ` Eli Zaretskii
2019-07-03 19:47 ` bug#35564: [PATCH v4] " Kévin Le Gouguec
2019-07-12 15:10 ` Kévin Le Gouguec
2019-07-27 11:20 ` Eli Zaretskii
2019-07-27 17:26 ` Kévin Le Gouguec
2019-07-27 22:22 ` Michael Heerdegen
2019-07-29 3:29 ` Michael Heerdegen
2019-07-29 18:11 ` Juri Linkov
2019-07-29 19:01 ` Kévin Le Gouguec
2019-08-02 5:26 ` Michael Heerdegen
2019-08-08 10:40 ` Kévin Le Gouguec
2019-08-08 21:06 ` Juri Linkov
2019-08-09 12:43 ` Kévin Le Gouguec
2019-08-09 18:03 ` Juri Linkov
2019-08-15 20:56 ` Juri Linkov
2019-08-19 4:55 ` Kévin Le Gouguec
2019-07-27 22:03 ` Basil L. Contovounesios
2019-07-27 23:32 ` Kévin Le Gouguec
2019-07-27 23:41 ` Basil L. Contovounesios
2019-10-10 18:45 ` bug#35564: [PATCH v5] " Kévin Le Gouguec
2019-10-22 15:10 ` Kévin Le Gouguec
2019-10-22 16:58 ` Michael Heerdegen
2019-10-22 21:32 ` Kévin Le Gouguec [this message]
2019-11-10 20:29 ` Juri Linkov
2019-11-14 7:02 ` Kévin Le Gouguec
2019-11-16 20:23 ` Juri Linkov
2019-10-22 20:43 ` Juri Linkov
2019-10-22 21:11 ` Kévin Le Gouguec
2019-10-27 21:40 ` Juri Linkov
2019-10-30 21:59 ` Juri Linkov
2019-11-04 6:36 ` Kévin Le Gouguec
2019-11-05 22:22 ` Juri Linkov
2019-11-07 22:17 ` Juri Linkov
2019-11-10 20:18 ` Juri Linkov
2019-12-18 7:11 ` Kévin Le Gouguec
2019-12-19 22:01 ` Juri Linkov
2019-12-20 8:53 ` Eli Zaretskii
2019-12-20 20:34 ` Kévin Le Gouguec
2019-12-21 7:08 ` Eli Zaretskii
2019-12-22 16:02 ` Kévin Le Gouguec
2019-12-20 20:43 ` Kévin Le Gouguec
2019-12-21 7:08 ` Eli Zaretskii
2020-09-20 11:42 ` Lars Ingebrigtsen
2020-09-20 12:04 ` Kévin Le Gouguec
2020-09-20 12:18 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imogtqjh.fsf@gmail.com \
--to=kevin.legouguec@gmail.com \
--cc=35564@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).