From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#35564: [PATCH v5] Tweak dired warning about "wildcard" characters Date: Tue, 22 Oct 2019 23:32:18 +0200 Message-ID: <87imogtqjh.fsf@gmail.com> References: <87zho2cd4f.fsf@gmail.com> <87wohvf22u.fsf@gmail.com> <87h88cvpkj.fsf_-_@gmail.com> <87imsinbmr.fsf_-_@gmail.com> <87o8yoign9.fsf_-_@gmail.com> <87v9sgrf29.fsf@gmail.com> <87zhhsd8eq.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="197601"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35564@debbugs.gnu.org, Noam Postavsky , Juri Linkov , Stefan Monnier To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 22 23:33:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iN1mM-000pIB-K8 for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Oct 2019 23:33:22 +0200 Original-Received: from localhost ([::1]:45682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iN1mL-0005Ys-4h for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Oct 2019 17:33:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52580) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iN1m3-0005YX-Pv for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 17:33:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iN1m2-0008LU-L5 for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 17:33:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51743) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iN1m2-0008LN-HQ for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 17:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iN1m2-0006mO-Bm for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 17:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Oct 2019 21:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35564-submit@debbugs.gnu.org id=B35564.157177994926021 (code B ref 35564); Tue, 22 Oct 2019 21:33:02 +0000 Original-Received: (at 35564) by debbugs.gnu.org; 22 Oct 2019 21:32:29 +0000 Original-Received: from localhost ([127.0.0.1]:60564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iN1lU-0006ld-Mn for submit@debbugs.gnu.org; Tue, 22 Oct 2019 17:32:28 -0400 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:40557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iN1lS-0006lN-Hq for 35564@debbugs.gnu.org; Tue, 22 Oct 2019 17:32:27 -0400 Original-Received: by mail-wm1-f49.google.com with SMTP id b24so17518657wmj.5 for <35564@debbugs.gnu.org>; Tue, 22 Oct 2019 14:32:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=gytPf1fRIq8RqSRx10DcoGqyOULRmYhDmbZ/CqSHCr4=; b=ZyJLOY8VIciWZcOzezbZxtTdHlXCi+vwYfnvMIBuqChw3T+auoQITeeqvd6oNL78cd a4zz15vzpPaV2yseL3hiJ+/YUKB5VFBNPAVzrZy4td6gbODuDH3uQoF7uMgx5ljkd3uo 5RlNgjE93edvCu/Vokp0CO9aw6twjRTRKq3vfmtRNoDrct9c47JydDeiK4cLBEQJfEnR HizwQx6TilIvsp0E4d9W8uwSaB68iQ3lBLINqSvSf47cQ2mjXKihuBr40KgS9WcVQuQK 5ALdBnLL81p4WxnfnaCaBIZSIE07GWaQK2+NiiASFr6xW91xnvCxq8rcyVOEkItT76Tz OVmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=gytPf1fRIq8RqSRx10DcoGqyOULRmYhDmbZ/CqSHCr4=; b=i3YNxD5LXXlpER0VIC8Q1ilWclf7IzVjgZLNzskBJxhP2eAdnq8A/YOEjxodtVO0gZ 4gFzrCem0LnqcGDLfFoMMN5PdqcAkf0o/XO7g3EAQjr4hUcnzQmy232y7KHjOnf6/k/2 BMkCcV8E0P//qV+CNcPr4YVA1gwI5ccRu4B5ltX6/E3Hvbuw2L/vtPN6ySckmMYKBINR cOBfzbndSU2db++xTB3uZv4k9X0Tzp/pPB/VJEYDMDVOSqO0VS0SAQ/iv8SmOhtyPDCU LTQIRdeGERPundIdvvDIk+x7L1yJKWc+JCk7a7PePAtvwVIlFZBrFFM8I5mbW6/AUweo B3Jg== X-Gm-Message-State: APjAAAXp/oHG6HSTmr2IhJ7B4fyCz5DbcHV8wCgWTZ1XaJPIEDq9yOCc Zj/kG6TlgbUL25WdJVGZbro= X-Google-Smtp-Source: APXvYqxCK85qx7TVgc4ayHMqBqQu1fEB48bT/Ejqu/pcIvCt6htB12kYPwcNehS0pG/Bpv584sLPMQ== X-Received: by 2002:a1c:a849:: with SMTP id r70mr4568446wme.59.1571779940612; Tue, 22 Oct 2019 14:32:20 -0700 (PDT) Original-Received: from little-buster ([92.184.101.100]) by smtp.gmail.com with ESMTPSA id e9sm3734535wrr.13.2019.10.22.14.32.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2019 14:32:19 -0700 (PDT) In-Reply-To: <87zhhsd8eq.fsf@web.de> (Michael Heerdegen's message of "Tue, 22 Oct 2019 18:58:21 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170013 Archived-At: Michael Heerdegen writes: > Without having had a look yet - your last version addresses everything > brought up so far and can be considered final, right? I think so. Going over for bug#28969 and bug#35564, here are the discussion points I could identify: - y-or-n-p propertizing its prompt rigidly: out of scope, since we use read-multiple-choice now. - The prompt getting too long: it's now much shorter than the four(!)-line version I came up with in v4; it concisely spells out the issue (some characters will not be substituted) and invites the user to ask for more details if needed. - Asking the user whether they'd like to actually substitute these characters: out of scope; not sure it's necessary, since the new "details" buffer explains how to work around this for '?' (using backquotes). (Though no such workaround exists for '*'. Allowing '*' to be isolated with backquotes just like '?' would be a natural thing to do IMO, but that's unrelated to fixing this confusing prompt.) - Ensuring accessibility: users who cannot distinguish the 'warning' face are now invited to add optional '^' markers. - Preventing '`' being linked to the backquote macro in the docstring for dired-do-shell-command: still no idea how to fix that, but that can be investigated independently. Here are some remaining issues I can think of: - The code that toggles the '^' markers does not check that the command is not wrapped/truncated (i.e. that the window is wide enough). - The details window might not be tall enough, in which case maybe I should add [f]orward-/[b]ackward-page actions like nsm.el does. - In dired--no-subst-confirm, I did my best to make the window-popping dance as graceful as possible (unwind-protect so that the details buffer is killed even after C-g, save-window-excursion to restore the window configuration=E2=80=A6), but maybe it falls apart in cases I haven= 't considered. - UI bikeshedding: maybe drop the leading "Warning:", add the underline face to the mix=E2=80=A6 - Code quality: some of the small functions I wrote exist for no other reason than I found the resulting code to be easier to follow; they could probably be inlined if others do not share my preferences.