From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#53853: [PATCH] Don't use string-replace in flymake Date: Tue, 08 Feb 2022 16:07:33 +0100 Message-ID: <87h7995rd6.fsf@gmail.com> References: <87r18e7fb7.fsf@gmail.com> <87zgn1ublj.fsf@gnus.org> <87mtj17oqg.fsf@gmail.com> <87ee4d7o3f.fsf@gmail.com> <875ypp7kmu.fsf@gmail.com> <83iltpwlwn.fsf@gnu.org> <83fsotwjiw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13109"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Brian Leung , Lars Ingebrigtsen , 53853@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 08 18:19:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHU9C-0003Bv-Vz for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 18:19:23 +0100 Original-Received: from localhost ([::1]:45502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHU9C-0007jz-0Z for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 12:19:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHS67-0000uY-5h for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 10:08:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54398) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHS66-00060Z-KW for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 10:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHS66-0006Uk-E9 for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 10:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Feb 2022 15:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53853-submit@debbugs.gnu.org id=B53853.164433286324938 (code B ref 53853); Tue, 08 Feb 2022 15:08:02 +0000 Original-Received: (at 53853) by debbugs.gnu.org; 8 Feb 2022 15:07:43 +0000 Original-Received: from localhost ([127.0.0.1]:48295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHS5n-0006UA-G1 for submit@debbugs.gnu.org; Tue, 08 Feb 2022 10:07:43 -0500 Original-Received: from mail-wr1-f42.google.com ([209.85.221.42]:47002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHS5l-0006Ti-Rw for 53853@debbugs.gnu.org; Tue, 08 Feb 2022 10:07:42 -0500 Original-Received: by mail-wr1-f42.google.com with SMTP id q7so3131548wrc.13 for <53853@debbugs.gnu.org>; Tue, 08 Feb 2022 07:07:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=zF5Fz5usNlIFYzOIcm7BNRavPhiA5gEx0O/ceMEZRKw=; b=Ipn6sFLCvnp+wdxRnzkmLNvBHAMJzZ5b1ifmvD8hRj/hWY6hJoMWcU/eQqdg+KsVg4 OmKbEU4Ju5TwrruhECZxFlypSLRTPliChiYcV9UDzCzHk2nxlTu9Q0CcH9eGWXqNBjU4 799qMb55imTeW1clhigZK87gpKTk1pJqBwH3YCyaLL/iufAArbTRnUuPBVkGXLPCsZzD 659IaX2Eo6sCQmgOQPBH30QHPK7rqQ5/7jB+Eg9tFvI79G0IUTS9sRKzORIxMddm/m5B wcLgqEe7QnTbuFk0vtma8Rs75AfMpSROe0WP7Vk8bJxTqoV+JHQgcWS14s+EB5jSrkec Pf/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=zF5Fz5usNlIFYzOIcm7BNRavPhiA5gEx0O/ceMEZRKw=; b=60nAary3I7j6qG5jvqTYWR92wQX7qbk1Po/SKjOuIZJ9Rd3vMxwG2b1pby9EULnXRP Plw16c3eg45aiUTtnmY+4tzKbI80uzlm6C7zkldb4nNvMdIX2sL3KbvWm+Pyrl6NCpoL XStMTEKYmB0sk4YeMGAJMCkd3hS8/x8btNDfyLkPRx33bM3XoiY89x327c0ombxRS1kl IQ5p1e1PKfUELD5cQvf+pD3TvOZ/rHNwudIqZgmyRXfTSzCrK89UWDkYsEPYZuc3FHaa Oal3CEM5YolUwdRCg4MIjXMDa3yds+YhhCfjCBwMaxVadOOr6VjC0hA9W9cEJz5Pomha 67eA== X-Gm-Message-State: AOAM531i91Och8F0VjyXnb+6sw/8LmfuNXs7k/acPZ0Fh/AXXmzyl1lR CYBeLQNqGQp/wFzza/WNQrzc0sUdruoZhA== X-Google-Smtp-Source: ABdhPJw/C8a7dDwggo6aL69Bill5pyeLnjXrA0ivcixUXevJ1kx+Uu67FXT5XXDtNDix5whhAD4WBA== X-Received: by 2002:a5d:5044:: with SMTP id h4mr3901049wrt.62.1644332855491; Tue, 08 Feb 2022 07:07:35 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb50:a7fc:d931:6725:24e8]) by smtp.gmail.com with ESMTPSA id o16sm1730106wrn.87.2022.02.08.07.07.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 07:07:34 -0800 (PST) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Tue, 8 Feb 2022 14:09:34 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226387 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>>> On Tue, 8 Feb 2022 14:09:34 +0000, Jo=C3=A3o T=C3=A1vora said: Jo=C3=A3o> Well, technically, I did "show the patch" even though I didn= 't author said Jo=C3=A3o> patch myself. I answered: >> It would seem that the right thing to do is to keep 26.1 dep and do = what Jo=C3=A3o> Guillaume Pasquet suggests: >> "or substitute the `string-replace` call with `replace-regexp-in-str= ing` Jo=C3=A3o> to maintain compatibility as I have done here: >>=20 Jo=C3=A3o> https://github.com/Etenil/flymake/commit/9f5f76907b1c258645f= 65728dd71e7cacffe6d22 Jo=C3=A3o> Anyway, all good now, just bring the Emacs dep down to 26.1.= Thanks. Just so we=CA=BCre all clear, we want this in emacs-28 (on top of Lars's change to use `replace-regexp-in-string'? --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename=0001-Mark-flymake-as-compatible-with-emacs-26.1.patch Content-Transfer-Encoding: quoted-printable >From 31af9bca99fa88350271e1a905c9b435eaec28cf Mon Sep 17 00:00:00 2001 From: Robert Pluim Date: Tue, 8 Feb 2022 16:04:15 +0100 Subject: [PATCH] Mark flymake as compatible with emacs-26.1 To: emacs-devel@gnu.org * lisp/progmodes/flymake.el: Bump package version and set emacs version in Package-Requires to 26.1 (Bug#53853). --- lisp/progmodes/flymake.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index e369cb1f21..83d7bc8641 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -4,9 +4,9 @@ =20 ;; Author: Pavel Kobyakov ;; Maintainer: Jo=C3=A3o T=C3=A1vora -;; Version: 1.2.1 +;; Version: 1.2.2 ;; Keywords: c languages tools -;; Package-Requires: ((emacs "28.1") (eldoc "1.1.0") (project "0.7.1")) +;; Package-Requires: ((emacs "26.1") (eldoc "1.1.0") (project "0.7.1")) =20 ;; This is a GNU ELPA :core package. Avoid functionality that is not ;; compatible with the version of Emacs recorded above. --=20 2.34.0 --=-=-= Content-Type: text/plain Robert -- --=-=-=--