unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Augusto Stoffel <arstoffel@gmail.com>, 59918@debbugs.gnu.org
Subject: bug#59918: 29.0.60; query-replace in the minibuffer lazy-highlights original buffer
Date: Tue, 13 Dec 2022 19:39:46 +0200	[thread overview]
Message-ID: <867cyvtd7h.fsf@mail.linkov.net> (raw)
In-Reply-To: <83y1rbpkyz.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 13 Dec 2022 14:05:40 +0200")

close 59918 29.0.60
thanks

>> @@ -4435,7 +4435,7 @@ minibuffer-lazy-highlight-setup
>>  highlighting.
>>  LAX-WHITESPACE: The value of `isearch-lax-whitespace' and
>>  `isearch-regexp-lax-whitespace' to use for lazy highlighting."
>> -  (if (not highlight)
>> +  (if (or (not highlight) (minibufferp))
>>        #'ignore
>>      (let ((unwind (make-symbol "minibuffer-lazy-highlight--unwind"))
>>            (after-change (make-symbol "minibuffer-lazy-highlight--after-change"))

Thanks for the patch.

> This is fine with me, but AFAIU it means that replacements in the
> minibuffer will never be highlighted, ever.  Is that what we want?  I
> thought Juri wanted to see highlighting there?

Highlighting is not visible here because the query-replace prompt
replaces the original minibuffer.  So I pushed the patch to emacs-29.





      reply	other threads:[~2022-12-13 17:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-09  7:42 bug#59918: 29.0.60; query-replace in the minibuffer lazy-highlights original buffer Juri Linkov
2022-12-10 17:20 ` Juri Linkov
2022-12-10 18:36   ` Eli Zaretskii
2022-12-11 11:40 ` Augusto Stoffel
2022-12-12 17:43   ` Juri Linkov
2022-12-12 18:07     ` Eli Zaretskii
2022-12-12 19:05       ` Augusto Stoffel
2022-12-12 19:28         ` Eli Zaretskii
2022-12-12 22:42           ` Augusto Stoffel
2022-12-13 12:05             ` Eli Zaretskii
2022-12-13 17:39               ` Juri Linkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=867cyvtd7h.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=59918@debbugs.gnu.org \
    --cc=arstoffel@gmail.com \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).