From: Augusto Stoffel <arstoffel@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 59918@debbugs.gnu.org
Subject: bug#59918: 29.0.60; query-replace in the minibuffer lazy-highlights original buffer
Date: Sun, 11 Dec 2022 12:40:00 +0100 [thread overview]
Message-ID: <87edt6419r.fsf@gmail.com> (raw)
In-Reply-To: <86y1rhhvsi.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 09 Dec 2022 09:42:49 +0200")
On Fri, 9 Dec 2022 at 09:42, Juri Linkov wrote:
> X-Debbugs-Cc: Augusto Stoffel <arstoffel@gmail.com>
>
> 0. emacs -Q
> 1. (setq enable-recursive-minibuffers t)
> 1. M-! is C-a
> 2. M-% is
>
> Matches are lazy-highlighted in the original buffer,
> but the replacement is going to be used to replace
> matches in the minibuffer.
I guess this happens because minibuffer-selected-window returns the
original buffer. I think this patch does the trick?
--8<---------------cut here---------------start------------->8---
modified lisp/isearch.el
@@ -4435,7 +4435,9 @@ minibuffer-lazy-highlight-setup
highlighting.
LAX-WHITESPACE: The value of `isearch-lax-whitespace' and
`isearch-regexp-lax-whitespace' to use for lazy highlighting."
- (if (not highlight)
+ (if (not (and highlight
+ (eq (current-buffer) (window-buffer
+ (minibuffer-selected-window)))))
#'ignore
(let ((unwind (make-symbol "minibuffer-lazy-highlight--unwind"))
(after-change (make-symbol "minibuffer-lazy-highlight--after-change"))
--8<---------------cut here---------------end--------------->8---
next prev parent reply other threads:[~2022-12-11 11:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 7:42 bug#59918: 29.0.60; query-replace in the minibuffer lazy-highlights original buffer Juri Linkov
2022-12-10 17:20 ` Juri Linkov
2022-12-10 18:36 ` Eli Zaretskii
2022-12-11 11:40 ` Augusto Stoffel [this message]
2022-12-12 17:43 ` Juri Linkov
2022-12-12 18:07 ` Eli Zaretskii
2022-12-12 19:05 ` Augusto Stoffel
2022-12-12 19:28 ` Eli Zaretskii
2022-12-12 22:42 ` Augusto Stoffel
2022-12-13 12:05 ` Eli Zaretskii
2022-12-13 17:39 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edt6419r.fsf@gmail.com \
--to=arstoffel@gmail.com \
--cc=59918@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).