From: Eli Zaretskii <eliz@gnu.org>
To: Augusto Stoffel <arstoffel@gmail.com>
Cc: 59918@debbugs.gnu.org, juri@linkov.net
Subject: bug#59918: 29.0.60; query-replace in the minibuffer lazy-highlights original buffer
Date: Mon, 12 Dec 2022 21:28:29 +0200 [thread overview]
Message-ID: <838rjcqv4y.fsf@gnu.org> (raw)
In-Reply-To: <87o7s8o31r.fsf@gmail.com> (message from Augusto Stoffel on Mon, 12 Dec 2022 20:05:52 +0100)
> From: Augusto Stoffel <arstoffel@gmail.com>
> Cc: Juri Linkov <juri@linkov.net>, 59918@debbugs.gnu.org
> Date: Mon, 12 Dec 2022 20:05:52 +0100
>
> On Mon, 12 Dec 2022 at 20:07, Eli Zaretskii wrote:
>
> > I admit that I don't understand the patch. minibuffer-selected-window
> > returns a window, not a buffer, and it returns the window that you
> > didn't want, AFAIU.
>
> The check in the patch is whether the buffer of the
> minibuffer-selected-window is the current buffer. It's meant to fail
> when you are about to start a recursive minibuffer.
Isn't that test fragile as well? Which buffer is considered "current"
and which window is considered "selected" when the minibuffer is
active is always a tricky question. Wouldn't it be better to test
instead that the we are in the minibuffer, and if so to use
minibuffer-window instead of minibuffer-selected-window?
> It may or may not be the best patch, but I would say it's the safe one
> if were to fix this in Emacs 29.
So is the method I suggest -- assuming that it works.
> > Also, was this code introduced in Emacs 28/29 or earlier?
>
> New in Emacs 29.
OK, so we must fix it on the emacs-29 branch. What remains is to
decide what fix to use.
Thanks.
next prev parent reply other threads:[~2022-12-12 19:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 7:42 bug#59918: 29.0.60; query-replace in the minibuffer lazy-highlights original buffer Juri Linkov
2022-12-10 17:20 ` Juri Linkov
2022-12-10 18:36 ` Eli Zaretskii
2022-12-11 11:40 ` Augusto Stoffel
2022-12-12 17:43 ` Juri Linkov
2022-12-12 18:07 ` Eli Zaretskii
2022-12-12 19:05 ` Augusto Stoffel
2022-12-12 19:28 ` Eli Zaretskii [this message]
2022-12-12 22:42 ` Augusto Stoffel
2022-12-13 12:05 ` Eli Zaretskii
2022-12-13 17:39 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838rjcqv4y.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=59918@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).