From: Eli Zaretskii <eliz@gnu.org>
To: Augusto Stoffel <arstoffel@gmail.com>
Cc: 59918@debbugs.gnu.org, juri@linkov.net
Subject: bug#59918: 29.0.60; query-replace in the minibuffer lazy-highlights original buffer
Date: Tue, 13 Dec 2022 14:05:40 +0200 [thread overview]
Message-ID: <83y1rbpkyz.fsf@gnu.org> (raw)
In-Reply-To: <878rjcnt09.fsf@gmail.com> (message from Augusto Stoffel on Mon, 12 Dec 2022 23:42:46 +0100)
> From: Augusto Stoffel <arstoffel@gmail.com>
> Cc: juri@linkov.net, 59918@debbugs.gnu.org
> Date: Mon, 12 Dec 2022 23:42:46 +0100
>
> On Mon, 12 Dec 2022 at 21:28, Eli Zaretskii wrote:
>
> > OK, so we must fix it on the emacs-29 branch. What remains is to
> > decide what fix to use.
>
> This one :-)
>
> >From bcebf9622bc11cb36e0a56bc1874f24cfa634210 Mon Sep 17 00:00:00 2001
> From: Augusto Stoffel <arstoffel@gmail.com>
> Date: Mon, 12 Dec 2022 23:07:28 +0100
> Subject: [PATCH] Don't allow lazy highlight from recursive minibuffers
>
> See bug#59918.
>
> * lisp/isearch.el (minibuffer-lazy-highlight-setup): Don't activate
> when starting a recursive minibuffer.
> ---
> lisp/isearch.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/isearch.el b/lisp/isearch.el
> index bc3697deb0a..6a17d18c45e 100644
> --- a/lisp/isearch.el
> +++ b/lisp/isearch.el
> @@ -4435,7 +4435,7 @@ minibuffer-lazy-highlight-setup
> highlighting.
> LAX-WHITESPACE: The value of `isearch-lax-whitespace' and
> `isearch-regexp-lax-whitespace' to use for lazy highlighting."
> - (if (not highlight)
> + (if (or (not highlight) (minibufferp))
> #'ignore
> (let ((unwind (make-symbol "minibuffer-lazy-highlight--unwind"))
> (after-change (make-symbol "minibuffer-lazy-highlight--after-change"))
This is fine with me, but AFAIU it means that replacements in the
minibuffer will never be highlighted, ever. Is that what we want? I
thought Juri wanted to see highlighting there?
next prev parent reply other threads:[~2022-12-13 12:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 7:42 bug#59918: 29.0.60; query-replace in the minibuffer lazy-highlights original buffer Juri Linkov
2022-12-10 17:20 ` Juri Linkov
2022-12-10 18:36 ` Eli Zaretskii
2022-12-11 11:40 ` Augusto Stoffel
2022-12-12 17:43 ` Juri Linkov
2022-12-12 18:07 ` Eli Zaretskii
2022-12-12 19:05 ` Augusto Stoffel
2022-12-12 19:28 ` Eli Zaretskii
2022-12-12 22:42 ` Augusto Stoffel
2022-12-13 12:05 ` Eli Zaretskii [this message]
2022-12-13 17:39 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y1rbpkyz.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=59918@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).