From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#59918: 29.0.60; query-replace in the minibuffer lazy-highlights original buffer Date: Tue, 13 Dec 2022 19:39:46 +0200 Organization: LINKOV.NET Message-ID: <867cyvtd7h.fsf@mail.linkov.net> References: <86y1rhhvsi.fsf@mail.linkov.net> <87edt6419r.fsf@gmail.com> <864ju0r002.fsf@mail.linkov.net> <83iligqyva.fsf@gnu.org> <87o7s8o31r.fsf@gmail.com> <838rjcqv4y.fsf@gnu.org> <878rjcnt09.fsf@gmail.com> <83y1rbpkyz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6769"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Augusto Stoffel , 59918@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 13 18:42:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p59IA-0001cf-Fo for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Dec 2022 18:42:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p59I4-0008IE-Gm; Tue, 13 Dec 2022 12:42:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p59I2-0008Hb-Hx for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2022 12:42:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p59I2-0001nL-A4 for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2022 12:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p59I1-0006pW-K9 for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2022 12:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Dec 2022 17:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59918 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59918-submit@debbugs.gnu.org id=B59918.167095326726236 (code B ref 59918); Tue, 13 Dec 2022 17:42:01 +0000 Original-Received: (at 59918) by debbugs.gnu.org; 13 Dec 2022 17:41:07 +0000 Original-Received: from localhost ([127.0.0.1]:33570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p59H8-0006p5-Uo for submit@debbugs.gnu.org; Tue, 13 Dec 2022 12:41:07 -0500 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:60583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p59H7-0006oX-7y; Tue, 13 Dec 2022 12:41:05 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 1671E1BF209; Tue, 13 Dec 2022 17:40:55 +0000 (UTC) In-Reply-To: <83y1rbpkyz.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 13 Dec 2022 14:05:40 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250866 Archived-At: close 59918 29.0.60 thanks >> @@ -4435,7 +4435,7 @@ minibuffer-lazy-highlight-setup >> highlighting. >> LAX-WHITESPACE: The value of `isearch-lax-whitespace' and >> `isearch-regexp-lax-whitespace' to use for lazy highlighting." >> - (if (not highlight) >> + (if (or (not highlight) (minibufferp)) >> #'ignore >> (let ((unwind (make-symbol "minibuffer-lazy-highlight--unwind")) >> (after-change (make-symbol "minibuffer-lazy-highlight--after-change")) Thanks for the patch. > This is fine with me, but AFAIU it means that replacements in the > minibuffer will never be highlighted, ever. Is that what we want? I > thought Juri wanted to see highlighting there? Highlighting is not visible here because the query-replace prompt replaces the original minibuffer. So I pushed the patch to emacs-29.