unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: arstoffel@gmail.com, 59918@debbugs.gnu.org
Subject: bug#59918: 29.0.60; query-replace in the minibuffer lazy-highlights original buffer
Date: Mon, 12 Dec 2022 20:07:53 +0200	[thread overview]
Message-ID: <83iligqyva.fsf@gnu.org> (raw)
In-Reply-To: <864ju0r002.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 12 Dec 2022 19:43:25 +0200)

> Cc: 59918@debbugs.gnu.org
> From: Juri Linkov <juri@linkov.net>
> Date: Mon, 12 Dec 2022 19:43:25 +0200
> 
> >> 1. (setq enable-recursive-minibuffers t)
> >> 1. M-! is C-a
> >> 2. M-% is
> >>
> >> Matches are lazy-highlighted in the original buffer,
> >> but the replacement is going to be used to replace
> >> matches in the minibuffer.
> >
> > I guess this happens because minibuffer-selected-window returns the
> > original buffer.  I think this patch does the trick?
> 
> We need to wait until Eli decides whether to install this
> to emacs-29 or master.

I admit that I don't understand the patch.  minibuffer-selected-window
returns a window, not a buffer, and it returns the window that you
didn't want, AFAIU.

Or maybe I don't understand the root cause -- could one of you please
elaborate on what happens and why this is the right patch?

Also, was this code introduced in Emacs 28/29 or earlier?

Thanks.





  reply	other threads:[~2022-12-12 18:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-09  7:42 bug#59918: 29.0.60; query-replace in the minibuffer lazy-highlights original buffer Juri Linkov
2022-12-10 17:20 ` Juri Linkov
2022-12-10 18:36   ` Eli Zaretskii
2022-12-11 11:40 ` Augusto Stoffel
2022-12-12 17:43   ` Juri Linkov
2022-12-12 18:07     ` Eli Zaretskii [this message]
2022-12-12 19:05       ` Augusto Stoffel
2022-12-12 19:28         ` Eli Zaretskii
2022-12-12 22:42           ` Augusto Stoffel
2022-12-13 12:05             ` Eli Zaretskii
2022-12-13 17:39               ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83iligqyva.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=59918@debbugs.gnu.org \
    --cc=arstoffel@gmail.com \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).