From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59918: 29.0.60; query-replace in the minibuffer lazy-highlights original buffer Date: Tue, 13 Dec 2022 14:05:40 +0200 Message-ID: <83y1rbpkyz.fsf@gnu.org> References: <86y1rhhvsi.fsf@mail.linkov.net> <87edt6419r.fsf@gmail.com> <864ju0r002.fsf@mail.linkov.net> <83iligqyva.fsf@gnu.org> <87o7s8o31r.fsf@gmail.com> <838rjcqv4y.fsf@gnu.org> <878rjcnt09.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13865"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59918@debbugs.gnu.org, juri@linkov.net To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 13 13:06:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p543E-0003Km-8R for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Dec 2022 13:06:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p542x-0005Yg-Gf; Tue, 13 Dec 2022 07:06:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p542s-0005To-O2 for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2022 07:06:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p542s-0001bT-DO for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2022 07:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p542s-0004Cw-4q for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2022 07:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Dec 2022 12:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59918 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59918-submit@debbugs.gnu.org id=B59918.167093315516166 (code B ref 59918); Tue, 13 Dec 2022 12:06:02 +0000 Original-Received: (at 59918) by debbugs.gnu.org; 13 Dec 2022 12:05:55 +0000 Original-Received: from localhost ([127.0.0.1]:59920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p542k-0004Cg-UW for submit@debbugs.gnu.org; Tue, 13 Dec 2022 07:05:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p542i-0004Ca-GI for 59918@debbugs.gnu.org; Tue, 13 Dec 2022 07:05:52 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p542c-0001UM-RC; Tue, 13 Dec 2022 07:05:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=p8+V05p8sf/kx3bkLETZbuGuWC0tCmXJvJ032sIxEQ4=; b=U7q4MWDdFRTB Mfvvno43BZOG+2ABtF77/A1WjFisdpvSQoWKUV+xDTKedbsx4WpfaeJfT/CYteCpKwF/TA17xCyFu 08eHNyNFDmcL1LJte8Cw9bpXB53/twf+LKnENaj6RWxrMVYrJ96fjDV6SJYm9zTU/1qjdCkidEczo TkqulHtK36s0F235VoCmMY3GpmEZpKFkpfiPWQKrojnQLdrt55CIGRnsM5uQZO9ihNCkEzcFL38RB BmeKh0zIgmKgrqD11XCrLdT1pr9qY/OFza/MSHzCs5qAWbs+kna1/eLGWfNaeu+JgcW1BcOQDeMsp OAYSYoaVS1kcxG36qOJvjg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p542S-0006lZ-Qe; Tue, 13 Dec 2022 07:05:39 -0500 In-Reply-To: <878rjcnt09.fsf@gmail.com> (message from Augusto Stoffel on Mon, 12 Dec 2022 23:42:46 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250821 Archived-At: > From: Augusto Stoffel > Cc: juri@linkov.net, 59918@debbugs.gnu.org > Date: Mon, 12 Dec 2022 23:42:46 +0100 > > On Mon, 12 Dec 2022 at 21:28, Eli Zaretskii wrote: > > > OK, so we must fix it on the emacs-29 branch. What remains is to > > decide what fix to use. > > This one :-) > > >From bcebf9622bc11cb36e0a56bc1874f24cfa634210 Mon Sep 17 00:00:00 2001 > From: Augusto Stoffel > Date: Mon, 12 Dec 2022 23:07:28 +0100 > Subject: [PATCH] Don't allow lazy highlight from recursive minibuffers > > See bug#59918. > > * lisp/isearch.el (minibuffer-lazy-highlight-setup): Don't activate > when starting a recursive minibuffer. > --- > lisp/isearch.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/isearch.el b/lisp/isearch.el > index bc3697deb0a..6a17d18c45e 100644 > --- a/lisp/isearch.el > +++ b/lisp/isearch.el > @@ -4435,7 +4435,7 @@ minibuffer-lazy-highlight-setup > highlighting. > LAX-WHITESPACE: The value of `isearch-lax-whitespace' and > `isearch-regexp-lax-whitespace' to use for lazy highlighting." > - (if (not highlight) > + (if (or (not highlight) (minibufferp)) > #'ignore > (let ((unwind (make-symbol "minibuffer-lazy-highlight--unwind")) > (after-change (make-symbol "minibuffer-lazy-highlight--after-change")) This is fine with me, but AFAIU it means that replacements in the minibuffer will never be highlighted, ever. Is that what we want? I thought Juri wanted to see highlighting there?