* bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2
@ 2024-01-10 13:31 Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 14:55 ` Stefan Kangas
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-01-10 13:31 UTC (permalink / raw)
To: 68367
[-- Attachment #1: Type: text/plain, Size: 444 bytes --]
My /etc/fstab file contains a line for the file system cgroup2 (i.e. for
cgroup v2 instead of cgroup for cgroup v1). I just learned about
etc-fstab-generic-mode and after loading generic-x and visiting
/etc/fstab, I saw that in the line for cgroup2, the entry in the type
column is fontified in the default face, not in font-lock-keyword-face,
unlike all other file system types in my /etc/fstab file. This patch
fixes the misfontification:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: etc-fstab-generic-mode patch --]
[-- Type: text/x-patch, Size: 276 bytes --]
diff --git a/lisp/generic-x.el b/lisp/generic-x.el
index b4ae0225943..373bfad92dd 100644
--- a/lisp/generic-x.el
+++ b/lisp/generic-x.el
@@ -1491,6 +1491,7 @@ etc-fstab-generic-mode
"cd9660"
"cfs"
"cgroup"
+ "cgroup2"
"cifs"
"coda"
"coherent"
[-- Attachment #3: Type: text/plain, Size: 698 bytes --]
While the misfontification isn't a regression -- the support for cgroups
(but only for cgroup v1) in etc-fstab-generic-mode was added in January
2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup
v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e.,
omitting cgroup2 was presumably an oversight in that commit.
In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.38, cairo version 1.18.0) of 2024-01-09 built on strobelfs2
Repository revision: fccaeabc959f5403ce49744030bd2620352b59f8
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101009
System Description: Linux From Scratch r12.0-112
^ permalink raw reply related [flat|nested] 7+ messages in thread* bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2
2024-01-10 13:31 bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2 Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-01-10 14:55 ` Stefan Kangas
2024-01-10 15:07 ` Eli Zaretskii
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Stefan Kangas @ 2024-01-10 14:55 UTC (permalink / raw)
To: Stephen Berman, 68367; +Cc: Eli Zaretskii
Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:
> My /etc/fstab file contains a line for the file system cgroup2 (i.e. for
> cgroup v2 instead of cgroup for cgroup v1). I just learned about
> etc-fstab-generic-mode and after loading generic-x and visiting
> /etc/fstab, I saw that in the line for cgroup2, the entry in the type
> column is fontified in the default face, not in font-lock-keyword-face,
> unlike all other file system types in my /etc/fstab file. This patch
> fixes the misfontification:
>
> diff --git a/lisp/generic-x.el b/lisp/generic-x.el
> index b4ae0225943..373bfad92dd 100644
> --- a/lisp/generic-x.el
> +++ b/lisp/generic-x.el
> @@ -1491,6 +1491,7 @@ etc-fstab-generic-mode
> "cd9660"
> "cfs"
> "cgroup"
> + "cgroup2"
> "cifs"
> "coda"
> "coherent"
Thanks, but could you please reformat this using `git format-patch -1`?
> While the misfontification isn't a regression -- the support for cgroups
> (but only for cgroup v1) in etc-fstab-generic-mode was added in January
> 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup
> v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e.,
> omitting cgroup2 was presumably an oversight in that commit.
I don't really have an opinion, but sounds good to me. Eli?
^ permalink raw reply [flat|nested] 7+ messages in thread* bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2
2024-01-10 14:55 ` Stefan Kangas
@ 2024-01-10 15:07 ` Eli Zaretskii
2024-01-10 15:26 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 15:27 ` Stefan Kangas
2 siblings, 0 replies; 7+ messages in thread
From: Eli Zaretskii @ 2024-01-10 15:07 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 68367, stephen.berman
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Wed, 10 Jan 2024 06:55:30 -0800
> Cc: Eli Zaretskii <eliz@gnu.org>
>
> Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of
> text editors" <bug-gnu-emacs@gnu.org> writes:
>
> > While the misfontification isn't a regression -- the support for cgroups
> > (but only for cgroup v1) in etc-fstab-generic-mode was added in January
> > 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup
> > v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e.,
> > omitting cgroup2 was presumably an oversight in that commit.
>
> I don't really have an opinion, but sounds good to me. Eli?
I don't mind adding this to emacs-29.
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2
2024-01-10 14:55 ` Stefan Kangas
2024-01-10 15:07 ` Eli Zaretskii
@ 2024-01-10 15:26 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 15:27 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 15:27 ` Stefan Kangas
2024-01-10 15:27 ` Stefan Kangas
2 siblings, 2 replies; 7+ messages in thread
From: Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-01-10 15:26 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Eli Zaretskii, 68367
On Wed, 10 Jan 2024 06:55:30 -0800 Stefan Kangas <stefankangas@gmail.com> wrote:
> Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of
> text editors" <bug-gnu-emacs@gnu.org> writes:
>
>> My /etc/fstab file contains a line for the file system cgroup2 (i.e. for
>> cgroup v2 instead of cgroup for cgroup v1). I just learned about
>> etc-fstab-generic-mode and after loading generic-x and visiting
>> /etc/fstab, I saw that in the line for cgroup2, the entry in the type
>> column is fontified in the default face, not in font-lock-keyword-face,
>> unlike all other file system types in my /etc/fstab file. This patch
>> fixes the misfontification:
>>
>> diff --git a/lisp/generic-x.el b/lisp/generic-x.el
>> index b4ae0225943..373bfad92dd 100644
>> --- a/lisp/generic-x.el
>> +++ b/lisp/generic-x.el
>> @@ -1491,6 +1491,7 @@ etc-fstab-generic-mode
>> "cd9660"
>> "cfs"
>> "cgroup"
>> + "cgroup2"
>> "cifs"
>> "coda"
>> "coherent"
>
> Thanks, but could you please reformat this using `git format-patch -1`?
On Wed, 10 Jan 2024 17:07:26 +0200 Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Stefan Kangas <stefankangas@gmail.com>
>> Date: Wed, 10 Jan 2024 06:55:30 -0800
>> Cc: Eli Zaretskii <eliz@gnu.org>
>>
>> Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of
>> text editors" <bug-gnu-emacs@gnu.org> writes:
>>
>> > While the misfontification isn't a regression -- the support for cgroups
>> > (but only for cgroup v1) in etc-fstab-generic-mode was added in January
>> > 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup
>> > v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e.,
>> > omitting cgroup2 was presumably an oversight in that commit.
>>
>> I don't really have an opinion, but sounds good to me. Eli?
>
> I don't mind adding this to emacs-29.
>
> Thanks.
Instead of resending the patch I just went ahead and installed it to
emacs-29.
Steve Berman
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2
2024-01-10 15:26 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-01-10 15:27 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 15:27 ` Stefan Kangas
1 sibling, 0 replies; 7+ messages in thread
From: Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-01-10 15:27 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Eli Zaretskii, 68367-done
On Wed, 10 Jan 2024 16:26:21 +0100 Stephen Berman <stephen.berman@gmx.net> wrote:
> On Wed, 10 Jan 2024 06:55:30 -0800 Stefan Kangas <stefankangas@gmail.com> wrote:
>
>> Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of
>> text editors" <bug-gnu-emacs@gnu.org> writes:
>>
>>> My /etc/fstab file contains a line for the file system cgroup2 (i.e. for
>>> cgroup v2 instead of cgroup for cgroup v1). I just learned about
>>> etc-fstab-generic-mode and after loading generic-x and visiting
>>> /etc/fstab, I saw that in the line for cgroup2, the entry in the type
>>> column is fontified in the default face, not in font-lock-keyword-face,
>>> unlike all other file system types in my /etc/fstab file. This patch
>>> fixes the misfontification:
>>>
>>> diff --git a/lisp/generic-x.el b/lisp/generic-x.el
>>> index b4ae0225943..373bfad92dd 100644
>>> --- a/lisp/generic-x.el
>>> +++ b/lisp/generic-x.el
>>> @@ -1491,6 +1491,7 @@ etc-fstab-generic-mode
>>> "cd9660"
>>> "cfs"
>>> "cgroup"
>>> + "cgroup2"
>>> "cifs"
>>> "coda"
>>> "coherent"
>>
>> Thanks, but could you please reformat this using `git format-patch -1`?
>
> On Wed, 10 Jan 2024 17:07:26 +0200 Eli Zaretskii <eliz@gnu.org> wrote:
>
>>> From: Stefan Kangas <stefankangas@gmail.com>
>>> Date: Wed, 10 Jan 2024 06:55:30 -0800
>>> Cc: Eli Zaretskii <eliz@gnu.org>
>>>
>>> Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of
>>> text editors" <bug-gnu-emacs@gnu.org> writes:
>>>
>>> > While the misfontification isn't a regression -- the support for cgroups
>>> > (but only for cgroup v1) in etc-fstab-generic-mode was added in January
>>> > 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup
>>> > v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e.,
>>> > omitting cgroup2 was presumably an oversight in that commit.
>>>
>>> I don't really have an opinion, but sounds good to me. Eli?
>>
>> I don't mind adding this to emacs-29.
>>
>> Thanks.
>
> Instead of resending the patch I just went ahead and installed it to
> emacs-29.
And now closed the bug.
Steve Berman
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2
2024-01-10 15:26 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 15:27 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-01-10 15:27 ` Stefan Kangas
1 sibling, 0 replies; 7+ messages in thread
From: Stefan Kangas @ 2024-01-10 15:27 UTC (permalink / raw)
To: Stephen Berman; +Cc: Eli Zaretskii, 68367
Stephen Berman <stephen.berman@gmx.net> writes:
> Instead of resending the patch I just went ahead and installed it to
> emacs-29.
Thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2
2024-01-10 14:55 ` Stefan Kangas
2024-01-10 15:07 ` Eli Zaretskii
2024-01-10 15:26 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-01-10 15:27 ` Stefan Kangas
2 siblings, 0 replies; 7+ messages in thread
From: Stefan Kangas @ 2024-01-10 15:27 UTC (permalink / raw)
To: Stephen Berman, 68367; +Cc: Eli Zaretskii
Stefan Kangas <stefankangas@gmail.com> writes:
> Thanks, but could you please reformat this using `git format-patch -1`?
Ah, I forgot you have commit access. My bad.
So please just install this on emacs-29. Thanks in advance.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-01-10 15:27 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-10 13:31 bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2 Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 14:55 ` Stefan Kangas
2024-01-10 15:07 ` Eli Zaretskii
2024-01-10 15:26 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 15:27 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 15:27 ` Stefan Kangas
2024-01-10 15:27 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).