From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2 Date: Wed, 10 Jan 2024 14:31:32 +0100 Message-ID: <87o7dtmi17.fsf@gmx.net> Reply-To: Stephen Berman Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6992"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 68367@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 10 14:59:49 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNZ7V-0001aD-49 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jan 2024 14:59:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNZ7M-0004rK-Fn; Wed, 10 Jan 2024 08:59:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNZ6q-0004mK-Bk for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 08:59:08 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNZ6q-00011F-3h for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 08:59:08 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNZ6k-0003Tb-MB for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 08:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2024 13:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 68367 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.170489508713216 (code B ref -1); Wed, 10 Jan 2024 13:59:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 Jan 2024 13:58:07 +0000 Original-Received: from localhost ([127.0.0.1]:39319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNZ5r-0003R5-6D for submit@debbugs.gnu.org; Wed, 10 Jan 2024 08:58:07 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:44900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNZ5n-0003Py-KQ for submit@debbugs.gnu.org; Wed, 10 Jan 2024 08:58:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNYgF-0000Ck-Nw for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 08:31:39 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNYgC-0004AY-Sa for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 08:31:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1704893493; x=1705498293; i=stephen.berman@gmx.net; bh=pO7P0FzEU6FHVADXKLmMePmeOhcsaD8X1RhGPFTn+do=; h=X-UI-Sender-Class:From:To:Subject:Date; b=KsvEM0T28DZMQzrhAgEulwQrR/J23X4MySLYoHACLMKbPUOLpvMU8q2mUT/LynhW 2WsM/Adpkv6Px/4cp3UyZH1HM47XwWD/Hq021TbPOdf9zUBiSlLcI91DzE7DphYov pQE5AczHHi9Y7YWjCIOrTm+GZJTU+YInQKaaY4hsyD5gAu4+n59efjWe9lWE2VgBU HXp6rxi55CegXIcZwglUH9JUIyPDNPUEBKE3nY7HeJ945D55StVKgpzESvdNqlUFp hIk71ZyI0u0k09UBV+FXEtTdhpPe+hsRIbKTWn2i98BU9qSwovtycmB0dIkqG/495 LHSNYMwbkMMEExVPoQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfs2 ([89.246.37.31]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MJVDM-1rd1AL0wky-00Jpmi for ; Wed, 10 Jan 2024 14:31:33 +0100 X-Provags-ID: V03:K1:nc7QurvtF6d+aD/sMjcLYY2D0s3kuUGgEGgOOmwcomGhZSMibPw EzuDHijXkfLiknEIaMw/puZ9ZxIMXfMR2SINnx78ntyxmLpEEtaw+DhguwwSeRqql0I96HF ABQHXTh0P8XhEMUAZMshY1/tJr+BP71R1BjbBXiYXKcyPpiy7U/oaKCu+50fmssS+yv+dk0 rxuxQb9jKRlyt6zDg8cmQ== UI-OutboundReport: notjunk:1;M01:P0:mDSumuet3ng=;xQcqIaCi8Ymb3beNxOiL10mNA0C c26ubQZc0ZCZ3IizYgqMJYr2LMCIe4y/zl20DbKb3e5wARswGx+fU4ELUUm21g3Ufx0D1ozo2 /2LpyvzRdgYxq49GcbOBrKmpw6DJsxl50hNoyxJDeGp6HLfTLrzTASDa11on3rUMjqS69CNlu DRv6hXabGkBI02xI4Bej7zRH3+oAkhyManfhlfuwj8R2+vAu/xfDlc+6IlT+zFNNSneGG4Hp5 qTayDbRxQlGDFwcWoeGmHbwzqKZXVEdfzLwvF2V4q+Z7jBzMGhRNVipYziYAlDRrejKYr51qr iJ1EZY1ECPMxP4GV2BE91M22yZ5FgRq63aProHHOTg/eaE2gVqteMwaqWev+s0270nVUNdIz0 i8tmJB8BNr9BHyNL3dFdatQhH5PYoaUdIu22O38jbvvNjZiXQjYVFc4Yg6NGLpWeq8D9ARZTF tw7udt22HbU/dtxOoElsu1pO8HeISXjrpSiWwYuS/e8q/am37XjudguJvwaEdePCYEE8Hm7Uz ampUE2Q9bIMmGB/zTP2YauzXexjehOkRRBvwzV0F0TvamweASf2YAKCbl48nvoqXLA4yX8pej F853+L+TeblQKj+MY4dF0GE7MyMRmQKvjYrQqD/XKrmAaZ4fNTBd0vPFh8/BfYY1ZYzRZnz+j xqqT2AYMVi6xIWCSdzlOzZ/qskYKn3xml7d33k9CgfN+ta6WThTrkHS0p1oDKTAH479EpUol3 fWW/ykf/4WZL90lR2DoojRPywXtriUHCwBaMni7pQFxVu7KGTaUfb2o4Qh0bZ8+aQkKwpiaJ Received-SPF: pass client-ip=212.227.17.21; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277748 Archived-At: --=-=-= Content-Type: text/plain My /etc/fstab file contains a line for the file system cgroup2 (i.e. for cgroup v2 instead of cgroup for cgroup v1). I just learned about etc-fstab-generic-mode and after loading generic-x and visiting /etc/fstab, I saw that in the line for cgroup2, the entry in the type column is fontified in the default face, not in font-lock-keyword-face, unlike all other file system types in my /etc/fstab file. This patch fixes the misfontification: --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: etc-fstab-generic-mode patch diff --git a/lisp/generic-x.el b/lisp/generic-x.el index b4ae0225943..373bfad92dd 100644 --- a/lisp/generic-x.el +++ b/lisp/generic-x.el @@ -1491,6 +1491,7 @@ etc-fstab-generic-mode "cd9660" "cfs" "cgroup" + "cgroup2" "cifs" "coda" "coherent" --=-=-= Content-Type: text/plain While the misfontification isn't a regression -- the support for cgroups (but only for cgroup v1) in etc-fstab-generic-mode was added in January 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e., omitting cgroup2 was presumably an oversight in that commit. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.18.0) of 2024-01-09 built on strobelfs2 Repository revision: fccaeabc959f5403ce49744030bd2620352b59f8 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101009 System Description: Linux From Scratch r12.0-112 --=-=-=--