unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 68367@debbugs.gnu.org
Subject: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2
Date: Wed, 10 Jan 2024 14:31:32 +0100	[thread overview]
Message-ID: <87o7dtmi17.fsf@gmx.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

My /etc/fstab file contains a line for the file system cgroup2 (i.e. for
cgroup v2 instead of cgroup for cgroup v1).  I just learned about
etc-fstab-generic-mode and after loading generic-x and visiting
/etc/fstab, I saw that in the line for cgroup2, the entry in the type
column is fontified in the default face, not in font-lock-keyword-face,
unlike all other file system types in my /etc/fstab file.  This patch
fixes the misfontification:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: etc-fstab-generic-mode patch --]
[-- Type: text/x-patch, Size: 276 bytes --]

diff --git a/lisp/generic-x.el b/lisp/generic-x.el
index b4ae0225943..373bfad92dd 100644
--- a/lisp/generic-x.el
+++ b/lisp/generic-x.el
@@ -1491,6 +1491,7 @@ etc-fstab-generic-mode
     "cd9660"
     "cfs"
     "cgroup"
+    "cgroup2"
     "cifs"
     "coda"
     "coherent"

[-- Attachment #3: Type: text/plain, Size: 698 bytes --]


While the misfontification isn't a regression -- the support for cgroups
(but only for cgroup v1) in etc-fstab-generic-mode was added in January
2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup
v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e.,
omitting cgroup2 was presumably an oversight in that commit.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.18.0) of 2024-01-09 built on strobelfs2
Repository revision: fccaeabc959f5403ce49744030bd2620352b59f8
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101009
System Description: Linux From Scratch r12.0-112

             reply	other threads:[~2024-01-10 13:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-10 13:31 Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-01-10 14:55 ` bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2 Stefan Kangas
2024-01-10 15:07   ` Eli Zaretskii
2024-01-10 15:26   ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 15:27     ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 15:27     ` Stefan Kangas
2024-01-10 15:27   ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7dtmi17.fsf@gmx.net \
    --to=bug-gnu-emacs@gnu.org \
    --cc=68367@debbugs.gnu.org \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).