From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2 Date: Wed, 10 Jan 2024 16:26:21 +0100 Message-ID: <87jzohmcpu.fsf@gmx.net> References: <87o7dtmi17.fsf@gmx.net> Reply-To: Stephen Berman Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39114"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 68367@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 10 16:27:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNaUE-0009yU-4Q for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jan 2024 16:27:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNaTy-0008RE-5r; Wed, 10 Jan 2024 10:27:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNaTv-0008QW-NA for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 10:27:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNaTv-0000Ha-FE for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 10:27:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNaTu-0005nw-2S for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 10:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2024 15:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68367 X-GNU-PR-Package: emacs Original-Received: via spool by 68367-submit@debbugs.gnu.org id=B68367.170490039122266 (code B ref 68367); Wed, 10 Jan 2024 15:27:02 +0000 Original-Received: (at 68367) by debbugs.gnu.org; 10 Jan 2024 15:26:31 +0000 Original-Received: from localhost ([127.0.0.1]:42498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNaTO-0005n4-P0 for submit@debbugs.gnu.org; Wed, 10 Jan 2024 10:26:31 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:39019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNaTL-0005mc-Up for 68367@debbugs.gnu.org; Wed, 10 Jan 2024 10:26:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1704900382; x=1705505182; i=stephen.berman@gmx.net; bh=ccEZEULkX1GVpOYKoYGlxhz7fr08I13l2ofIl5ARkkw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=rwINlL9E151iECpv++VeI8hSgKQu1Hq4usNuim2rKy/8pOHWX4zNlq24rZtDXVFe jakL+G5AL2tNhHuBOPyYvmGv/2rTq2T+npB1peoQRyAVu+0N1ryw2Qb1RBV/Xkjy3 BXyPy4riB9ryPUVmSfl+xQo9jqxVlh9W/MTD4fDzuAjhqeA7R7g3i5zmvFAeTn21Q gREKefQ0f2tObjj9vI1UFjhzmyfdDr8uTmYKRoHzJpJuYCaalNMGE4jgz3s7a8Us4 nGVABw1r76XSBdKzTuSOIj0LGV/2OKungn4F9OkI0lnATnEdpHcr5crnfhRsk7zsd 5+dRPG+q19ZA9bmuCQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfs2 ([89.246.37.31]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MN5eR-1reQOp1xQL-00J3nc; Wed, 10 Jan 2024 16:26:22 +0100 In-Reply-To: (Stefan Kangas's message of "Wed, 10 Jan 2024 06:55:30 -0800") X-Provags-ID: V03:K1:4a1xFaCDIdK6FTtIv4E/iNUOZIKwjo172zub8/nWmqg7zulxm8d wFPjip8n+VyNpRYWGoS65gUQOeYYhqRpE3sVfYc6RrgTUIVNmGDvyPpl/kcQb/AW/gVZKhV qehk5zb6ptV4h9it94Bne5lgWbLO1I8dyIKPbDs7cV4pdDg42c1rHyT+hD1ar27Io8anmMq MtM9E7fXZ2lAykIBW0wfA== UI-OutboundReport: notjunk:1;M01:P0:ArZ4exDyHGo=;Lat+R13A/BhP6kgz/EZ7QZZro2R yvzqsJZR1KmsSkG6Hk5qcwDV0AK7AyiiCZNruyvLj7Tk7f9yA9h4Ceow/rFEqYbLLtxm4RIWE MxTLeRL8yBRyVSn80onMETxsp8freqni5RpvJBTR6WQiRryec8KLsbzJIZ0C5qhOXGfyFBMCU VhVrNADea/i5lugJqIbppPcPhhVFV4JZXmbDHMt3ScNSINck2DUwAiBU34FeUX8YfI7SAdVlb XXs44eKGJcFWOxhYQ8JnO6O4e50g65uJbhnvTWJJ/fJtrp3aEfzI2ijYQXtcJeN7g1RiB5yzH QOqNrBuZA7iHYK7+tPZ0BRh0kJJpDGDo1QAnLRwlHlJ0Z0Tpicwh7hmgyE+BJR6TjmRMpzRGg T1GHe8q7WoKlYiGsbYAMwsrXxQ9GHM6PcHWPx4+LruBlQtpkdVq8SGv5/jNUbNNsDDHYlF5Qn eAmbnqkZ7ztuAH68PEiOsfhSCNm6ixMiKH2znXZO8x3KpGeaStaIwglBEZ4bgj0vP1NuLAneU s2hSQlHxBeuLsmoqfFdfJh+LgJxvrHHratQE9qvjtsDBfu5ERswrsaPoyzJfPx51BTMcoYGus S7zwxjFqONnG529cEmYdpBVxC8CyK1/urB1CV3lRlOQetYzJUd8ZX/7hB9INMKZUqz4q14l9f iBJcNpGFHMvrWeL4Ltd8ZmEpRIjbOGW6toPJ+yzXnpXKZS7PVY2VBabcHwW0YHUoh2qqFXM1k 8HmMrr6+cXMcdobBkP0gIeFmJ+TFShoMvBchijRvFJfrM3YrZuBG+TpmAcqFyCXvxAEj5FRv X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277759 Archived-At: On Wed, 10 Jan 2024 06:55:30 -0800 Stefan Kangas = wrote: > Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > >> My /etc/fstab file contains a line for the file system cgroup2 (i.e. fo= r >> cgroup v2 instead of cgroup for cgroup v1). I just learned about >> etc-fstab-generic-mode and after loading generic-x and visiting >> /etc/fstab, I saw that in the line for cgroup2, the entry in the type >> column is fontified in the default face, not in font-lock-keyword-face, >> unlike all other file system types in my /etc/fstab file. This patch >> fixes the misfontification: >> >> diff --git a/lisp/generic-x.el b/lisp/generic-x.el >> index b4ae0225943..373bfad92dd 100644 >> --- a/lisp/generic-x.el >> +++ b/lisp/generic-x.el >> @@ -1491,6 +1491,7 @@ etc-fstab-generic-mode >> "cd9660" >> "cfs" >> "cgroup" >> + "cgroup2" >> "cifs" >> "coda" >> "coherent" > > Thanks, but could you please reformat this using `git format-patch -1`? On Wed, 10 Jan 2024 17:07:26 +0200 Eli Zaretskii wrote: >> From: Stefan Kangas >> Date: Wed, 10 Jan 2024 06:55:30 -0800 >> Cc: Eli Zaretskii >> >> Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of >> text editors" writes: >> >> > While the misfontification isn't a regression -- the support for cgro= ups >> > (but only for cgroup v1) in etc-fstab-generic-mode was added in Janua= ry >> > 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgr= oup >> > v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.= e., >> > omitting cgroup2 was presumably an oversight in that commit. >> >> I don't really have an opinion, but sounds good to me. Eli? > > I don't mind adding this to emacs-29. > > Thanks. Instead of resending the patch I just went ahead and installed it to emacs-29. Steve Berman