From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2 Date: Wed, 10 Jan 2024 16:27:21 +0100 Message-ID: <87cyu9mco6.fsf@gmx.net> References: <87o7dtmi17.fsf@gmx.net> <87jzohmcpu.fsf@gmx.net> Reply-To: Stephen Berman Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6517"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 68367-done@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 10 16:28:51 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNaVe-0001S9-69 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jan 2024 16:28:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNaV1-0000va-2Q; Wed, 10 Jan 2024 10:28:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNaUw-0000uO-S9 for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 10:28:06 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNaUv-0000Zz-6T for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 10:28:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNaUt-0005ql-Q2 for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 10:28:03 -0500 Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2024 15:28:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 68367 X-GNU-PR-Package: emacs Mail-Followup-To: 68367@debbugs.gnu.org, stephen.berman@gmx.net, stephen.berman@gmx.net Original-Received: via spool by 68367-done@debbugs.gnu.org id=D68367.170490044722386 (code D ref 68367); Wed, 10 Jan 2024 15:28:03 +0000 Original-Received: (at 68367-done) by debbugs.gnu.org; 10 Jan 2024 15:27:27 +0000 Original-Received: from localhost ([127.0.0.1]:42506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNaUJ-0005oy-Gj for submit@debbugs.gnu.org; Wed, 10 Jan 2024 10:27:27 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:55371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNaUI-0005ob-Aa for 68367-done@debbugs.gnu.org; Wed, 10 Jan 2024 10:27:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1704900441; x=1705505241; i=stephen.berman@gmx.net; bh=GxXQR5RS9dbVD1NTV+nhsS8BLFtQPLvzm0J+dBcwCUs=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=SLGrynuluAPOWla46r6OjEVi5TbcPRHrpljEKncNWbPjF2DHIWcb+/0NES8Iax4d z7xF796rj/Szs6VDZuVQVKop6sfRjJmbto2Pc2J8+R7qwbuxg5sZFVZ+Oyo0RBY0X O/5SSITWvV5MfZw+uROo3KV49WJD+2HvcZDdQsXxnrPj+i+/qpJATQ/Vz47PaeUhF L9Ls51pDwWijkoMCDFKadZCAnbQzlLeor1kxzz68hOPn+Tqpw4FyWoGV1Ch6u+2n3 NVVhyb+GSyc2hilwOqD5/3PA2Wg3MLPpokst5dP70lK8eN/hPFxE48LnW5Tg9bfk4 78FBEBnpzh9P8aAr/w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfs2 ([89.246.37.31]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mq2j2-1qs35v2YPi-00n9tT; Wed, 10 Jan 2024 16:27:21 +0100 In-Reply-To: <87jzohmcpu.fsf@gmx.net> (Stephen Berman's message of "Wed, 10 Jan 2024 16:26:21 +0100") X-Provags-ID: V03:K1:jUKigX9gBFu/EbiSJ06DKrF+6S7+7+NgDb9ssL6Cia/mXwdx8iS ddvF7zEi5yqMoNh8qBdRa9IC055mS5gyndfStNr6qRKRRvy3wrqGbBjeecEPDbtQZNn5sOn LSexe8KsENpNB43qRquHPMS9SJUOSSOyxp6Z7P7FybNsja7ZepVEB4+UIV/7RIX3vLVzC8+ G4IXWL/ZAEPWMXGHM268Q== UI-OutboundReport: notjunk:1;M01:P0:tUxv6RyM76U=;L/5No8XNwA/hpSQ+jKi229wTFDp IwWOeeEkYbD5drKNcSoySU0nSiimFEH8kDWPqLmuHGbvMc+1EZJXZaFLooMX9TSFIyf007PHI cZAwOLXNnYOuESwrIoSLPVzVgj8unz1PptbQLpdzvFDlAPemAgItpxvWEpOc2WV06muRAWw4B bXbN380YoatXuI1dyCijUY8Hw+Hwy8RQypD546HJNM/1cBu/vqeXJ9FYz/jhFbV/AkVOWx35o GvCaeTNVecKJCUQEToB+rExPIqb81VXYJUH5xY2h2ublshoZQsGkDC3hcUGNUlv+O9F0eMVkn 59aX5RYxe1KT2aNpam8X86GtEZL584OmVq2+r/1YLb2FZaEcMiF0sKM+I1QddSlgUavfu2H7g XSZj1XkGJxrQKwav6jz5JwGNwNU8K+gxCc+oebbppxix7r+Bq5FX4W3rRaN82zoIVaoHGVkEK e+1XAi5tpGFM7DlR7tFHTKtdwsQeBZ8wT1BRx5Iz19XSFRzpUFpUQ19H3ecfkFHM9xZ0jJ6e4 RlE3KfVDhZWjR+UZfHONwBufPYKLkBqQRdYOEYryXkpysfeyy6D3EzaHwNS6/6PrTRwP082bs nbcpiUFNwxC3userj/KL0GPQPLYPMfGhzyteFo3462icB3qnQnHyBoIf5+xOqw0crye7R6bld 7zF1+AH54Nufvn7MGKPd+bQCiWvuGMnCZC/itBV4pNv4nWt9nRkf9/MOH5LFIQEti6fKGRGL6 /OoThp/xSJbwoDhtMb3yfli+BG1J3aNgML7wrNbec1rbG7Yr4LmzkGnY1eeQCcGwH7EOKNwW X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277763 Archived-At: On Wed, 10 Jan 2024 16:26:21 +0100 Stephen Berman = wrote: > On Wed, 10 Jan 2024 06:55:30 -0800 Stefan Kangas wrote: > >> Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of >> text editors" writes: >> >>> My /etc/fstab file contains a line for the file system cgroup2 (i.e. f= or >>> cgroup v2 instead of cgroup for cgroup v1). I just learned about >>> etc-fstab-generic-mode and after loading generic-x and visiting >>> /etc/fstab, I saw that in the line for cgroup2, the entry in the type >>> column is fontified in the default face, not in font-lock-keyword-face= , >>> unlike all other file system types in my /etc/fstab file. This patch >>> fixes the misfontification: >>> >>> diff --git a/lisp/generic-x.el b/lisp/generic-x.el >>> index b4ae0225943..373bfad92dd 100644 >>> --- a/lisp/generic-x.el >>> +++ b/lisp/generic-x.el >>> @@ -1491,6 +1491,7 @@ etc-fstab-generic-mode >>> "cd9660" >>> "cfs" >>> "cgroup" >>> + "cgroup2" >>> "cifs" >>> "coda" >>> "coherent" >> >> Thanks, but could you please reformat this using `git format-patch -1`? > > On Wed, 10 Jan 2024 17:07:26 +0200 Eli Zaretskii wrote: > >>> From: Stefan Kangas >>> Date: Wed, 10 Jan 2024 06:55:30 -0800 >>> Cc: Eli Zaretskii >>> >>> Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of >>> text editors" writes: >>> >>> > While the misfontification isn't a regression -- the support for cgr= oups >>> > (but only for cgroup v1) in etc-fstab-generic-mode was added in Janu= ary >>> > 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cg= roup >>> > v2 became official in the Linux kernel in March 2016 (kernel 4.5); i= .e., >>> > omitting cgroup2 was presumably an oversight in that commit. >>> >>> I don't really have an opinion, but sounds good to me. Eli? >> >> I don't mind adding this to emacs-29. >> >> Thanks. > > Instead of resending the patch I just went ahead and installed it to > emacs-29. And now closed the bug. Steve Berman