From: Eli Zaretskii <eliz@gnu.org>
To: Fab Rice <posh18@pirilampo.be>
Cc: 40759@debbugs.gnu.org, stefan@marxist.se,
Stefan Monnier <monnier@iro.umontreal.ca>,
egrep@protonmail.ch, dgutov@yandex.ru
Subject: bug#40759: 26.3; Update Leuven-theme in Emacs dev trunk
Date: Sat, 25 Apr 2020 11:49:50 +0300 [thread overview]
Message-ID: <83k1247xw1.fsf@gnu.org> (raw)
In-Reply-To: <0fc0b188e6cca472e8f06c570fee7a4d@pirilampo.be> (message from Fab Rice on Fri, 24 Apr 2020 14:09:56 +0200)
> Date: Fri, 24 Apr 2020 14:09:56 +0200
> From: Fab Rice <posh18@pirilampo.be>
> Cc: Serghei <egrep@protonmail.ch>, stefan@marxist.se, 40759@debbugs.gnu.org,
> dgutov@yandex.ru
>
> +(defgroup leuven nil
> + "Leuven theme options.
> +The theme has to be reloaded after changing anything in this group."
> + :group 'faces)
> +
> +(defcustom leuven-scale-outline-headlines t
> + "Scale `outline' (and `org') level-1 headlines.
> +This can be nil for unscaled, t for using the theme default, or a scaling
> +number."
> + :type '(choice
> + (const :tag "Unscaled" nil)
> + (const :tag "Default provided by theme" t)
> + (number :tag "Set scaling"))
> + :group 'leuven)
> +
> +(defcustom leuven-scale-org-agenda-structure t
> + "Scale Org agenda structure lines, like dates.
> +This can be nil for unscaled, t for using the theme default, or a scaling
> +number."
> + :type '(choice
> + (const :tag "Unscaled" nil)
> + (const :tag "Default provided by theme" t)
> + (number :tag "Set scaling")))
We don't have defcustom's in any other theme I see in etc/themes/.
Does 'disable-theme' know how to undo the defcustom's, i.e. makunbound
them so that they are no longer in the name-space? should it? If so,
I think we should add such a feature, and only after that we will be
able to accept themes that define new user options.
> +(defun leuven-scale-font (control default-height)
> + "Function for splicing optional font heights into face descriptions.
> +CONTROL can be a number, nil, or t. When t, use DEFAULT-HEIGHT."
> + (cond
> + ((numberp control) (list :height control))
> + ((eq t control) (list :height default-height))
> + (t nil)))
Likewise with functions: should 'disable-theme' fmakunbound them?
next prev parent reply other threads:[~2020-04-25 8:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 5:31 bug#40759: 26.3; Update Leuven-theme in Emacs dev trunk Fab Rice
2020-04-22 6:10 ` Stefan Kangas
2020-04-22 19:58 ` Fab Rice
2020-04-23 18:47 ` Stefan Kangas
2020-04-24 10:57 ` Serghei via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-04-24 11:26 ` Eli Zaretskii
2020-04-24 12:09 ` Fab Rice
2020-04-25 8:49 ` Eli Zaretskii [this message]
2020-04-25 14:36 ` Dmitry Gutov
2020-05-04 12:35 ` Stefan Kangas
2020-05-04 14:58 ` Eli Zaretskii
2020-05-04 15:11 ` Stefan Kangas
2020-05-09 16:48 ` Stefan Kangas
2020-05-13 17:36 ` Fab Rice
2020-08-08 12:23 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k1247xw1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=40759@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=egrep@protonmail.ch \
--cc=monnier@iro.umontreal.ca \
--cc=posh18@pirilampo.be \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).