From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 40759@debbugs.gnu.org, posh18@pirilampo.be,
monnier@iro.umontreal.ca, egrep@protonmail.ch, dgutov@yandex.ru
Subject: bug#40759: 26.3; Update Leuven-theme in Emacs dev trunk
Date: Mon, 04 May 2020 17:58:24 +0300 [thread overview]
Message-ID: <831rnzoigf.fsf@gnu.org> (raw)
In-Reply-To: <87k11ryj1l.fsf@stefankangas.se> (message from Stefan Kangas on Mon, 04 May 2020 14:35:34 +0200)
> From: Stefan Kangas <stefan@marxist.se>
> Cc: Eli Zaretskii <eliz@gnu.org>, Fab Rice <posh18@pirilampo.be>,
> 40759@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>,
> egrep@protonmail.ch
> Date: Mon, 04 May 2020 14:35:34 +0200
>
> > I don't think it's a major problem, personally: these variables serve a purpose,
> > and they don't hurt anybody by remaining defined.
> >
> > Same with functions.
>
> I agree with that conclusion, too. I think it's fine that a theme
> does this. Maybe we could file a wishlist level request to add the
> makunbound functionality if we think it's worth working on.
>
> Is there anything left to discuss, or should I go ahead and push this?
>
> Also, I think we would need Eli to decide if this should go to
> emacs-27 or master. Thanks.
Frankly, I'm a bit afraid that such a significant deviation from the
practice of themes should be added to the release branch now.
Stefan's opinion notwithstanding, there can always be something we are
overlooking.
next prev parent reply other threads:[~2020-05-04 14:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 5:31 bug#40759: 26.3; Update Leuven-theme in Emacs dev trunk Fab Rice
2020-04-22 6:10 ` Stefan Kangas
2020-04-22 19:58 ` Fab Rice
2020-04-23 18:47 ` Stefan Kangas
2020-04-24 10:57 ` Serghei via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-04-24 11:26 ` Eli Zaretskii
2020-04-24 12:09 ` Fab Rice
2020-04-25 8:49 ` Eli Zaretskii
2020-04-25 14:36 ` Dmitry Gutov
2020-05-04 12:35 ` Stefan Kangas
2020-05-04 14:58 ` Eli Zaretskii [this message]
2020-05-04 15:11 ` Stefan Kangas
2020-05-09 16:48 ` Stefan Kangas
2020-05-13 17:36 ` Fab Rice
2020-08-08 12:23 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831rnzoigf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=40759@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=egrep@protonmail.ch \
--cc=monnier@iro.umontreal.ca \
--cc=posh18@pirilampo.be \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).