From: Stefan Kangas <stefan@marxist.se>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Fab Rice <posh18@pirilampo.be>,
40759@debbugs.gnu.org, egrep@protonmail.ch,
Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#40759: 26.3; Update Leuven-theme in Emacs dev trunk
Date: Mon, 04 May 2020 14:35:34 +0200 [thread overview]
Message-ID: <87k11ryj1l.fsf@stefankangas.se> (raw)
In-Reply-To: <139fcad3-888e-7768-b65b-0c0b721813a9@yandex.ru> (Dmitry Gutov's message of "Sat, 25 Apr 2020 17:36:31 +0300")
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 25.04.2020 11:49, Eli Zaretskii wrote:
>> We don't have defcustom's in any other theme I see in etc/themes/.
>> Does 'disable-theme' know how to undo the defcustom's, i.e. makunbound
>> them so that they are no longer in the name-space? should it?
>
> I don't think it's a major problem, personally: these variables serve a purpose,
> and they don't hurt anybody by remaining defined.
>
> Same with functions.
I agree with that conclusion, too. I think it's fine that a theme
does this. Maybe we could file a wishlist level request to add the
makunbound functionality if we think it's worth working on.
Is there anything left to discuss, or should I go ahead and push this?
Also, I think we would need Eli to decide if this should go to
emacs-27 or master. Thanks.
Best regards,
Stefan Kangas
next prev parent reply other threads:[~2020-05-04 12:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 5:31 bug#40759: 26.3; Update Leuven-theme in Emacs dev trunk Fab Rice
2020-04-22 6:10 ` Stefan Kangas
2020-04-22 19:58 ` Fab Rice
2020-04-23 18:47 ` Stefan Kangas
2020-04-24 10:57 ` Serghei via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-04-24 11:26 ` Eli Zaretskii
2020-04-24 12:09 ` Fab Rice
2020-04-25 8:49 ` Eli Zaretskii
2020-04-25 14:36 ` Dmitry Gutov
2020-05-04 12:35 ` Stefan Kangas [this message]
2020-05-04 14:58 ` Eli Zaretskii
2020-05-04 15:11 ` Stefan Kangas
2020-05-09 16:48 ` Stefan Kangas
2020-05-13 17:36 ` Fab Rice
2020-08-08 12:23 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k11ryj1l.fsf@stefankangas.se \
--to=stefan@marxist.se \
--cc=40759@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=egrep@protonmail.ch \
--cc=monnier@iro.umontreal.ca \
--cc=posh18@pirilampo.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).