unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Serghei via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Stefan Kangas <stefan@marxist.se>, Fab Rice <posh18@pirilampo.be>
Cc: 40759@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>, dgutov@yandex.ru
Subject: bug#40759: 26.3; Update Leuven-theme in Emacs dev trunk
Date: Fri, 24 Apr 2020 10:57:35 +0000	[thread overview]
Message-ID: <3c8915e3-dd47-4970-d89f-b142e09ebae5@protonmail.ch> (raw)
In-Reply-To: <50fbb1acfeba7f191e66176d2d5a7687@pirilampo.be>

Hello,

I asked for this merge Leuven Theme in 22 March [1] so I'm more than
interested in merging this before 27.1 release.

Eli, Stefan consider please to release Emacs 27.1 with fresh Leuven
version.

[1]: https://github.com/fniessen/emacs-leuven-theme/issues/69

> Fab Rice <posh18@pirilampo.be> writes:
> 
>> BTW, could this go to the "emacs-27" branch, please?
> 
> I think the emacs-27 branch is closed for anything that is not
> urgent.  Eli, what do you think?
> 
> A few more nitpicks:
> 
>> +(defcustom leuven-scale-org-agenda-structure t
>> +  "Scale Org agenda structure lines, like dates.
>> +This can be nil for unscaled, t for using the theme default, or a scaling number."
> 
> The last line should be reformatted to less than 80 characters, see:
> (info "(elisp) Documentation Tips")
> 
>> +  :group 'leuven)
> 
> You don't need ":group 'leuven" here since it defaults to the previous
> defgroup.
> 
> Best regards,
> Stefan Kangas
> 
> 
> 
> 






  parent reply	other threads:[~2020-04-24 10:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22  5:31 bug#40759: 26.3; Update Leuven-theme in Emacs dev trunk Fab Rice
2020-04-22  6:10 ` Stefan Kangas
2020-04-22 19:58 ` Fab Rice
2020-04-23 18:47   ` Stefan Kangas
2020-04-24 10:57 ` Serghei via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2020-04-24 11:26   ` Eli Zaretskii
2020-04-24 12:09     ` Fab Rice
2020-04-25  8:49       ` Eli Zaretskii
2020-04-25 14:36         ` Dmitry Gutov
2020-05-04 12:35           ` Stefan Kangas
2020-05-04 14:58             ` Eli Zaretskii
2020-05-04 15:11               ` Stefan Kangas
2020-05-09 16:48       ` Stefan Kangas
2020-05-13 17:36         ` Fab Rice
2020-08-08 12:23           ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c8915e3-dd47-4970-d89f-b142e09ebae5@protonmail.ch \
    --to=bug-gnu-emacs@gnu.org \
    --cc=40759@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=egrep@protonmail.ch \
    --cc=eliz@gnu.org \
    --cc=posh18@pirilampo.be \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).