From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#40759: 26.3; Update Leuven-theme in Emacs dev trunk Date: Sat, 25 Apr 2020 11:49:50 +0300 Message-ID: <83k1247xw1.fsf@gnu.org> References: <3c8915e3-dd47-4970-d89f-b142e09ebae5@protonmail.ch> <83zhb19laa.fsf@gnu.org> <0fc0b188e6cca472e8f06c570fee7a4d@pirilampo.be> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="67932"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 40759@debbugs.gnu.org, stefan@marxist.se, Stefan Monnier , egrep@protonmail.ch, dgutov@yandex.ru To: Fab Rice Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 25 10:51:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jSGWl-000HVf-MH for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Apr 2020 10:51:11 +0200 Original-Received: from localhost ([::1]:32770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSGWk-0004Cw-EI for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Apr 2020 04:51:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51630) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSGWd-0004Co-NQ for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 04:51:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSGWc-0001au-Dw for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 04:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46943) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSGWc-0001Yx-18 for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 04:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jSGWb-0005tF-VP for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 04:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Apr 2020 08:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40759 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 40759-submit@debbugs.gnu.org id=B40759.158780462222586 (code B ref 40759); Sat, 25 Apr 2020 08:51:01 +0000 Original-Received: (at 40759) by debbugs.gnu.org; 25 Apr 2020 08:50:22 +0000 Original-Received: from localhost ([127.0.0.1]:58489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSGVm-0005rw-PB for submit@debbugs.gnu.org; Sat, 25 Apr 2020 04:50:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSGVk-0005rc-K5 for 40759@debbugs.gnu.org; Sat, 25 Apr 2020 04:50:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50530) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSGVd-0005Ss-Rg; Sat, 25 Apr 2020 04:50:01 -0400 Original-Received: from [176.228.60.248] (port=4105 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jSGVd-0007Ns-0y; Sat, 25 Apr 2020 04:50:01 -0400 In-Reply-To: <0fc0b188e6cca472e8f06c570fee7a4d@pirilampo.be> (message from Fab Rice on Fri, 24 Apr 2020 14:09:56 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178972 Archived-At: > Date: Fri, 24 Apr 2020 14:09:56 +0200 > From: Fab Rice > Cc: Serghei , stefan@marxist.se, 40759@debbugs.gnu.org, > dgutov@yandex.ru > > +(defgroup leuven nil > + "Leuven theme options. > +The theme has to be reloaded after changing anything in this group." > + :group 'faces) > + > +(defcustom leuven-scale-outline-headlines t > + "Scale `outline' (and `org') level-1 headlines. > +This can be nil for unscaled, t for using the theme default, or a scaling > +number." > + :type '(choice > + (const :tag "Unscaled" nil) > + (const :tag "Default provided by theme" t) > + (number :tag "Set scaling")) > + :group 'leuven) > + > +(defcustom leuven-scale-org-agenda-structure t > + "Scale Org agenda structure lines, like dates. > +This can be nil for unscaled, t for using the theme default, or a scaling > +number." > + :type '(choice > + (const :tag "Unscaled" nil) > + (const :tag "Default provided by theme" t) > + (number :tag "Set scaling"))) We don't have defcustom's in any other theme I see in etc/themes/. Does 'disable-theme' know how to undo the defcustom's, i.e. makunbound them so that they are no longer in the name-space? should it? If so, I think we should add such a feature, and only after that we will be able to accept themes that define new user options. > +(defun leuven-scale-font (control default-height) > + "Function for splicing optional font heights into face descriptions. > +CONTROL can be a number, nil, or t. When t, use DEFAULT-HEIGHT." > + (cond > + ((numberp control) (list :height control)) > + ((eq t control) (list :height default-height)) > + (t nil))) Likewise with functions: should 'disable-theme' fmakunbound them?