unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Fab Rice <posh18@pirilampo.be>, Eli Zaretskii <eliz@gnu.org>
Cc: 40759@debbugs.gnu.org, Serghei <egrep@protonmail.ch>, dgutov@yandex.ru
Subject: bug#40759: 26.3; Update Leuven-theme in Emacs dev trunk
Date: Sat, 9 May 2020 12:48:53 -0400	[thread overview]
Message-ID: <CADwFkmnQEiiksPWTjqKmrud0E0j-ZAwi85_=2+yuqoFVTjgb5A@mail.gmail.com> (raw)
In-Reply-To: <0fc0b188e6cca472e8f06c570fee7a4d@pirilampo.be>

Fab Rice <posh18@pirilampo.be> writes:

> Here's an updated patch file, where I've fixed the issues pointed by Stefan.

Thank you.  I intended to push this today, but it seems like you haven't
merged the changes in Emacs into your version.

Could you please look into that and suggest how to best proceed?
Possibly you could just merge the changes and send a new patch.

I have marked some differences I could find below, but I think you would
need to review all this in full.

> -      (code-inline '(:foreground "#006400" :background "#FDFFF7"))
> +      (code-block '(:foreground "#000088" :background "#FFFFE0" :extend t))
> +      (code-inline '(:foreground "#006400" :background "#FDFFF7" :extend t))

The :extend attributes has been removed on purpose.
See emacs.git commit 58fb4c3e68a and etc/NEWS.27.

> +   ;; `(font-lock-doc-string-face ((,class (:foreground "#008000")))) ; XEmacs only, but is used for HTML exports from org2html (and not interactively)

This line was removed in emacs.git commit 16ec5f5f2ff.

>  ;; Local Variables:
> +;; no-byte-compile: t

This line was removed in emacs.git commit 530aa469a4d.

Sorry for not noticing any of this earlier.

Best regards,
Stefan Kangas





  parent reply	other threads:[~2020-05-09 16:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22  5:31 bug#40759: 26.3; Update Leuven-theme in Emacs dev trunk Fab Rice
2020-04-22  6:10 ` Stefan Kangas
2020-04-22 19:58 ` Fab Rice
2020-04-23 18:47   ` Stefan Kangas
2020-04-24 10:57 ` Serghei via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-04-24 11:26   ` Eli Zaretskii
2020-04-24 12:09     ` Fab Rice
2020-04-25  8:49       ` Eli Zaretskii
2020-04-25 14:36         ` Dmitry Gutov
2020-05-04 12:35           ` Stefan Kangas
2020-05-04 14:58             ` Eli Zaretskii
2020-05-04 15:11               ` Stefan Kangas
2020-05-09 16:48       ` Stefan Kangas [this message]
2020-05-13 17:36         ` Fab Rice
2020-08-08 12:23           ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmnQEiiksPWTjqKmrud0E0j-ZAwi85_=2+yuqoFVTjgb5A@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=40759@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=egrep@protonmail.ch \
    --cc=eliz@gnu.org \
    --cc=posh18@pirilampo.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).