From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53853: [PATCH] Don't use string-replace in flymake Date: Tue, 08 Feb 2022 15:54:47 +0200 Message-ID: <83fsotwjiw.fsf@gnu.org> References: <87r18e7fb7.fsf@gmail.com> <87zgn1ublj.fsf@gnus.org> <87mtj17oqg.fsf@gmail.com> <87ee4d7o3f.fsf@gmail.com> <875ypp7kmu.fsf@gmail.com> <83iltpwlwn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6556"; mail-complaints-to="usenet@ciao.gmane.io" Cc: leungbk@posteo.net, rpluim@gmail.com, larsi@gnus.org, 53853@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 08 16:54:28 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHSoz-0001SQ-Sb for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 16:54:26 +0100 Original-Received: from localhost ([::1]:51376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHSoy-0002G8-Fa for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 10:54:24 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42142) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHQz2-0006RX-I5 for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 08:56:40 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52014) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHQyQ-00011h-Ej for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 08:56:33 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHQyQ-000425-EI for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 08:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Feb 2022 13:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53853-submit@debbugs.gnu.org id=B53853.164432850715430 (code B ref 53853); Tue, 08 Feb 2022 13:56:02 +0000 Original-Received: (at 53853) by debbugs.gnu.org; 8 Feb 2022 13:55:07 +0000 Original-Received: from localhost ([127.0.0.1]:45911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHQxW-00040o-J9 for submit@debbugs.gnu.org; Tue, 08 Feb 2022 08:55:06 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHQxV-00040M-3o for 53853@debbugs.gnu.org; Tue, 08 Feb 2022 08:55:06 -0500 Original-Received: from [2001:470:142:3::e] (port=57824 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHQxP-0000d6-Mh; Tue, 08 Feb 2022 08:54:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=T4+QbOR14CH9mjX28fkMWB+HL5oAe45ggs9od/BFGys=; b=IQAhMtjSE66ODTC8LA2b O8QepLLtMTtHewy7lOd1m2HIp4MC8CvuuhsiN0g4tthNDo2vInV1IR1t/3dyDdFcz8n0gm87OGTZW lj7MoiunnIimli2s8fSa7Mp/8j073szl7/cXw6SVgU5kI6RCA4UoYLMvXiHm09MnOwL/TOs13E6oG OhceVEmXtnN7/Syy+UyqXSFd9qTpL6xtOp1+B/JvFUfMSYowtZZ0qCjl01d1oAqoDebW8NYFqUVoF pK6L3xywOSXc6nDVWas41SkMCYDZtqr35M4xF89myu9gJXiw28KOdH0tN/Y/hAJkDF8hbXDzoKtrW 3icafqqhfBjH7Q==; Original-Received: from [87.69.77.57] (port=1288 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHQxP-0002Fn-6P; Tue, 08 Feb 2022 08:54:59 -0500 In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Tue, 8 Feb 2022 13:18:44 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226381 Archived-At: > From: João Távora > Date: Tue, 8 Feb 2022 13:18:44 +0000 > Cc: Robert Pluim , Brian Leung , > Lars Ingebrigtsen , 53853@debbugs.gnu.org > > Alright. Seems that the discussion died down and there was never the fix and > reversion we (presumably?) agreed on. So I think if the incompatible string-something has > been now replaced by the replace-regexp-something that is compatible, we should now > put the 26.1 in the header again. If everyone agrees, I ask someone with a Emacs > master/emacs-28 checkout nearby to do that change and also bump flymake.el's version. We didn't really agree on the revert: I asked to see the change as a prerequisite for my agreement, and never saw any response. I see that Lars already installed such a change on emacs-28, and it is indeed quite simple. So I'm okay with going with that.