unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 60559@debbugs.gnu.org, stephen.berman@gmx.net, epg@pretzelnet.org
Subject: bug#60559: 29.0.60; "Cannot activate tree-sitter" spam
Date: Thu, 05 Jan 2023 09:58:56 +0200	[thread overview]
Message-ID: <83bkndxvi7.fsf@gnu.org> (raw)
In-Reply-To: <867cy1a0vj.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 05 Jan 2023 09:46:48 +0200)

> From: Juri Linkov <juri@linkov.net>
> Cc: Stephen Berman <stephen.berman@gmx.net>,  60559@debbugs.gnu.org,
>   epg@pretzelnet.org
> Date: Thu, 05 Jan 2023 09:46:48 +0200
> 
> >> >> Emacs 28 already has conf-toml-mode for TOML files, so shouldn't
> >> >> toml-ts-mode be handled like e.g. c-ts-mode instead of being added to
> >> >> auto-mode-alist? (The default value of that variable in Emacs 29 still
> >> >> contains an entry for conf-toml-mode, lower down than the entry for
> >> >> toml-ts-mode.)
> >> >
> >> > We could indeed do that for TOML files, but I believe the problem
> >> > raised here is more general.
> >>
> >> That may be, but the TOML case appears to be a regression, since
> >> visiting a TOML file in Emacs 28 displays various faces but visiting a
> >> TOML file in Emacs 29 without having the tree-sitter TOML grammar
> >> library installed displays only the default face.
> >
> > I've now made toml-ts-mode an optional one, leaving conf-toml-mode as
> > the default.
> 
> So now non-ts users are satisfied at the expense of ts users.

The cost for the latter is simple: require toml-ts-mode in the init
file.

> Why not to do the right thing:
> 
> (add-to-list 'auto-mode-alist `("\\.toml\\'" .
>   ,(if (treesit-ready-p 'toml) 'toml-ts-mode 'conf-toml-mode)))

Because I don't want to risk any breakage by last-minute changes.  Do
we want to release Emacs 29 soon, or do we want to keep developing it
for another year?





  reply	other threads:[~2023-01-05  7:58 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04 14:48 bug#60559: 29.0.60; "Cannot activate tree-sitter" spam Eric Gillespie
2023-01-04 18:36 ` Eli Zaretskii
2023-01-04 19:40   ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-04 20:03     ` Eli Zaretskii
2023-01-05  0:43       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-05  6:51       ` Eli Zaretskii
2023-01-05  7:06         ` Ihor Radchenko
2023-01-05  7:44           ` Eli Zaretskii
2023-01-05  8:00             ` Ihor Radchenko
2023-01-05  8:26               ` Eli Zaretskii
2023-01-05  8:40                 ` Ihor Radchenko
2023-01-05  8:42                   ` Ihor Radchenko
2023-01-05  8:54                     ` Eli Zaretskii
2023-01-05  8:52                   ` Eli Zaretskii
2023-01-05  9:05                     ` Ihor Radchenko
2023-01-05  7:57         ` Jostein Kjønigsen
2023-01-05  8:12           ` Eli Zaretskii
2023-01-05  8:32             ` Jostein Kjønigsen
2023-01-05  8:44         ` Gregory Heytings
2023-01-05  8:48           ` Gregory Heytings
2023-01-05  9:00             ` Eli Zaretskii
2023-01-05  8:56           ` Eli Zaretskii
2023-01-05 13:17         ` Dmitry Gutov
2023-01-05 14:02         ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-04 19:59   ` Stephen Berman
2023-01-04 20:10     ` Eli Zaretskii
2023-01-04 20:33       ` Stephen Berman
2023-01-05  6:41         ` Eli Zaretskii
2023-01-05  7:46           ` Juri Linkov
2023-01-05  7:58             ` Eli Zaretskii [this message]
2023-01-05 14:59               ` Eric Gillespie
2023-01-22 13:24                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bkndxvi7.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=60559@debbugs.gnu.org \
    --cc=epg@pretzelnet.org \
    --cc=juri@linkov.net \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).