unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Fu Yuan" <casouri@gmail.com>,
	"Stefan Monnier" <monnier@iro.umontreal.ca>,
	"Lars Ingebrigtsen" <larsi@gnus.org>,
	"Theodor Thornhill" <theo@thornhill.no>,
	"Jostein Kjønigsen" <jostein@secure.kjonigsen.net>
Cc: 60559@debbugs.gnu.org, epg@pretzelnet.org, mardani29@yahoo.es
Subject: bug#60559: 29.0.60; "Cannot activate tree-sitter" spam
Date: Thu, 05 Jan 2023 08:51:44 +0200	[thread overview]
Message-ID: <83h6x5xym7.fsf@gnu.org> (raw)
In-Reply-To: <83o7rexe2n.fsf@gnu.org> (message from Eli Zaretskii on Wed, 04 Jan 2023 22:03:12 +0200)

> Cc: 60559@debbugs.gnu.org, epg@pretzelnet.org
> Date: Wed, 04 Jan 2023 22:03:12 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > From: Daniel Martín <mardani29@yahoo.es>
> > Cc: Eric Gillespie <epg@pretzelnet.org>,  60559@debbugs.gnu.org
> > Date: Wed, 04 Jan 2023 20:40:24 +0100
> > 
> > Eli Zaretskii <eliz@gnu.org> writes:
> > 
> > >
> > > This is not a bug.  Emacs 29 comes with major modes for TOML files and
> > > for Dockerfiles, and those new major modes require that you build
> > > Emacs with the tree-sitter library (and install the corresponding
> > > parser grammar libraries).  If you don't want to do that, you can
> > > instead customize auto-mode-alist to make Emacs use Fundamental mode
> > > (or any other mode you like) for these two file types.
> > 
> > Isn't this another manifestation of what's being discussed in bug#60511?
> > I also think that treesit-ready-p should not emit a warning by default,
> > it's too noisy and confusing for people that don't know about
> > Tree-sitter and consequently use a build of Emacs 29 without Tree-sitter
> > enabled.
> 
> That is one use case.  The other, no less important one, is when the
> user thinks his/her Emacs is built with tree-sitter and has the
> relevant stuff installed, whereas the reality is different.  Silently
> doing nothing in that case is hardly TRT.
> 
> So if we want to solve this, we need to find a solution that fits both
> of these use cases.

So here's a suggestion for such a solution: we make all the
*-ts-mode's optional.  That is, we don't add any of them to
auto-mode-alist unless the file *-ts-mode.el is loaded, and we
document them all in NEWS and the user manual as optional.  users who
want them will have to manually activate them.  This way, the original
use case that started this bug report is automatically solved, and the
other use case, where the user intends to activate one of these modes,
is also served by showing the warning, which in that case is perfectly
justified: the user asked for something that we cannot do, so we warn
him/her.

This is a retreat of sorts, but I think it strikes a better balance
wrt user expectations, assuming not everyone will build with
tree-sitter.

Any comments or objections?  If not, I will do this in a couple of
days on the emacs-29 branch.





  parent reply	other threads:[~2023-01-05  6:51 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04 14:48 bug#60559: 29.0.60; "Cannot activate tree-sitter" spam Eric Gillespie
2023-01-04 18:36 ` Eli Zaretskii
2023-01-04 19:40   ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-04 20:03     ` Eli Zaretskii
2023-01-05  0:43       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-05  6:51       ` Eli Zaretskii [this message]
2023-01-05  7:06         ` Ihor Radchenko
2023-01-05  7:44           ` Eli Zaretskii
2023-01-05  8:00             ` Ihor Radchenko
2023-01-05  8:26               ` Eli Zaretskii
2023-01-05  8:40                 ` Ihor Radchenko
2023-01-05  8:42                   ` Ihor Radchenko
2023-01-05  8:54                     ` Eli Zaretskii
2023-01-05  8:52                   ` Eli Zaretskii
2023-01-05  9:05                     ` Ihor Radchenko
2023-01-05  7:57         ` Jostein Kjønigsen
2023-01-05  8:12           ` Eli Zaretskii
2023-01-05  8:32             ` Jostein Kjønigsen
2023-01-05  8:44         ` Gregory Heytings
2023-01-05  8:48           ` Gregory Heytings
2023-01-05  9:00             ` Eli Zaretskii
2023-01-05  8:56           ` Eli Zaretskii
2023-01-05 13:17         ` Dmitry Gutov
2023-01-05 14:02         ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-04 19:59   ` Stephen Berman
2023-01-04 20:10     ` Eli Zaretskii
2023-01-04 20:33       ` Stephen Berman
2023-01-05  6:41         ` Eli Zaretskii
2023-01-05  7:46           ` Juri Linkov
2023-01-05  7:58             ` Eli Zaretskii
2023-01-05 14:59               ` Eric Gillespie
2023-01-22 13:24                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h6x5xym7.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=60559@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=epg@pretzelnet.org \
    --cc=jostein@secure.kjonigsen.net \
    --cc=larsi@gnus.org \
    --cc=mardani29@yahoo.es \
    --cc=monnier@iro.umontreal.ca \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).