From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60559: 29.0.60; "Cannot activate tree-sitter" spam Date: Thu, 05 Jan 2023 09:58:56 +0200 Message-ID: <83bkndxvi7.fsf@gnu.org> References: <84973.1672843723@hassadar.pretzelnet.org> <83wn62xi3k.fsf@gnu.org> <877cy2841j.fsf@gmx.net> <83mt6yxdq0.fsf@gnu.org> <87358q82fx.fsf@gmx.net> <83ilhlxz2g.fsf@gnu.org> <867cy1a0vj.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23606"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60559@debbugs.gnu.org, stephen.berman@gmx.net, epg@pretzelnet.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 05 08:59:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDL9j-0005pU-Ut for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Jan 2023 08:59:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDL9V-0005Pd-LV; Thu, 05 Jan 2023 02:59:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDL9S-0005PP-Te for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 02:59:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDL9S-0002lm-IV for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 02:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pDL9S-0007yb-EX for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 02:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Jan 2023 07:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix notabug Original-Received: via spool by 60559-submit@debbugs.gnu.org id=B60559.167290552930636 (code B ref 60559); Thu, 05 Jan 2023 07:59:02 +0000 Original-Received: (at 60559) by debbugs.gnu.org; 5 Jan 2023 07:58:49 +0000 Original-Received: from localhost ([127.0.0.1]:50146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDL9F-0007y3-GN for submit@debbugs.gnu.org; Thu, 05 Jan 2023 02:58:49 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDL9E-0007xr-4o for 60559@debbugs.gnu.org; Thu, 05 Jan 2023 02:58:48 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDL98-0002jr-Jj; Thu, 05 Jan 2023 02:58:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=e8KQa2sguwPTxitGpl7gUlhYicm2poDBV7K/HmHBwls=; b=oEjVsqJXLKba Hu/6xX8T6ANfVwle0NKnvYBBcu3aALmxAZBeqDVT6tABHQzSxA1mrNO+pVn+iE5rf49qmLuwFBkFC DEnVGPQI/2MjkeiLnuMNrrsxbgfXhP68R2OS1sVJcSNvuMoMLxrWJBsiXr83zUN8eeZsWLXKu52at V6yWvXbnSylMEg8bQaGg7VufSGjWsd7CisMBJf11Ju7r1ALkVpp/9a/AT2Ma8owX1Vpjh/AFq/viQ U6WPeoITCadU9me4XyMLDdqMwAW+Cw5qQHIs5ScQFdVZ14xoFtsk3fBVHR8NtHmkrLho6zm+/LSuD 5WtYiU7hWiQ3ab/ihT3xCg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDL98-0002wq-1j; Thu, 05 Jan 2023 02:58:42 -0500 In-Reply-To: <867cy1a0vj.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 05 Jan 2023 09:46:48 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252565 Archived-At: > From: Juri Linkov > Cc: Stephen Berman , 60559@debbugs.gnu.org, > epg@pretzelnet.org > Date: Thu, 05 Jan 2023 09:46:48 +0200 > > >> >> Emacs 28 already has conf-toml-mode for TOML files, so shouldn't > >> >> toml-ts-mode be handled like e.g. c-ts-mode instead of being added to > >> >> auto-mode-alist? (The default value of that variable in Emacs 29 still > >> >> contains an entry for conf-toml-mode, lower down than the entry for > >> >> toml-ts-mode.) > >> > > >> > We could indeed do that for TOML files, but I believe the problem > >> > raised here is more general. > >> > >> That may be, but the TOML case appears to be a regression, since > >> visiting a TOML file in Emacs 28 displays various faces but visiting a > >> TOML file in Emacs 29 without having the tree-sitter TOML grammar > >> library installed displays only the default face. > > > > I've now made toml-ts-mode an optional one, leaving conf-toml-mode as > > the default. > > So now non-ts users are satisfied at the expense of ts users. The cost for the latter is simple: require toml-ts-mode in the init file. > Why not to do the right thing: > > (add-to-list 'auto-mode-alist `("\\.toml\\'" . > ,(if (treesit-ready-p 'toml) 'toml-ts-mode 'conf-toml-mode))) Because I don't want to risk any breakage by last-minute changes. Do we want to release Emacs 29 soon, or do we want to keep developing it for another year?