From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Mendler <mail@daniel-mendler.de>
Cc: 47712@debbugs.gnu.org
Subject: bug#47712: 27.1; Provide `string-display-width` function, which takes properties into account, `substring-width`
Date: Mon, 12 Apr 2021 20:01:53 +0300 [thread overview]
Message-ID: <835z0r308u.fsf@gnu.org> (raw)
In-Reply-To: <23ea6bd4-8d2d-51cc-b1f7-58eb7316d5d3@daniel-mendler.de> (message from Daniel Mendler on Mon, 12 Apr 2021 16:38:08 +0200)
> Cc: 47712@debbugs.gnu.org
> From: Daniel Mendler <mail@daniel-mendler.de>
> Date: Mon, 12 Apr 2021 16:38:08 +0200
>
> On 4/12/21 4:32 PM, Eli Zaretskii wrote:
> > My benchmarking indicates that reusing the buffer makes
> > string-pixel-width only 10 times slower than string-width, i.e. 50
> > about microseconds per call.
>
> Can you please paste the exact code you used? As I wrote in my previous
> mail, I tried without buffer switching, but it was still 50 times
> slower.
(defun string-pixel-width (string)
(with-current-buffer (get-buffer-create "foo")
(erase-buffer)
(insert string)
(window-text-pixel-size nil (point-min) (point-max))))
(defvar test-string
(concat "some string with "
(propertize "invisible substring" 'invisible t)
" and "
(propertize "a displayed substring"
'display "an overwritten substring")))
(benchmark-run 100000 (string-pixel-width test-string))
(benchmark-run 100000 (string-width test-string))
> 10 times slower is still not good, but given that number I may
> stop arguing, since the factor will be even less in real code.
You can still use your code in org-table, if it does the job, I just
don't think we should have a semi-working API in core.
(There's indeed something strange with the results, I think the
with-current-buffer thing is not enough (because if I manually switch
to buffer "foo" and run the function, it returns correct results). I
will take a closer look when I have time, unless martin beats me to
it.)
next prev parent reply other threads:[~2021-04-12 17:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-11 21:16 bug#47712: 27.1; Provide `string-display-width` function, which takes properties into account, `substring-width` Daniel Mendler
2021-04-12 2:26 ` Eli Zaretskii
2021-04-12 8:45 ` Daniel Mendler
2021-04-12 8:53 ` Lars Ingebrigtsen
2021-04-12 9:08 ` Daniel Mendler
2021-04-13 8:01 ` Lars Ingebrigtsen
2021-04-13 12:00 ` Eli Zaretskii
2021-04-13 12:25 ` Daniel Mendler
2021-04-14 8:50 ` Eli Zaretskii
2021-04-14 10:49 ` Daniel Mendler
2021-04-14 11:38 ` Eli Zaretskii
2021-04-12 12:21 ` Eli Zaretskii
2021-04-12 12:50 ` Daniel Mendler
2021-04-12 13:21 ` Eli Zaretskii
2021-04-12 13:32 ` Daniel Mendler
2021-04-12 13:40 ` Eli Zaretskii
2021-04-12 14:05 ` Daniel Mendler
2021-04-12 14:15 ` Eli Zaretskii
2021-04-12 14:32 ` Eli Zaretskii
2021-04-12 14:38 ` Daniel Mendler
2021-04-12 17:01 ` Eli Zaretskii [this message]
2021-04-12 17:18 ` Daniel Mendler
2021-04-13 7:06 ` martin rudalics
2021-04-13 12:23 ` Eli Zaretskii
2021-04-12 14:36 ` Daniel Mendler
2021-04-12 17:09 ` Eli Zaretskii
2021-04-12 17:13 ` Daniel Mendler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835z0r308u.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=47712@debbugs.gnu.org \
--cc=mail@daniel-mendler.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).