From: Daniel Mendler <mail@daniel-mendler.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 47712@debbugs.gnu.org
Subject: bug#47712: 27.1; Provide `string-display-width` function, which takes properties into account, `substring-width`
Date: Mon, 12 Apr 2021 16:36:05 +0200 [thread overview]
Message-ID: <a9753385-032b-8ae5-6654-47a69a015438@daniel-mendler.de> (raw)
In-Reply-To: <83blaj37yi.fsf@gnu.org>
On 4/12/21 4:15 PM, Eli Zaretskii wrote:
> If these properties are ignored, they will also be ignored on display.
No, something is wrong. 'display should not be ignored.
>> But for we can still look at the micro benchmark. The `string-width`
>> function is 200 times faster than the `string-pixel-width` function.
>
> And if you reuse the same temp buffer?
Sorry, I should have said that I tried reusing the same buffer. But it
was not faster when I tried that. The buffer switching has a significant
overhead. In order to get a fair benchmark one should measure the following:
;; 1.4s
(with-temp-buffer
(bench
(dotimes (_ 10000)
(erase-buffer)
(insert test-string)
(car (window-text-pixel-size nil (point-min) (point-max))))))
Given that benchmark the `window-text-pixel-size` function is still over
50 times slower.
> With 0.5 millisecond per call, I don't see a problem. And I expect
> that to go down if the buffer is reused.
No, 0.5ms per call is not acceptable. When processing 2000 strings takes
a second, it is not viable to use this to preprocess and format many
strings. It may be okay for computing a handful strings which are being
displayed right away.
Given the benchmark I think it makes sense to continue to use
`string-width` for certain use cases which can live with the limitations
of only working correctly in text mode.
But I understand that you don't want to add a half-broken
`string-display-width` API on top of the already half-broken
`string-width` API. One may still discuss the implementation of a
`substring-width` API which generalizes `string-width`.
(defun string-width (s)
(substring-width s 0 (length s)))
(defun substring-width (s a b)
(string-width (substring s a b)))
next prev parent reply other threads:[~2021-04-12 14:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-11 21:16 bug#47712: 27.1; Provide `string-display-width` function, which takes properties into account, `substring-width` Daniel Mendler
2021-04-12 2:26 ` Eli Zaretskii
2021-04-12 8:45 ` Daniel Mendler
2021-04-12 8:53 ` Lars Ingebrigtsen
2021-04-12 9:08 ` Daniel Mendler
2021-04-13 8:01 ` Lars Ingebrigtsen
2021-04-13 12:00 ` Eli Zaretskii
2021-04-13 12:25 ` Daniel Mendler
2021-04-14 8:50 ` Eli Zaretskii
2021-04-14 10:49 ` Daniel Mendler
2021-04-14 11:38 ` Eli Zaretskii
2021-04-12 12:21 ` Eli Zaretskii
2021-04-12 12:50 ` Daniel Mendler
2021-04-12 13:21 ` Eli Zaretskii
2021-04-12 13:32 ` Daniel Mendler
2021-04-12 13:40 ` Eli Zaretskii
2021-04-12 14:05 ` Daniel Mendler
2021-04-12 14:15 ` Eli Zaretskii
2021-04-12 14:32 ` Eli Zaretskii
2021-04-12 14:38 ` Daniel Mendler
2021-04-12 17:01 ` Eli Zaretskii
2021-04-12 17:18 ` Daniel Mendler
2021-04-13 7:06 ` martin rudalics
2021-04-13 12:23 ` Eli Zaretskii
2021-04-12 14:36 ` Daniel Mendler [this message]
2021-04-12 17:09 ` Eli Zaretskii
2021-04-12 17:13 ` Daniel Mendler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9753385-032b-8ae5-6654-47a69a015438@daniel-mendler.de \
--to=mail@daniel-mendler.de \
--cc=47712@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).