From: Daniel Mendler <mail@daniel-mendler.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 47712@debbugs.gnu.org
Subject: bug#47712: 27.1; Provide `string-display-width` function, which takes properties into account, `substring-width`
Date: Mon, 12 Apr 2021 16:05:41 +0200 [thread overview]
Message-ID: <a30000c3-925f-6e29-d6a3-9d8a0c0d0ec7@daniel-mendler.de> (raw)
In-Reply-To: <83czuz39jw.fsf@gnu.org>
I gave it a quick test. See the function `string-pixel-width` below. It
seems that it does not take 'invisible and 'display into account. I
probably have to change something to ensure that the properties are not
ignored.
But for we can still look at the micro benchmark. The `string-width`
function is 200 times faster than the `string-pixel-width` function.
This is a huge difference, but as usual with microbenchmarks, one can
argue that the difference will be less pronounced in a realistic
computation.
I am still not happy with replacing `string-width` with something so
much slower. However `window-text-pixel-size` also gives a different,
much more precise result since it takes everything into account (or at
least it should, invisible and display properties included). In the uses
cases I mentioned one relies on monospace faces and formatting.
(defmacro bench (&rest body)
(let ((start (make-symbol "t")))
`(let (,start)
(setq ,start (current-time))
,@body
(float-time (time-since ,start)))))
(defun string-pixel-width (string)
(with-temp-buffer
(insert string)
(car (window-text-pixel-size nil (point-min) (point-max)))))
;; returns 56 for all of the following strings, which is wrong
(string-pixel-width "1234")
(string-pixel-width (propertize "1234" 'invisible t))
(string-pixel-width (propertize "1234" 'display " "))
(defvar test-string
(concat "some string with "
(propertize "invisible substring" 'invisible t)
" and "
(propertize "a displayed substring"
'display "an overwritten substring")))
;; 5s
(bench
(dotimes (_ 10000)
(string-pixel-width test-string)))
;; 2.5s
(bench
(dotimes (_ 1000000)
(string-width test-string)))
;; 3.5s
(bench
(dotimes (_ 1000000)
(consult--display-width test-string)))
next prev parent reply other threads:[~2021-04-12 14:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-11 21:16 bug#47712: 27.1; Provide `string-display-width` function, which takes properties into account, `substring-width` Daniel Mendler
2021-04-12 2:26 ` Eli Zaretskii
2021-04-12 8:45 ` Daniel Mendler
2021-04-12 8:53 ` Lars Ingebrigtsen
2021-04-12 9:08 ` Daniel Mendler
2021-04-13 8:01 ` Lars Ingebrigtsen
2021-04-13 12:00 ` Eli Zaretskii
2021-04-13 12:25 ` Daniel Mendler
2021-04-14 8:50 ` Eli Zaretskii
2021-04-14 10:49 ` Daniel Mendler
2021-04-14 11:38 ` Eli Zaretskii
2021-04-12 12:21 ` Eli Zaretskii
2021-04-12 12:50 ` Daniel Mendler
2021-04-12 13:21 ` Eli Zaretskii
2021-04-12 13:32 ` Daniel Mendler
2021-04-12 13:40 ` Eli Zaretskii
2021-04-12 14:05 ` Daniel Mendler [this message]
2021-04-12 14:15 ` Eli Zaretskii
2021-04-12 14:32 ` Eli Zaretskii
2021-04-12 14:38 ` Daniel Mendler
2021-04-12 17:01 ` Eli Zaretskii
2021-04-12 17:18 ` Daniel Mendler
2021-04-13 7:06 ` martin rudalics
2021-04-13 12:23 ` Eli Zaretskii
2021-04-12 14:36 ` Daniel Mendler
2021-04-12 17:09 ` Eli Zaretskii
2021-04-12 17:13 ` Daniel Mendler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a30000c3-925f-6e29-d6a3-9d8a0c0d0ec7@daniel-mendler.de \
--to=mail@daniel-mendler.de \
--cc=47712@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).