unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Mendler <mail@daniel-mendler.de>
Cc: larsi@gnus.org, 47712@debbugs.gnu.org
Subject: bug#47712: 27.1; Provide `string-display-width` function, which takes properties into account, `substring-width`
Date: Wed, 14 Apr 2021 11:50:36 +0300	[thread overview]
Message-ID: <831rbd1c83.fsf@gnu.org> (raw)
In-Reply-To: <cd462c82-e278-1313-92cf-ca9471d94f71@daniel-mendler.de> (message from Daniel Mendler on Tue, 13 Apr 2021 14:25:18 +0200)

> Cc: 47712@debbugs.gnu.org
> From: Daniel Mendler <mail@daniel-mendler.de>
> Date: Tue, 13 Apr 2021 14:25:18 +0200
> 
> Yes, `string-width` is broken for face-dependent purposes. However there 
> are still these handful of use cases which will probably not go away 
> (org-mode table, formatting monospaced text, ...). In those existing 
> cases the `string-width` function is often used in combination with 
> `substring`, i.e., `(string-width (substring str beg end)`.
> 
> Therefore I would be happy with the following resolution:
> 
> 1. Add two arguments begin and end to `string-width` to improve the 
> current uses of `string-width`.
> 
> 2. Document the caveats of `string-width` in the docstring (works only 
> reliable in text mode for multi-width chars) and maybe mention 
> `window-text-pixel-size` or the `string-pixel-width` function by Martin.

Your wishes have been granted, see the latest master branch.

Is there anything else to do with this bug report, or can we close it?





  reply	other threads:[~2021-04-14  8:50 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-11 21:16 bug#47712: 27.1; Provide `string-display-width` function, which takes properties into account, `substring-width` Daniel Mendler
2021-04-12  2:26 ` Eli Zaretskii
2021-04-12  8:45   ` Daniel Mendler
2021-04-12  8:53     ` Lars Ingebrigtsen
2021-04-12  9:08       ` Daniel Mendler
2021-04-13  8:01         ` Lars Ingebrigtsen
2021-04-13 12:00           ` Eli Zaretskii
2021-04-13 12:25             ` Daniel Mendler
2021-04-14  8:50               ` Eli Zaretskii [this message]
2021-04-14 10:49                 ` Daniel Mendler
2021-04-14 11:38                   ` Eli Zaretskii
2021-04-12 12:21     ` Eli Zaretskii
2021-04-12 12:50       ` Daniel Mendler
2021-04-12 13:21         ` Eli Zaretskii
2021-04-12 13:32           ` Daniel Mendler
2021-04-12 13:40             ` Eli Zaretskii
2021-04-12 14:05               ` Daniel Mendler
2021-04-12 14:15                 ` Eli Zaretskii
2021-04-12 14:32                   ` Eli Zaretskii
2021-04-12 14:38                     ` Daniel Mendler
2021-04-12 17:01                       ` Eli Zaretskii
2021-04-12 17:18                         ` Daniel Mendler
2021-04-13  7:06                         ` martin rudalics
2021-04-13 12:23                           ` Eli Zaretskii
2021-04-12 14:36                   ` Daniel Mendler
2021-04-12 17:09                     ` Eli Zaretskii
2021-04-12 17:13                       ` Daniel Mendler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831rbd1c83.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=47712@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=mail@daniel-mendler.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).