From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47712: 27.1; Provide `string-display-width` function, which takes properties into account, `substring-width` Date: Mon, 12 Apr 2021 20:01:53 +0300 Message-ID: <835z0r308u.fsf@gnu.org> References: <642c8a37-31c7-2723-12af-06cd7f120c2f@daniel-mendler.de> <83r1jg2q72.fsf@gnu.org> <83lf9n3d7x.fsf@gnu.org> <1c8f7066-3da2-d960-11e7-a42f567432bd@daniel-mendler.de> <83im4r3agk.fsf@gnu.org> <83czuz39jw.fsf@gnu.org> <83blaj37yi.fsf@gnu.org> <83a6q33753.fsf@gnu.org> <23ea6bd4-8d2d-51cc-b1f7-58eb7316d5d3@daniel-mendler.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32408"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47712@debbugs.gnu.org To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 12 19:03:42 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVzyP-0008JX-HB for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Apr 2021 19:03:41 +0200 Original-Received: from localhost ([::1]:43938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVzyO-0002K5-IB for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Apr 2021 13:03:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVzxn-0002Jg-7r for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2021 13:03:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVzxm-0006Gq-Sj for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2021 13:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lVzxm-0004gI-PI for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2021 13:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Apr 2021 17:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47712 X-GNU-PR-Package: emacs Original-Received: via spool by 47712-submit@debbugs.gnu.org id=B47712.161824694517942 (code B ref 47712); Mon, 12 Apr 2021 17:03:02 +0000 Original-Received: (at 47712) by debbugs.gnu.org; 12 Apr 2021 17:02:25 +0000 Original-Received: from localhost ([127.0.0.1]:57933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVzxB-0004fJ-9Y for submit@debbugs.gnu.org; Mon, 12 Apr 2021 13:02:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVzx9-0004ev-HS for 47712@debbugs.gnu.org; Mon, 12 Apr 2021 13:02:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58671) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVzwy-0005w6-TK; Mon, 12 Apr 2021 13:02:17 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4549 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lVzwv-0007JM-Rh; Mon, 12 Apr 2021 13:02:10 -0400 In-Reply-To: <23ea6bd4-8d2d-51cc-b1f7-58eb7316d5d3@daniel-mendler.de> (message from Daniel Mendler on Mon, 12 Apr 2021 16:38:08 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203924 Archived-At: > Cc: 47712@debbugs.gnu.org > From: Daniel Mendler > Date: Mon, 12 Apr 2021 16:38:08 +0200 > > On 4/12/21 4:32 PM, Eli Zaretskii wrote: > > My benchmarking indicates that reusing the buffer makes > > string-pixel-width only 10 times slower than string-width, i.e. 50 > > about microseconds per call. > > Can you please paste the exact code you used? As I wrote in my previous > mail, I tried without buffer switching, but it was still 50 times > slower. (defun string-pixel-width (string) (with-current-buffer (get-buffer-create "foo") (erase-buffer) (insert string) (window-text-pixel-size nil (point-min) (point-max)))) (defvar test-string (concat "some string with " (propertize "invisible substring" 'invisible t) " and " (propertize "a displayed substring" 'display "an overwritten substring"))) (benchmark-run 100000 (string-pixel-width test-string)) (benchmark-run 100000 (string-width test-string)) > 10 times slower is still not good, but given that number I may > stop arguing, since the factor will be even less in real code. You can still use your code in org-table, if it does the job, I just don't think we should have a semi-working API in core. (There's indeed something strange with the results, I think the with-current-buffer thing is not enough (because if I manually switch to buffer "foo" and run the function, it returns correct results). I will take a closer look when I have time, unless martin beats me to it.)