From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47712: 27.1; Provide `string-display-width` function, which takes properties into account, `substring-width` Date: Wed, 14 Apr 2021 11:50:36 +0300 Message-ID: <831rbd1c83.fsf@gnu.org> References: <642c8a37-31c7-2723-12af-06cd7f120c2f@daniel-mendler.de> <83r1jg2q72.fsf@gnu.org> <87h7kbzxwh.fsf@gnus.org> <7c96d858-7947-0cca-60fc-1f6d027bb909@daniel-mendler.de> <87k0p6sjef.fsf@gnus.org> <83wnt61jj0.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5577"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 47712@debbugs.gnu.org To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 14 10:52:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lWbFy-0001Lg-Do for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Apr 2021 10:52:18 +0200 Original-Received: from localhost ([::1]:48290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWbFx-0004hI-GW for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Apr 2021 04:52:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWbFi-0004fp-1G for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 04:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50045) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lWbFh-0007Hs-QT for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 04:52:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lWbFh-0006XE-Pa for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 04:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Apr 2021 08:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47712 X-GNU-PR-Package: emacs Original-Received: via spool by 47712-submit@debbugs.gnu.org id=B47712.161839026125017 (code B ref 47712); Wed, 14 Apr 2021 08:52:01 +0000 Original-Received: (at 47712) by debbugs.gnu.org; 14 Apr 2021 08:51:01 +0000 Original-Received: from localhost ([127.0.0.1]:33350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWbEj-0006VM-4r for submit@debbugs.gnu.org; Wed, 14 Apr 2021 04:51:01 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWbEh-0006VA-UA for 47712@debbugs.gnu.org; Wed, 14 Apr 2021 04:51:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38963) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWbEb-0006c0-ND; Wed, 14 Apr 2021 04:50:53 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4513 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lWbEW-0001IT-58; Wed, 14 Apr 2021 04:50:52 -0400 In-Reply-To: (message from Daniel Mendler on Tue, 13 Apr 2021 14:25:18 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204001 Archived-At: > Cc: 47712@debbugs.gnu.org > From: Daniel Mendler > Date: Tue, 13 Apr 2021 14:25:18 +0200 > > Yes, `string-width` is broken for face-dependent purposes. However there > are still these handful of use cases which will probably not go away > (org-mode table, formatting monospaced text, ...). In those existing > cases the `string-width` function is often used in combination with > `substring`, i.e., `(string-width (substring str beg end)`. > > Therefore I would be happy with the following resolution: > > 1. Add two arguments begin and end to `string-width` to improve the > current uses of `string-width`. > > 2. Document the caveats of `string-width` in the docstring (works only > reliable in text mode for multi-width chars) and maybe mention > `window-text-pixel-size` or the `string-pixel-width` function by Martin. Your wishes have been granted, see the latest master branch. Is there anything else to do with this bug report, or can we close it?