From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#64799: [PATCH] Add 'project-prompt-key' face Date: Thu, 24 Aug 2023 08:59:13 -0300 Message-ID: <43bb13ec-98d3-7b9b-4129-72030b08a5ab@gmail.com> References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> <87ttsq2gil.fsf@gmail.com> <87pm3d3kzl.fsf@gmail.com> <355df502-0c6d-a070-119d-19daae961588@gutov.dev> <87lee13h60.fsf@gmail.com> <87h6op3gpd.fsf@gmail.com> <43a50ddb-8702-ba2e-7bac-6fba75176882@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34478"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Philip Kaludercic , 64799@debbugs.gnu.org, Protesilaos Stavrou , Visuwesh To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 24 14:00:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qZ90Y-0008iu-IF for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Aug 2023 14:00:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZ90J-00009E-Pa; Thu, 24 Aug 2023 07:59:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZ90I-000095-VK for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 07:59:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qZ90I-0002bR-N9 for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 07:59:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qZ90M-0003O6-Ie for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 08:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Aug 2023 12:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64799-submit@debbugs.gnu.org id=B64799.169287837012950 (code B ref 64799); Thu, 24 Aug 2023 12:00:02 +0000 Original-Received: (at 64799) by debbugs.gnu.org; 24 Aug 2023 11:59:30 +0000 Original-Received: from localhost ([127.0.0.1]:36287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ8zq-0003Mo-ID for submit@debbugs.gnu.org; Thu, 24 Aug 2023 07:59:30 -0400 Original-Received: from mail-ot1-x334.google.com ([2607:f8b0:4864:20::334]:51594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ8zo-0003Mb-L5 for 64799@debbugs.gnu.org; Thu, 24 Aug 2023 07:59:30 -0400 Original-Received: by mail-ot1-x334.google.com with SMTP id 46e09a7af769-6bd6a34474cso4738561a34.3 for <64799@debbugs.gnu.org>; Thu, 24 Aug 2023 04:59:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692878359; x=1693483159; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0p69uUxxjwtNGfpF+ruGakK9Xy6XejhWWPIwIOn4MpE=; b=ZtPOk476PZAdO1Aa+dNrVTcNFbNG0jUJh9jZR/w57p8Nt1Bue4taGmKB4XfPsNh5Te eBgsIA1/A5vaY+Q8dc60BH6Gob5/h/Axxrl50evofMaNj1v20mVVxs1QszlHm+t+sBIj qitr+w/ADKijbbsTg3hMoOA9/4BeywExsiyq7MNLoHMVrJMB5gK38Z7s9p96BAqHtmSk Fjm4RQw2ELxTCatGcbZsTlQ3vgeN2AKXPOR2N/yvIZ1uwgrA10ZCG0LmuIR7HSYnEprD YqnEmEUpCBTgX+xGHqQA8jNrZOF+9IUrt/rAvgZJSe+WH1RxgK+l16/3ksUq1RyExy6G blvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692878359; x=1693483159; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0p69uUxxjwtNGfpF+ruGakK9Xy6XejhWWPIwIOn4MpE=; b=UABl3MM3sLZpPdkZ2NHtIn6T4qjaQuriIEAp+1oOVAStLh7Xmk+UtFy5+pkaT2Sq5W fwRAyPr5uSq2ncP3e5W75f0Ky8U3KsBPdMAga8l9GkXhk3Dq3Q6zSLmefoqe66jQtmPt E86B9V651y/p5JrMQCvhv0kFX6Rz876ypRcy1OrqCxvhOO7xqDrqNgSLhQJ1ovXAQsHI dgBmVe3yQmkWypeqXNNnBirH0EHOBE/D4vB8fDfnQ73TLx4MlfLc4oNh/t2wRmMXUz2T jSNNeRZUlDvDyz5InIVdholoM0yMwSiaw7/9JCPifnH6D37DbafpXl3kweP4H63+RYL4 RRZQ== X-Gm-Message-State: AOJu0YzbJHIQKI8X76CZWpf6Y8WM3DrAZRLOoZSJcB1KKiJidOgQThNf VjSGeDNcBzEGYWw9jpkRzL0= X-Google-Smtp-Source: AGHT+IH2XT9eMoF7+52A5duJX//kOGw78+V6+VkLzuuN4RcvXoGDQUQ/GNfkvg8+jivFiEeVYtW1BQ== X-Received: by 2002:a05:6870:9a1f:b0:1c8:c7d1:b4f9 with SMTP id fo31-20020a0568709a1f00b001c8c7d1b4f9mr18342634oab.29.1692878358798; Thu, 24 Aug 2023 04:59:18 -0700 (PDT) Original-Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id v2-20020a056870e28200b001b3d67934e9sm8027164oad.26.2023.08.24.04.59.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Aug 2023 04:59:16 -0700 (PDT) Content-Language: en-US In-Reply-To: <43a50ddb-8702-ba2e-7bac-6fba75176882@gutov.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268326 Archived-At: Dmitry Gutov writes: > On 23/08/2023 18:45, Visuwesh wrote: >> [புதன் ஆகஸ்ட் 23, 2023] Dmitry Gutov wrote: >> >>> On 23/08/2023 18:35, Visuwesh wrote: >>>>> Anyway, if you want the option, can you suggest how it will be called? >>>>> Will it be just boolean? >>>> A boolean option will be fine. The facep condition can then be changed >>>> to (and NEW-OPTION (facep 'help-key-binding)). >>> Any ideas for the name? >> project-prompt-key-use-bold-face? I am unfortunately terrible at naming >> things. > > Ok, I've added project-key-prompt-style. > > Please test whenever convenient. Hi Dmitry, > (defcustom project-key-prompt-style (if (facep 'help-key-binding) > t > 'brackets) > "Which presentation to use when asking to choose a command by key. > > When `brackets', use text brackets and `bold' for the character. > Otherwise, use the face `help-key-binding' in the prompt." > :type 'boolean > :group 'project > :version "30.1") Shouldn't the :type be a choice between t and brackets?