From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#64799: [PATCH] Add 'project-prompt-key' face Date: Sat, 12 Aug 2023 03:35:34 +0300 Message-ID: <0e3bcc19-ded4-7612-5b7d-d5147c8842d9@gutov.dev> References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> <875y64wvyz.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15907"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: 64799-done@debbugs.gnu.org To: Protesilaos Stavrou , Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 12 02:36:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUccF-0003tG-9d for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Aug 2023 02:36:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUcbu-0006Qo-1X; Fri, 11 Aug 2023 20:36:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUcbq-0006QT-IS for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2023 20:36:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUcbq-00007V-A1 for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2023 20:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qUcbq-0006Vz-6B for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2023 20:36:02 -0400 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Aug 2023 00:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 64799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 64799@debbugs.gnu.org, dmitry@gutov.dev, info@protesilaos.com Original-Received: via spool by 64799-done@debbugs.gnu.org id=D64799.169180055125022 (code D ref 64799); Sat, 12 Aug 2023 00:36:01 +0000 Original-Received: (at 64799-done) by debbugs.gnu.org; 12 Aug 2023 00:35:51 +0000 Original-Received: from localhost ([127.0.0.1]:48269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUcbf-0006VU-4T for submit@debbugs.gnu.org; Fri, 11 Aug 2023 20:35:51 -0400 Original-Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:44337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUcbZ-0006VB-TU for 64799-done@debbugs.gnu.org; Fri, 11 Aug 2023 20:35:50 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id D1F123200925; Fri, 11 Aug 2023 20:35:37 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 11 Aug 2023 20:35:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1691800537; x=1691886937; bh=XN6qW01ZZv01Segx1q4AxBDTn9sB4AgbQHI LhhNmOx4=; b=HYfhwGTHLGmn/5TkbkKquZSI6Nbt/qHauZWAyu+SuYJmPXv6rqt PKBtAhQdOTZlpWrp8HmkYMn8gxZwBTacMcN72bUEYcGRFcZp/GTZ+F2gC6iU+sBH nawP3q39ft9mW49xuBVMBCDZr5R9cKLcE/v+GleEP+I9kU2LQHzGeYKQiYncVP4F /e5TSSkzB1ZJSHqlEtxlVajJssn4gJfpxOpIeA/AYXWSvSLRkrRH3GQM8Ys9Y5v7 bY6UrTJVK4HuxZvSHkNPi9rKXdo6x/d60al8XV/nojbzczq45hL7D8L45PjMglW6 U32hRTifcGhBS2InxHhuXEEIoFQNI1YZq+g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1691800537; x=1691886937; bh=XN6qW01ZZv01Segx1q4AxBDTn9sB4AgbQHI LhhNmOx4=; b=JEf+iHcVJ2VoznycE/S23HffOQOTg83FXAnu377Cc1p88bQ/F0e Y1+9LrBq7gncabU5qdaaSVnOa72e+bA7fdr5e8QqIONiYfhk9E6fw97Q0ooTVPos 5WA52XTkF3kJYgGY4X6Btesi/qUrFWM5H1zJqj8Na97VmBB8CauEVKXFpJx1Fpex Tuen86b3UdrfJ/EMAMxImQTTsTdcZNgo3ktEE6GysASVJFHGs+GkHb57s/m7PySk MS3ebnlk+EBsXV23rD43JxD9gnqzvL6M+V9TesTDvJ/gglXH8XPRUA5t2NXsj+71 953mNYohlsh7U2Z2fBgGo4zW3XYHyMTdimA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrleelgdefhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 11 Aug 2023 20:35:35 -0400 (EDT) Content-Language: en-US In-Reply-To: <875y64wvyz.fsf@protesilaos.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267236 Archived-At: Version: 30.1 On 28/07/2023 06:33, Protesilaos Stavrou wrote: >> From: Dmitry Gutov >> Date: Thu, 27 Jul 2023 04:28:08 +0300 >> [... 14 lines elided] >> The change in format seems to go hand-in-hand with the change in face, >> though, because help-key-binding has a box already. >> >> Does this look good to everybody? >> >> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el >> index d482cc24d70..3611757fb82 100644 >> --- a/lisp/progmodes/project.el >> +++ b/lisp/progmodes/project.el >> @@ -1781,9 +1781,13 @@ project--keymap-prompt >> (let ((key (if key >> (vector key) >> (where-is-internal cmd (list project-prefix-map) t)))) >> - (format "[%s] %s" >> - (propertize (key-description key) 'face 'bold) >> - label))) >> + (if (facep 'help-key-binding) >> + (format "%s %s" >> + (propertize (key-description key) 'face >> 'help-key-binding) >> + label) >> + (format "[%s] %s" >> + (propertize (key-description key) 'face 'bold) >> + label)))) >> project-switch-commands >> " ")) > I am fine with this approach, thank you! Now pushed to master, thanks all!