all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Cees de Groot <cg@evrl.com>
To: "Maxime Devos" <maximedevos@telenet.be>,
	"Ludovic Courtès" <ludo@gnu.org>
Cc: 54304@debbugs.gnu.org, Tobias Geerinckx-Rice <me@tobias.gr>
Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build
Date: Fri, 11 Mar 2022 22:01:07 +0000	[thread overview]
Message-ID: <l2mYwYLigQhrpSBhhoi-rlS7HNZWdsdIpu80iueL_TaW6O_hbIwKKYdL6R2h3jDnDSBrqXvgk_k8Ufn8zwtC8CmbFXy9oz-slDxoC9MugGw=@evrl.com> (raw)
In-Reply-To: <3772387f64195fabd6d4a69a4d29912e43896ba9.camel@telenet.be>

[-- Attachment #1: Type: text/plain, Size: 1267 bytes --]

Can’t we just run the patch? Then everything works just fine. I’m a full time Elixir developer and I can guarantee you that nothing will break :)

Sent from ProtonMail for iOS

On Fri, Mar 11, 2022 at 16:57, Maxime Devos <maximedevos@telenet.be> wrote:

> Ludovic Courtès schreef op vr 11-03-2022 om 22:51 [+0100]:
>> If we know what set of store references go in those blogs, we could
>> create a text file or something in #$output whose sole purpose is to
>> keep a reference to those store items.
>>
>> For example, if we know those BEAM files contain a reference to Git, we
>> can add a phase like:
>>
>> (lambda* (#:key inputs outputs #:allow-other-keys)
>> (symlink (search-input-file inputs "git")
>
> Doesn't that need to be "bin/git" instead of "git"?
>
>> (string-append (assoc-ref output "out")
>> "/libexec/elixir/.git")))
>>
>> That way the GC will keep Git around.
>>
>> Thoughts?
>
> That is not sufficient if git acquires a graft.
>
> Can elixir be patched to not compress the literals table (*)?
> Alternatively, does deflate have some kind of "compression
> level=0" setting -- perhaps we could do the same trick as
> done for JARs?
>
> (*) Preferably submitted upstream in some form, maybe with a
> configuration flag?
>
> Greetings,
> Maxime.

[-- Attachment #2: Type: text/html, Size: 1742 bytes --]

  reply	other threads:[~2022-03-11 22:02 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-08 20:52 [bug#54304] [PATCH] Don't fix git executable location during Elixir build Cees de Groot
2022-03-08 22:16 ` Maxime Devos
2022-03-09 17:35   ` Cees de Groot
2022-03-09 17:59     ` Tobias Geerinckx-Rice via Guix-patches via
2022-03-09 21:01       ` Cees de Groot
2022-03-09 21:49         ` Tobias Geerinckx-Rice via Guix-patches via
2022-03-11 21:33           ` Cees de Groot
2022-03-11 21:51             ` Ludovic Courtès
2022-03-11 21:57               ` Maxime Devos
2022-03-11 22:01                 ` Cees de Groot [this message]
2022-03-11 22:11                   ` Maxime Devos
2022-03-11 22:36                     ` Cees de Groot
2022-03-11 22:45                       ` Maxime Devos
2022-03-11 22:55                         ` Cees de Groot
2022-03-11 23:16                       ` Maxime Devos
2022-03-11 23:23                         ` Cees de Groot
2022-03-13 22:14                 ` Ludovic Courtès
2022-03-13 22:16                   ` Cees de Groot
2022-03-08 22:17 ` Maxime Devos
     [not found]   ` <OtG7oZgFz6vgVWUbmqcU-n34hv-sQCpJYpJKR7rdQvIDnB1sUh_1LoUl9egvv6vKWH_THdYl9gwPrzwzXx_FnxlPXJHaB3D70jY32T3oMuk=@evrl.com>
2022-03-09  7:31     ` Maxime Devos
2022-03-09 17:29       ` Cees de Groot
2022-03-08 22:18 ` Maxime Devos
2022-03-08 22:22 ` Maxime Devos
2022-03-09 17:31   ` Cees de Groot
2022-03-09 19:45     ` Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='l2mYwYLigQhrpSBhhoi-rlS7HNZWdsdIpu80iueL_TaW6O_hbIwKKYdL6R2h3jDnDSBrqXvgk_k8Ufn8zwtC8CmbFXy9oz-slDxoC9MugGw=@evrl.com' \
    --to=cg@evrl.com \
    --cc=54304@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=maximedevos@telenet.be \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.