all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Cees de Groot <cg@evrl.com>, 54304@debbugs.gnu.org
Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build
Date: Tue, 08 Mar 2022 23:22:42 +0100	[thread overview]
Message-ID: <5f60c94ec46bf7348c3f1906957dc3cbb4d9d395.camel@telenet.be> (raw)
In-Reply-To: <vJt9-EGxCcqYcRJpPwLXHo3DPOa8pdhHUN3rrKNuV7BI-evzYt_zYqj_XgYNdYE5Xv5OOf1U4fIsOPa0lBOWSh5fqKBrxxoeF1w3PkEAKiA=@evrl.com>

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]

Cees de Groot schreef op di 08-03-2022 om 20:52 [+0000]:
> * At run-time, Git is used by Mix if, and only if, there are any Git-based dependencies. This
>   is not the normal case, and in that sense Git is an optional dependency of Elixir - most
>   projects will work just fine without Git being present. Here, too, PATH + `git` is used
>   so if there is a need on a user's system to use Git-based dependencies, the user can just
>   add the package to the profile and things will just work.

If it's optional and not used most of the time, removing
it seems fine to me, though this seems useful information for the
description.  Also, it would be nice if 'elixir' were patched
to emit a nice message when 'git' is not found.  Suggestion:

  This project required 'git', but it is not in $PATH.  It can be
  installed into the user profile with `guix install git`.

You might want to contact whoever added the substitution originally,
to see what the original reasons were.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  parent reply	other threads:[~2022-03-08 22:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-08 20:52 [bug#54304] [PATCH] Don't fix git executable location during Elixir build Cees de Groot
2022-03-08 22:16 ` Maxime Devos
2022-03-09 17:35   ` Cees de Groot
2022-03-09 17:59     ` Tobias Geerinckx-Rice via Guix-patches via
2022-03-09 21:01       ` Cees de Groot
2022-03-09 21:49         ` Tobias Geerinckx-Rice via Guix-patches via
2022-03-11 21:33           ` Cees de Groot
2022-03-11 21:51             ` Ludovic Courtès
2022-03-11 21:57               ` Maxime Devos
2022-03-11 22:01                 ` Cees de Groot
2022-03-11 22:11                   ` Maxime Devos
2022-03-11 22:36                     ` Cees de Groot
2022-03-11 22:45                       ` Maxime Devos
2022-03-11 22:55                         ` Cees de Groot
2022-03-11 23:16                       ` Maxime Devos
2022-03-11 23:23                         ` Cees de Groot
2022-03-13 22:14                 ` Ludovic Courtès
2022-03-13 22:16                   ` Cees de Groot
2022-03-08 22:17 ` Maxime Devos
     [not found]   ` <OtG7oZgFz6vgVWUbmqcU-n34hv-sQCpJYpJKR7rdQvIDnB1sUh_1LoUl9egvv6vKWH_THdYl9gwPrzwzXx_FnxlPXJHaB3D70jY32T3oMuk=@evrl.com>
2022-03-09  7:31     ` Maxime Devos
2022-03-09 17:29       ` Cees de Groot
2022-03-08 22:18 ` Maxime Devos
2022-03-08 22:22 ` Maxime Devos [this message]
2022-03-09 17:31   ` Cees de Groot
2022-03-09 19:45     ` Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f60c94ec46bf7348c3f1906957dc3cbb4d9d395.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=54304@debbugs.gnu.org \
    --cc=cg@evrl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.