From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: Cees de Groot <cg@evrl.com>, Maxime Devos <maximedevos@telenet.be>
Cc: 54304@debbugs.gnu.org
Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build
Date: Wed, 09 Mar 2022 17:59:03 +0000 [thread overview]
Message-ID: <3FC21903-C19B-49C1-B865-7D15E1B3EC74@tobias.gr> (raw)
In-Reply-To: <vzMnya4Wgd5OVun0QL9Rb6Yz8i-gpXWRsqldCku8vMVCEbU5_G_KnikguFe-d-ZN067kP1qtJo9liNrWraPfLzowJZy5zYJvdGyNJaumbyo=@evrl.com>
On 9 March 2022 17:35:25 UTC, Cees de Groot <cg@evrl.com> wrote:
>> Propagation is not necessary to ‘keep git around’ (assuming that the
>
>Well.... the whole reason that I stumbled upon this was that the compile-time substitution referred to a Git version that got GC'd.
This simply Should Not happen. Guix's GC model (inherited from Nix) is brutally simple: if the raw string /gnu/store/xxx occurs anywhere within a protected /gnu/store/yyy (e.g. in a binary), then xxx is also protected, recursively.
Assuming those assumptions hold here it's a 'mystery' why git got GC'd. From experience and for our collective peace of mind I'd say it's more likely that they didn't hold somehow, than that there's a serious GC bug :-)
> And I think that that is the different between regular inputs and propagated inputs, whether inputs become eligible for GC at run-time or not.
So, no. Completely unrelated. The GC has no concept of time at all. This isn't Gentoo.
Propagated inputs are 'oh, here's this extra thing I was unable to properly patch, please add it to the profile and treat it as a GC reference anyway'.
This is ugly and regular, non-propagated inputs are always preferred. Some software just makes them too painful.
Cees,
Kind regards,
T G-R
Sent on the go. Excuse or enjoy my brevity.
next prev parent reply other threads:[~2022-03-09 18:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 20:52 [bug#54304] [PATCH] Don't fix git executable location during Elixir build Cees de Groot
2022-03-08 22:16 ` Maxime Devos
2022-03-09 17:35 ` Cees de Groot
2022-03-09 17:59 ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2022-03-09 21:01 ` Cees de Groot
2022-03-09 21:49 ` Tobias Geerinckx-Rice via Guix-patches via
2022-03-11 21:33 ` Cees de Groot
2022-03-11 21:51 ` Ludovic Courtès
2022-03-11 21:57 ` Maxime Devos
2022-03-11 22:01 ` Cees de Groot
2022-03-11 22:11 ` Maxime Devos
2022-03-11 22:36 ` Cees de Groot
2022-03-11 22:45 ` Maxime Devos
2022-03-11 22:55 ` Cees de Groot
2022-03-11 23:16 ` Maxime Devos
2022-03-11 23:23 ` Cees de Groot
2022-03-13 22:14 ` Ludovic Courtès
2022-03-13 22:16 ` Cees de Groot
2022-03-08 22:17 ` Maxime Devos
[not found] ` <OtG7oZgFz6vgVWUbmqcU-n34hv-sQCpJYpJKR7rdQvIDnB1sUh_1LoUl9egvv6vKWH_THdYl9gwPrzwzXx_FnxlPXJHaB3D70jY32T3oMuk=@evrl.com>
2022-03-09 7:31 ` Maxime Devos
2022-03-09 17:29 ` Cees de Groot
2022-03-08 22:18 ` Maxime Devos
2022-03-08 22:22 ` Maxime Devos
2022-03-09 17:31 ` Cees de Groot
2022-03-09 19:45 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FC21903-C19B-49C1-B865-7D15E1B3EC74@tobias.gr \
--to=guix-patches@gnu.org \
--cc=54304@debbugs.gnu.org \
--cc=cg@evrl.com \
--cc=maximedevos@telenet.be \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.