[bug#53929] [PATCH] gnu: Add python-onlykey

[bug#53929] [PATCH] gnu: Add python-onlykey

[Pāladhammika via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 28 bytes --]

All the best,
Pāladhammika

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-python-onlykey.patch --]
[-- Type: text/x-patch; name=0001-gnu-Add-python-onlykey.patch, Size: 1715 bytes --]

From fcd7308b757170c86913b5e97df1971398d30270 Mon Sep 17 00:00:00 2001
From: paladhammika <paladhammika@protonmail.com>
Date: Thu, 10 Feb 2022 16:26:03 -0500
Subject: [PATCH] gnu: Add python-onlykey

---
 gnu/packages/python-crypto.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/python-crypto.scm b/gnu/packages/python-crypto.scm
index e49ccdf1f2..8559cc9fd0 100644
--- a/gnu/packages/python-crypto.scm
+++ b/gnu/packages/python-crypto.scm
@@ -1757,3 +1757,32 @@ (define-public python-sop
 scaffolding for the command line, which should make it relatively easy to
 supply a handful of python functions as methods to a class.")
     (license license:expat))) ; MIT license
+
+(define-public python-onlykey
+  (package
+   (name "python-onlykey")
+   (version "1.2.6")
+   (source
+    (origin
+     (method url-fetch)
+     (uri (pypi-uri "onlykey" version))
+     (sha256
+      (base32 "1mq02x6qncsjqadqjakywdnfclsv7jaabfk1kzwrm5x05c0hbzji"))))
+   (build-system python-build-system)
+   (arguments '(#:tests? #f))           ;no tests
+   (native-inputs
+    (list python-cython))
+   (propagated-inputs
+    (list python-aenum
+          python-ecdsa
+          python-hidapi
+          python-onlykey-solo-python
+          python-prompt-toolkit
+          python-pynacl
+          python-six
+          onlykey-udev-rules))
+   (home-page "https://github.com/trustcrypto/python-onlykey")
+   (synopsis "OnlyKey client and command-line tool")
+   (description "@code{OnlyKey Python Command-Line Utility} is a command line tool
+targeted towards more advanced users.  This can be used for configuration and testing.")
+   (license license:expat)))
-- 
2.34.0

[bug#53929] [PATCH] gnu: Add python-onlykey

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

Pāladhammika via Guix-patches via schreef op do 10-02-2022 om 21:30
[+0000]:
> +   (arguments '(#:tests? #f))           ;no tests

I see a 'tests' directory, so it appears there actually are tests.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

[bug#53929] [PATCH] gnu: Add python-onlykey

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

Pāladhammika via Guix-patches via schreef op do 10-02-2022 om 21:30
[+0000]:
> +   (synopsis "OnlyKey client and command-line tool")
> +   (description "@code{OnlyKey Python Command-Line Utility} is a
> command line tool
> +targeted towards more advanced users.  This can be used for
> configuration and testing.")

This tells me that 'OnlyKey Python Command-Line Utility’ is a CLI
tool with some configuration and testing, and it makes a distinction
between ‘advanced users’ and ... ‘not-advanced users’?

Making a judgement about user's ‘advancedness’ doesn't seem nice,
can the description be factual and descriptive, so potential users
can decide for theirselves whether this package is suitable for them?

Also, this description doesn't tell me anything what this package is
useful for.  If I replace ‘Onlykey ... Utility’ by ‘shepherd’, then
this might as well be a description for the 'shepherd' package.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

[bug#53929] [PATCH] gnu: Add python-onlykey

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

Pāladhammika via Guix-patches via schreef op do 10-02-2022 om 21:30
[+0000]:
> +   (license license:expat)))

How did you determine this license?  I'm not seeing the Expat license
text anywhere in the git repo, and the only mention of 'expat' or 'MIT'
appears to be in in ‘setup.py’, but ‘setup.py’ only says

  license='MIT'

which does not seem sufficient to me.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

[bug#53929] [PATCH] gnu: Add python-onlykey

[Pāladhammika via Guix-patches via]

I see. Took the Nix package definition as an example (https://github.com/NixOS/nixpkgs/blob/7adc9c14ec74b27358a8df9b973087e351425a79/pkgs/tools/security/onlykey-cli/default.nix#L25) which turned off tests.

All the best,
Pāladhammika

------- Original Message -------

On Saturday, February 12th, 2022 at 5:48 PM, Maxime Devos <maximedevos@telenet.be> wrote:

> Pāladhammika via Guix-patches via schreef op do 10-02-2022 om 21:30
>
> [+0000]:
>
> > +   (arguments '(#:tests? #f))           ;no tests
>
> I see a 'tests' directory, so it appears there actually are tests.
>
> Greetings,
>
> Maxime.

[bug#53929] [PATCH] gnu: Add python-onlykey

[Pāladhammika via Guix-patches via]

This was auto-generated by `guix import pypi onlykey`. Also checked it against the Nix definition (https://github.com/NixOS/nixpkgs/blob/7adc9c14ec74b27358a8df9b973087e351425a79/pkgs/tools/security/onlykey-cli/default.nix#L31) and MIT can be see as the license on PyPI (https://pypi.org/project/onlykey/). Other than that there seems to be no declaration of a license.

All the best,
Pāladhammika

Sent with ProtonMail Secure Email.

------- Original Message -------

On Saturday, February 12th, 2022 at 5:55 PM, Maxime Devos <maximedevos@telenet.be> wrote:

> Pāladhammika via Guix-patches via schreef op do 10-02-2022 om 21:30
>
> [+0000]:
>
> > +   (license license:expat)))
>
> How did you determine this license? I'm not seeing the Expat license
>
> text anywhere in the git repo, and the only mention of 'expat' or 'MIT'
>
> appears to be in in ‘setup.py’, but ‘setup.py’ only says
>
> license='MIT'
>
> which does not seem sufficient to me.
>
> Greetings,
>
> Maxime.

[bug#53929] [PATCH] gnu: Add python-onlykey

[Pāladhammika via Guix-patches via]

Taken from the horses mouth: "A command line interface to the OnlyKey (Similar functionality to OnlyKey App) that can be used for configuration, scripting, and testing." -- Is this considered sufficient?

All the best,
Pāladhammika

------- Original Message -------

On Saturday, February 12th, 2022 at 5:53 PM, Maxime Devos <maximedevos@telenet.be> wrote:

> Pāladhammika via Guix-patches via schreef op do 10-02-2022 om 21:30
>
> [+0000]:
>
> > +   (synopsis "OnlyKey client and command-line tool")
> >
> > +   (description "@code{OnlyKey Python Command-Line Utility} is a
> >
> > command line tool
> >
> > +targeted towards more advanced users.  This can be used for
> >
> > configuration and testing.")
>
> This tells me that 'OnlyKey Python Command-Line Utility’ is a CLI
>
> tool with some configuration and testing, and it makes a distinction
>
> between ‘advanced users’ and ... ‘not-advanced users’?
>
> Making a judgement about user's ‘advancedness’ doesn't seem nice,
>
> can the description be factual and descriptive, so potential users
>
> can decide for theirselves whether this package is suitable for them?
>
> Also, this description doesn't tell me anything what this package is
>
> useful for. If I replace ‘Onlykey ... Utility’ by ‘shepherd’, then
>
> this might as well be a description for the 'shepherd' package.
>
> Greetings,
>
> Maxime.

[bug#53929] [PATCH] gnu: Add python-onlykey

[Ludovic Courtès]

Hi Pāladhammika,

Pāladhammika <paladhammika@protonmail.com> skribis:

> I see. Took the Nix package definition as an example (https://github.com/NixOS/nixpkgs/blob/7adc9c14ec74b27358a8df9b973087e351425a79/pkgs/tools/security/onlykey-cli/default.nix#L25) which turned off tests.

In Guix the QA standard is to run tests by default.  When tests cannot
be run for some reason, we add a short comment next to #:tests? #f
explaining why.

Could you take this and Maxime’s other comments into account and send an
updated patch?

Thanks in advance!

Ludo’.

[bug#53929] [PATCH] gnu: Add python-onlykey

[Ludovic Courtès]

Hi Pāladhammika,

A friendly reminder:

  https://issues.guix.gnu.org/53929

TIA,
Ludo’.

Ludovic Courtès <ludo@gnu.org> skribis:

> Hi Pāladhammika,
>
> Pāladhammika <paladhammika@protonmail.com> skribis:
>
>> I see. Took the Nix package definition as an example (https://github.com/NixOS/nixpkgs/blob/7adc9c14ec74b27358a8df9b973087e351425a79/pkgs/tools/security/onlykey-cli/default.nix#L25) which turned off tests.
>
> In Guix the QA standard is to run tests by default.  When tests cannot
> be run for some reason, we add a short comment next to #:tests? #f
> explaining why.
>
> Could you take this and Maxime’s other comments into account and send an
> updated patch?
>
> Thanks in advance!
>
> Ludo’.

[bug#53929] [PATCH] gnu: Add python-onlykey

[Ludovic Courtès]

Hi!

Pāladhammika let me know privately that they won’t be able to take care
of it in the foreseeable future.

Any takers?

If not, I suggest closing this issue in a couple of weeks.

Ludo’.