From: "Ludovic Courtès" <ludo@gnu.org>
To: Pāladhammika <paladhammika@protonmail.com>
Cc: 53929@debbugs.gnu.org, Maxime Devos <maximedevos@telenet.be>
Subject: [bug#53929] [PATCH] gnu: Add python-onlykey
Date: Tue, 05 Apr 2022 18:09:10 +0200 [thread overview]
Message-ID: <87wng3ldg9.fsf_-_@gnu.org> (raw)
In-Reply-To: <87a6e2kc6t.fsf_-_@gnu.org> ("Ludovic Courtès"'s message of "Sun, 06 Mar 2022 22:23:22 +0100")
Hi Pāladhammika,
A friendly reminder:
https://issues.guix.gnu.org/53929
TIA,
Ludo’.
Ludovic Courtès <ludo@gnu.org> skribis:
> Hi Pāladhammika,
>
> Pāladhammika <paladhammika@protonmail.com> skribis:
>
>> I see. Took the Nix package definition as an example (https://github.com/NixOS/nixpkgs/blob/7adc9c14ec74b27358a8df9b973087e351425a79/pkgs/tools/security/onlykey-cli/default.nix#L25) which turned off tests.
>
> In Guix the QA standard is to run tests by default. When tests cannot
> be run for some reason, we add a short comment next to #:tests? #f
> explaining why.
>
> Could you take this and Maxime’s other comments into account and send an
> updated patch?
>
> Thanks in advance!
>
> Ludo’.
next prev parent reply other threads:[~2022-04-05 16:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 21:30 [bug#53929] [PATCH] gnu: Add python-onlykey Pāladhammika via Guix-patches via
2022-02-12 17:48 ` Maxime Devos
2022-02-12 22:02 ` Pāladhammika via Guix-patches via
2022-03-06 21:23 ` Ludovic Courtès
2022-04-05 16:09 ` Ludovic Courtès [this message]
2022-04-27 21:07 ` Ludovic Courtès
2022-02-12 17:53 ` Maxime Devos
2022-02-12 22:15 ` Pāladhammika via Guix-patches via
2022-02-12 17:55 ` Maxime Devos
2022-02-12 22:14 ` Pāladhammika via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wng3ldg9.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=53929@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
--cc=paladhammika@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.