Re: [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.

Re: [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.

[Alex Sassmannshausen]

Hi Ricardo,

On 17 Jul 2016 10:44, Ricardo Wurmus <rekado@elephly.net> wrote:
>
>
> Alex Sassmannshausen <alex.sassmannshausen@gmail.com> writes: 
>
> > * gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable. 
> > --- 
> >  gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++ 
> >  1 file changed, 27 insertions(+) 
> > 
> > diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm 
> > index fc63df3..1f18214 100644 
> > --- a/gnu/packages/perl.scm 
> > +++ b/gnu/packages/perl.scm 
> > @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging 
> >  mechanism.") 
> >      (license (package-license perl)))) 
> >  
> > +(define-public perl-log-any-adapter-log4perl 
> > +  (package 
> > +    (name "perl-log-any-adapter-log4perl") 
> > +    (version "0.08") 
> > +    (source 
> > +     (origin 
> > +       (method url-fetch) 
> > +       (uri (string-append 
> > +             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-" 
> > +             version 
> > +             ".tar.gz")) 
> > +       (sha256 
> > +        (base32 
> > +         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn")))) 
> > +    (build-system perl-build-system) 
> > +    (native-inputs `(("perl-log-any" ,perl-log-any))) 
> > +    (inputs 
> > +     `(("perl-log-any" ,perl-log-any) 
> > +       ("perl-log-log4perl" ,perl-log-log4perl))) 
>
> Shouldn’t these inputs be propagated inputs instead?  Perl doesn’t have 
> anything comparable to the RUNPATH feature, so inputs must be 
> propagated. 
>
> Have you tested using this module, e.g. in a container?

You are quite right, I have now tested loading the module from within a container in a test script, and I do not to propagate the inputs.

I will update the patch - and also look at the perl importer, as it seems to add inputs rather than propagated inputs by default.

Thanks for your review!

Alex

[PATCH 0/3] Perl log patches fixed

[Alex Sassmannshausen]

Hello,

In series, the three revised patches for perl-log.  As seems all to often the
case, I got pulled to other things.  But I fixed the inputs and wrapped
descriptions in @code where appropriate.

I'll push these shortly unless you have any further comments.

Ben: apologies for the delay in getting log4perl in in the end!

Cheers,

Alex

Alex Sassmannshausen (3):
  gnu: Add perl-log-any.
  gnu: Add perl-log-log4perl.
  gnu: Add perl-log-any-adapter-log4perl.

 gnu/packages/perl.scm | 79 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 79 insertions(+)

-- 
2.8.4

[PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.

[Alex Sassmannshausen]

* gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable.
---
 gnu/packages/perl.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index abdc819..6513892 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -2970,6 +2970,31 @@ worrying about whether the application has chosen (or will ever choose) a
 logging mechanism.")
     (license (package-license perl))))
 
+(define-public perl-log-any-adapter-log4perl
+  (package
+    (name "perl-log-any-adapter-log4perl")
+    (version "0.08")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn"))))
+    (build-system perl-build-system)
+    (propagated-inputs
+     `(("perl-log-any" ,perl-log-any)
+       ("perl-log-log4perl" ,perl-log-log4perl)))
+    (home-page
+     "http://search.cpan.org/dist/Log-Any-Adapter-Log4perl")
+    (synopsis "Log::Any adapter for Log::Log4perl")
+    (description "@code{Log::Any::Adapter::Log4perl} provides a
+@code{Log::Any} adapter using @code{Log::Log4perl} for logging.")
+    (license (package-license perl))))
+
 (define-public perl-log-log4perl
   (package
     (name "perl-log-log4perl")
-- 
2.8.4

Re: [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.

[Alex Sassmannshausen]

On 17 Jul 2016 12:17, Alex Sassmannshausen <alex@pompo.co> wrote:
>
> Hi Ricardo,
>
> On 17 Jul 2016 10:44, Ricardo Wurmus <rekado@elephly.net> wrote:
> >
> >
> > Alex Sassmannshausen <alex.sassmannshausen@gmail.com> writes: 
> >
> > > * gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable. 
> > > --- 
> > >  gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++ 
> > >  1 file changed, 27 insertions(+) 
> > > 
> > > diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm 
> > > index fc63df3..1f18214 100644 
> > > --- a/gnu/packages/perl.scm 
> > > +++ b/gnu/packages/perl.scm 
> > > @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging 
> > >  mechanism.") 
> > >      (license (package-license perl)))) 
> > >  
> > > +(define-public perl-log-any-adapter-log4perl 
> > > +  (package 
> > > +    (name "perl-log-any-adapter-log4perl") 
> > > +    (version "0.08") 
> > > +    (source 
> > > +     (origin 
> > > +       (method url-fetch) 
> > > +       (uri (string-append 
> > > +             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-" 
> > > +             version 
> > > +             ".tar.gz")) 
> > > +       (sha256 
> > > +        (base32 
> > > +         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn")))) 
> > > +    (build-system perl-build-system) 
> > > +    (native-inputs `(("perl-log-any" ,perl-log-any))) 
> > > +    (inputs 
> > > +     `(("perl-log-any" ,perl-log-any) 
> > > +       ("perl-log-log4perl" ,perl-log-log4perl))) 
> >
> > Shouldn’t these inputs be propagated inputs instead?  Perl doesn’t have 
> > anything comparable to the RUNPATH feature, so inputs must be 
> > propagated. 
> >
> > Have you tested using this module, e.g. in a container?
>
> You are quite right, I have now tested loading the module from within a container in a test script, and I do not to propagate the inputs.
>
> I will update the patch - and also look at the perl importer, as it seems to add inputs rather than propagated inputs by default.
>
> Thanks for your review!
>
> Alex

Looking at this, there seems to be a larger problem in perl.scm with this. Many packages simply specify inputs, and I believe the same reasoning that applied to my package her will apply to those too.

Binaries are not affected by this problem, as we generally use wrapping scripts to explicitly include all dependencies in PERL5LIB.

Am I right in thinking that we should be systematically changing inputs to propagated-inputs in the whole of perl.scm?

Confused but eager to help,

Alex

Re: [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.

[Ricardo Wurmus]

Alex Sassmannshausen <alex@pompo.co> writes:

> Looking at this, there seems to be a larger problem in perl.scm with
> this. Many packages simply specify inputs, and I believe the same
> reasoning that applied to my package her will apply to those too.
>
> Binaries are not affected by this problem, as we generally use
> wrapping scripts to explicitly include all dependencies in PERL5LIB.
>
> Am I right in thinking that we should be systematically changing
> inputs to propagated-inputs in the whole of perl.scm?

Yes, I think this should be done.  We have the same problem with some
Python packages.

Ideally, we would find a way to do without propagation as it has some
ugly effects, but I’m not sure if this is possible in Perl.  There were
some discussions about fixing this is Python (see the mailing list
archives) but I must admit to being not knowledgeable enough about
Python to confidently propose a patch.

~~ Ricardo

Re: [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.

[Eric Bavier]

On Mon, 18 Jul 2016 10:29:41 +0200
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

> Alex Sassmannshausen <alex@pompo.co> writes:
> 
> > Looking at this, there seems to be a larger problem in perl.scm with
> > this. Many packages simply specify inputs, and I believe the same
> > reasoning that applied to my package her will apply to those too.
> >
> > Binaries are not affected by this problem, as we generally use
> > wrapping scripts to explicitly include all dependencies in PERL5LIB.
> >
> > Am I right in thinking that we should be systematically changing
> > inputs to propagated-inputs in the whole of perl.scm?  
> 
> Yes, I think this should be done.  We have the same problem with some
> Python packages.

Though, it's not quite as simple as propagate-all-inputs.  Some care
must be taken, since many inputs are for tests only.  While some
packages have test-only inputs in native-inputs, this is not
universally true.

`~Eric

[PATCH 0/3] Add perl-log modules

[Alex Sassmannshausen]

Hello,

The following 3 patches add perl-log modules.  As per usual they pass lint and
a pure environment build.

I now have commit access, but just to be sure I will continue to wait for
review for the next few submissions of even simple packages before committing
them myself.

Apologies for the confused email configuration — my actual smtp server is
currently having problems :-(

Best wishes

Alex

Alex Sassmannshausen (3):
  gnu: Add perl-log-any.
  gnu: Add perl-log-log4perl.
  gnu: Add perl-log-any-adapter-log4perl.

 gnu/packages/perl.scm | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 85 insertions(+)

-- 
2.8.4

[PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.

[Alex Sassmannshausen]

* gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable.
---
 gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index fc63df3..1f18214 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
 mechanism.")
     (license (package-license perl))))
 
+(define-public perl-log-any-adapter-log4perl
+  (package
+    (name "perl-log-any-adapter-log4perl")
+    (version "0.08")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn"))))
+    (build-system perl-build-system)
+    (native-inputs `(("perl-log-any" ,perl-log-any)))
+    (inputs
+     `(("perl-log-any" ,perl-log-any)
+       ("perl-log-log4perl" ,perl-log-log4perl)))
+    (home-page
+     "http://search.cpan.org/dist/Log-Any-Adapter-Log4perl")
+    (synopsis "Log::Any adapter for Log::Log4perl")
+    (description "Log::Any::Adapter::Log4perl provides a Log::Any adapter
+using Log::Log4perl for logging.  log4perl must be initialized before calling
+set.  There are no parameters.")
+    (license (package-license perl))))
+
 (define-public perl-log-log4perl
   (package
     (name "perl-log-log4perl")
-- 
2.8.4

Re: [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.

[Ben Woodcroft]

On 17/07/16 04:20, Alex Sassmannshausen wrote:
> * gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable.
> ---
>   gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
>   1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index fc63df3..1f18214 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
>   mechanism.")
>       (license (package-license perl))))
>   
> +(define-public perl-log-any-adapter-log4perl
> +  (package
> +    (name "perl-log-any-adapter-log4perl")
> +    (version "0.08")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn"))))
> +    (build-system perl-build-system)
> +    (native-inputs `(("perl-log-any" ,perl-log-any)))
> +    (inputs
> +     `(("perl-log-any" ,perl-log-any)

This is both an input and a native-input - I imagine the former is best.

> +       ("perl-log-log4perl" ,perl-log-log4perl)))
> +    (home-page
> +     "http://search.cpan.org/dist/Log-Any-Adapter-Log4perl")
> +    (synopsis "Log::Any adapter for Log::Log4perl")
> +    (description "Log::Any::Adapter::Log4perl provides a Log::Any adapter
> +using Log::Log4perl for logging.  log4perl must be initialized before calling
> +set.  There are no parameters.")
> +    (license (package-license perl))))
> +
>   (define-public perl-log-log4perl
>     (package
>       (name "perl-log-log4perl")

OK.

Re: [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.

[Ricardo Wurmus]

Alex Sassmannshausen <alex.sassmannshausen@gmail.com> writes:

> * gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable.
> ---
>  gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index fc63df3..1f18214 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
>  mechanism.")
>      (license (package-license perl))))
>  
> +(define-public perl-log-any-adapter-log4perl
> +  (package
> +    (name "perl-log-any-adapter-log4perl")
> +    (version "0.08")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn"))))
> +    (build-system perl-build-system)
> +    (native-inputs `(("perl-log-any" ,perl-log-any)))
> +    (inputs
> +     `(("perl-log-any" ,perl-log-any)
> +       ("perl-log-log4perl" ,perl-log-log4perl)))

Shouldn’t these inputs be propagated inputs instead?  Perl doesn’t have
anything comparable to the RUNPATH feature, so inputs must be
propagated.

Have you tested using this module, e.g. in a container?

~~ Ricardo