From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.
Date: Sun, 17 Jul 2016 10:44:30 +0200
Message-ID: <874m7oirgx.fsf@elephly.net>
References: <20160716182009.23643-1-alex@pompo.co>
	<20160716182009.23643-4-alex@pompo.co>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43796)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bOhvf-0007FK-BN
	for guix-devel@gnu.org; Sun, 17 Jul 2016 05:00:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bOhvY-0006gr-7S
	for guix-devel@gnu.org; Sun, 17 Jul 2016 05:00:00 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:24072)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bOhvX-0006gQ-VF
	for guix-devel@gnu.org; Sun, 17 Jul 2016 04:59:56 -0400
In-reply-to: <20160716182009.23643-4-alex@pompo.co>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Alex Sassmannshausen <alex.sassmannshausen@gmail.com>
Cc: guix-devel@gnu.org


Alex Sassmannshausen <alex.sassmannshausen@gmail.com> writes:

> * gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable.
> ---
>  gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index fc63df3..1f18214 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging
>  mechanism.")
>      (license (package-license perl))))
>  
> +(define-public perl-log-any-adapter-log4perl
> +  (package
> +    (name "perl-log-any-adapter-log4perl")
> +    (version "0.08")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn"))))
> +    (build-system perl-build-system)
> +    (native-inputs `(("perl-log-any" ,perl-log-any)))
> +    (inputs
> +     `(("perl-log-any" ,perl-log-any)
> +       ("perl-log-log4perl" ,perl-log-log4perl)))

Shouldn’t these inputs be propagated inputs instead?  Perl doesn’t have
anything comparable to the RUNPATH feature, so inputs must be
propagated.

Have you tested using this module, e.g. in a container?

~~ Ricardo