all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.
@ 2016-07-17 10:46 Alex Sassmannshausen
  2016-07-18  8:29 ` Ricardo Wurmus
  0 siblings, 1 reply; 8+ messages in thread
From: Alex Sassmannshausen @ 2016-07-17 10:46 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: guix-devel


On 17 Jul 2016 12:17, Alex Sassmannshausen <alex@pompo.co> wrote:
>
> Hi Ricardo,
>
> On 17 Jul 2016 10:44, Ricardo Wurmus <rekado@elephly.net> wrote:
> >
> >
> > Alex Sassmannshausen <alex.sassmannshausen@gmail.com> writes: 
> >
> > > * gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable. 
> > > --- 
> > >  gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++ 
> > >  1 file changed, 27 insertions(+) 
> > > 
> > > diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm 
> > > index fc63df3..1f18214 100644 
> > > --- a/gnu/packages/perl.scm 
> > > +++ b/gnu/packages/perl.scm 
> > > @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging 
> > >  mechanism.") 
> > >      (license (package-license perl)))) 
> > >  
> > > +(define-public perl-log-any-adapter-log4perl 
> > > +  (package 
> > > +    (name "perl-log-any-adapter-log4perl") 
> > > +    (version "0.08") 
> > > +    (source 
> > > +     (origin 
> > > +       (method url-fetch) 
> > > +       (uri (string-append 
> > > +             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-" 
> > > +             version 
> > > +             ".tar.gz")) 
> > > +       (sha256 
> > > +        (base32 
> > > +         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn")))) 
> > > +    (build-system perl-build-system) 
> > > +    (native-inputs `(("perl-log-any" ,perl-log-any))) 
> > > +    (inputs 
> > > +     `(("perl-log-any" ,perl-log-any) 
> > > +       ("perl-log-log4perl" ,perl-log-log4perl))) 
> >
> > Shouldn’t these inputs be propagated inputs instead?  Perl doesn’t have 
> > anything comparable to the RUNPATH feature, so inputs must be 
> > propagated. 
> >
> > Have you tested using this module, e.g. in a container?
>
> You are quite right, I have now tested loading the module from within a container in a test script, and I do not to propagate the inputs.
>
> I will update the patch - and also look at the perl importer, as it seems to add inputs rather than propagated inputs by default.
>
> Thanks for your review!
>
> Alex

Looking at this, there seems to be a larger problem in perl.scm with this. Many packages simply specify inputs, and I believe the same reasoning that applied to my package her will apply to those too.

Binaries are not affected by this problem, as we generally use wrapping scripts to explicitly include all dependencies in PERL5LIB.

Am I right in thinking that we should be systematically changing inputs to propagated-inputs in the whole of perl.scm?

Confused but eager to help,

Alex

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH 0/3] Perl log patches fixed
@ 2016-07-28 10:56 Alex Sassmannshausen
  2016-07-28 10:56 ` [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl Alex Sassmannshausen
  0 siblings, 1 reply; 8+ messages in thread
From: Alex Sassmannshausen @ 2016-07-28 10:56 UTC (permalink / raw)
  To: guix-devel

Hello,

In series, the three revised patches for perl-log.  As seems all to often the
case, I got pulled to other things.  But I fixed the inputs and wrapped
descriptions in @code where appropriate.

I'll push these shortly unless you have any further comments.

Ben: apologies for the delay in getting log4perl in in the end!

Cheers,

Alex

Alex Sassmannshausen (3):
  gnu: Add perl-log-any.
  gnu: Add perl-log-log4perl.
  gnu: Add perl-log-any-adapter-log4perl.

 gnu/packages/perl.scm | 79 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 79 insertions(+)

-- 
2.8.4

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl.
@ 2016-07-17 10:17 Alex Sassmannshausen
  0 siblings, 0 replies; 8+ messages in thread
From: Alex Sassmannshausen @ 2016-07-17 10:17 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: guix-devel

Hi Ricardo,

On 17 Jul 2016 10:44, Ricardo Wurmus <rekado@elephly.net> wrote:
>
>
> Alex Sassmannshausen <alex.sassmannshausen@gmail.com> writes: 
>
> > * gnu/packages/perl.scm (perl-log-any-adapter-log4perl): New variable. 
> > --- 
> >  gnu/packages/perl.scm | 27 +++++++++++++++++++++++++++ 
> >  1 file changed, 27 insertions(+) 
> > 
> > diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm 
> > index fc63df3..1f18214 100644 
> > --- a/gnu/packages/perl.scm 
> > +++ b/gnu/packages/perl.scm 
> > @@ -2970,6 +2970,33 @@ whether the application has chosen (or will ever choose) a logging 
> >  mechanism.") 
> >      (license (package-license perl)))) 
> >  
> > +(define-public perl-log-any-adapter-log4perl 
> > +  (package 
> > +    (name "perl-log-any-adapter-log4perl") 
> > +    (version "0.08") 
> > +    (source 
> > +     (origin 
> > +       (method url-fetch) 
> > +       (uri (string-append 
> > +             "mirror://cpan/authors/id/D/DA/DAGOLDEN/Log-Any-Adapter-Log4perl-" 
> > +             version 
> > +             ".tar.gz")) 
> > +       (sha256 
> > +        (base32 
> > +         "0xf4fnrsznvg0hf36q481124ja1hp3lybki1xjgnk82z9990jmxn")))) 
> > +    (build-system perl-build-system) 
> > +    (native-inputs `(("perl-log-any" ,perl-log-any))) 
> > +    (inputs 
> > +     `(("perl-log-any" ,perl-log-any) 
> > +       ("perl-log-log4perl" ,perl-log-log4perl))) 
>
> Shouldn’t these inputs be propagated inputs instead?  Perl doesn’t have 
> anything comparable to the RUNPATH feature, so inputs must be 
> propagated. 
>
> Have you tested using this module, e.g. in a container?

You are quite right, I have now tested loading the module from within a container in a test script, and I do not to propagate the inputs.

I will update the patch - and also look at the perl importer, as it seems to add inputs rather than propagated inputs by default.

Thanks for your review!

Alex

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH 0/3] Add perl-log modules
@ 2016-07-16 18:20 Alex Sassmannshausen
  2016-07-16 18:20 ` [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl Alex Sassmannshausen
  0 siblings, 1 reply; 8+ messages in thread
From: Alex Sassmannshausen @ 2016-07-16 18:20 UTC (permalink / raw)
  To: guix-devel

Hello,

The following 3 patches add perl-log modules.  As per usual they pass lint and
a pure environment build.

I now have commit access, but just to be sure I will continue to wait for
review for the next few submissions of even simple packages before committing
them myself.

Apologies for the confused email configuration — my actual smtp server is
currently having problems :-(

Best wishes

Alex

Alex Sassmannshausen (3):
  gnu: Add perl-log-any.
  gnu: Add perl-log-log4perl.
  gnu: Add perl-log-any-adapter-log4perl.

 gnu/packages/perl.scm | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 85 insertions(+)

-- 
2.8.4

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2016-07-28 10:57 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-17 10:46 [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl Alex Sassmannshausen
2016-07-18  8:29 ` Ricardo Wurmus
2016-07-18 13:09   ` Eric Bavier
  -- strict thread matches above, loose matches on Subject: below --
2016-07-28 10:56 [PATCH 0/3] Perl log patches fixed Alex Sassmannshausen
2016-07-28 10:56 ` [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl Alex Sassmannshausen
2016-07-17 10:17 Alex Sassmannshausen
2016-07-16 18:20 [PATCH 0/3] Add perl-log modules Alex Sassmannshausen
2016-07-16 18:20 ` [PATCH 3/3] gnu: Add perl-log-any-adapter-log4perl Alex Sassmannshausen
2016-07-17  3:10   ` Ben Woodcroft
2016-07-17  8:44   ` Ricardo Wurmus

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.