* [bug#40032] [PATCH] gnu: Add nvme-cli
@ 2020-03-12 1:13 Vincent Legoll
2020-03-12 18:15 ` Leo Famulari
0 siblings, 1 reply; 9+ messages in thread
From: Vincent Legoll @ 2020-03-12 1:13 UTC (permalink / raw)
To: 40032
[-- Attachment #1: Type: text/plain, Size: 152 bytes --]
Lightly tested (list & list-subsys commands)
on real hardware.
Guix pack'ed the binary and copied out of the
VM to run (in debian)
--
Vincent Legoll
[-- Attachment #2: 0001-gnu-Add-nvme-cli.patch --]
[-- Type: text/x-patch, Size: 1975 bytes --]
From 9c836b206d65c0e80706c0a3730e77f508b10f43 Mon Sep 17 00:00:00 2001
From: Vincent Legoll <vincent.legoll@gmail.com>
Date: Thu, 12 Mar 2020 01:51:12 +0100
Subject: [PATCH] gnu: Add nvme-cli
* gnu/packages/linux.scm (nvme-cli): New variable.
---
gnu/packages/linux.scm | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index b6048a8cfb..d7b31103c8 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -3544,6 +3544,35 @@ IDE driver subsystem. Many external USB drive enclosures with SCSI-ATA Command
Translation (@dfn{SAT}) are also supported.")
(license (license:non-copyleft "file://LICENSE.TXT"))))
+(define-public nvme-cli
+ (package
+ (name "nvme-cli")
+ (version "1.10.1")
+ (home-page "https://github.com/linux-nvme/nvme-cli")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url home-page)
+ (commit (string-append "v" version))))
+ (sha256
+ (base32 "12wp2wxmsw2v8m9bhvwvdbhdgx1md8iilhbl19sfzz2araiwi2x8"))
+ (file-name (git-file-name name version))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:make-flags (list "CC=gcc")
+ #:phases (modify-phases %standard-phases
+ (delete 'configure)
+ (replace 'install
+ (lambda _
+ (zero? (system* "make" "install-spec" "PREFIX="
+ (string-append "DESTDIR=" %output))))))
+ #:tests? #f))
+ (synopsis "NVM-Express user space tooling for Linux")
+ (description "Utility to provide standards compliant tooling for NVM-Express
+drives. It was made specifically for Linux as it relies on the IOCTLs defined
+by the mainline kernel driver.")
+ (license license:gpl2+)))
+
(define-public rfkill
(package
(name "rfkill")
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [bug#40032] [PATCH] gnu: Add nvme-cli
2020-03-12 1:13 [bug#40032] [PATCH] gnu: Add nvme-cli Vincent Legoll
@ 2020-03-12 18:15 ` Leo Famulari
2020-03-13 23:14 ` Vincent Legoll
0 siblings, 1 reply; 9+ messages in thread
From: Leo Famulari @ 2020-03-12 18:15 UTC (permalink / raw)
To: Vincent Legoll; +Cc: 40032
On Thu, Mar 12, 2020 at 02:13:06AM +0100, Vincent Legoll wrote:
> + #:tests? #f))
Why are the tests skipped? Please, always add a code comment here for
reviewers.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [bug#40032] [PATCH] gnu: Add nvme-cli
2020-03-12 18:15 ` Leo Famulari
@ 2020-03-13 23:14 ` Vincent Legoll
2020-03-15 17:07 ` Vincent Legoll
0 siblings, 1 reply; 9+ messages in thread
From: Vincent Legoll @ 2020-03-13 23:14 UTC (permalink / raw)
To: Leo Famulari; +Cc: 40032
I'll investigate further and amend the patch
On Thu, Mar 12, 2020 at 7:15 PM Leo Famulari <leo@famulari.name> wrote:
>
> On Thu, Mar 12, 2020 at 02:13:06AM +0100, Vincent Legoll wrote:
> > + #:tests? #f))
>
> Why are the tests skipped? Please, always add a code comment here for
> reviewers.
--
Vincent Legoll
^ permalink raw reply [flat|nested] 9+ messages in thread
* [bug#40032] [PATCH] gnu: Add nvme-cli
2020-03-13 23:14 ` Vincent Legoll
@ 2020-03-15 17:07 ` Vincent Legoll
2020-03-15 17:22 ` Leo Famulari
0 siblings, 1 reply; 9+ messages in thread
From: Vincent Legoll @ 2020-03-15 17:07 UTC (permalink / raw)
To: Leo Famulari; +Cc: 40032
It looks like the tests require the presence of /sys/devices...
Should I just add that explanation as comment ?
On Sat, Mar 14, 2020 at 12:14 AM Vincent Legoll
<vincent.legoll@gmail.com> wrote:
>
> I'll investigate further and amend the patch
>
> On Thu, Mar 12, 2020 at 7:15 PM Leo Famulari <leo@famulari.name> wrote:
> >
> > On Thu, Mar 12, 2020 at 02:13:06AM +0100, Vincent Legoll wrote:
> > > + #:tests? #f))
> >
> > Why are the tests skipped? Please, always add a code comment here for
> > reviewers.
>
>
>
> --
> Vincent Legoll
--
Vincent Legoll
^ permalink raw reply [flat|nested] 9+ messages in thread
* [bug#40032] [PATCH] gnu: Add nvme-cli
2020-03-15 17:07 ` Vincent Legoll
@ 2020-03-15 17:22 ` Leo Famulari
2020-03-15 17:36 ` Vincent Legoll
0 siblings, 1 reply; 9+ messages in thread
From: Leo Famulari @ 2020-03-15 17:22 UTC (permalink / raw)
To: Vincent Legoll; +Cc: 40032
On Sun, Mar 15, 2020 at 06:07:44PM +0100, Vincent Legoll wrote:
> It looks like the tests require the presence of /sys/devices...
>
> Should I just add that explanation as comment ?
Yeah, I would say that they require sysfs, which is not accessible from
the build environment.
One could check with "ls -l /sys" in a build phase, or check the docs:
https://guix.gnu.org/manual/en/html_node/Build-Environment-Setup.html
Can you send a revised patch?
^ permalink raw reply [flat|nested] 9+ messages in thread
* [bug#40032] [PATCH] gnu: Add nvme-cli
2020-03-15 17:22 ` Leo Famulari
@ 2020-03-15 17:36 ` Vincent Legoll
2020-03-15 17:57 ` bug#40032: " Leo Famulari
0 siblings, 1 reply; 9+ messages in thread
From: Vincent Legoll @ 2020-03-15 17:36 UTC (permalink / raw)
To: Leo Famulari; +Cc: 40032
[-- Attachment #1: Type: text/plain, Size: 592 bytes --]
Like the following ?
On Sun, Mar 15, 2020 at 6:22 PM Leo Famulari <leo@famulari.name> wrote:
>
> On Sun, Mar 15, 2020 at 06:07:44PM +0100, Vincent Legoll wrote:
> > It looks like the tests require the presence of /sys/devices...
> >
> > Should I just add that explanation as comment ?
>
> Yeah, I would say that they require sysfs, which is not accessible from
> the build environment.
>
> One could check with "ls -l /sys" in a build phase, or check the docs:
>
> https://guix.gnu.org/manual/en/html_node/Build-Environment-Setup.html
>
> Can you send a revised patch?
--
Vincent Legoll
[-- Attachment #2: 0001-gnu-Add-nvme-cli.patch --]
[-- Type: text/x-patch, Size: 2078 bytes --]
From 4f794f64ca5438773fc9980bbf0cf5739144dc87 Mon Sep 17 00:00:00 2001
From: Vincent Legoll <vincent.legoll@gmail.com>
Date: Thu, 12 Mar 2020 01:51:12 +0100
Subject: [PATCH] gnu: Add nvme-cli
* gnu/packages/linux.scm (nvme-cli): New variable.
---
gnu/packages/linux.scm | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 688d9eefaf..e8cc01d288 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -3577,6 +3577,36 @@ IDE driver subsystem. Many external USB drive enclosures with SCSI-ATA Command
Translation (@dfn{SAT}) are also supported.")
(license (license:non-copyleft "file://LICENSE.TXT"))))
+(define-public nvme-cli
+ (package
+ (name "nvme-cli")
+ (version "1.10.1")
+ (home-page "https://github.com/linux-nvme/nvme-cli")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url home-page)
+ (commit (string-append "v" version))))
+ (sha256
+ (base32 "12wp2wxmsw2v8m9bhvwvdbhdgx1md8iilhbl19sfzz2araiwi2x8"))
+ (file-name (git-file-name name version))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:make-flags (list "CC=gcc")
+ #:phases (modify-phases %standard-phases
+ (delete 'configure)
+ (replace 'install
+ (lambda _
+ (zero? (system* "make" "install-spec" "PREFIX="
+ (string-append "DESTDIR=" %output))))))
+ #:tests? #f)) ; The tests require sysfs, which is not accessible from
+ ; the build environment
+ (synopsis "NVM-Express user space tooling for Linux")
+ (description "Utility to provide standards compliant tooling for NVM-Express
+drives. It was made specifically for Linux as it relies on the IOCTLs defined
+by the mainline kernel driver.")
+ (license license:gpl2+)))
+
(define-public rfkill
(package
(name "rfkill")
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* bug#40032: [PATCH] gnu: Add nvme-cli
2020-03-15 17:36 ` Vincent Legoll
@ 2020-03-15 17:57 ` Leo Famulari
2020-03-15 18:10 ` [bug#40032] " Vincent Legoll
0 siblings, 1 reply; 9+ messages in thread
From: Leo Famulari @ 2020-03-15 17:57 UTC (permalink / raw)
To: Vincent Legoll; +Cc: 40032-done
On Sun, Mar 15, 2020 at 06:36:54PM +0100, Vincent Legoll wrote:
> From 4f794f64ca5438773fc9980bbf0cf5739144dc87 Mon Sep 17 00:00:00 2001
> From: Vincent Legoll <vincent.legoll@gmail.com>
> Date: Thu, 12 Mar 2020 01:51:12 +0100
> Subject: [PATCH] gnu: Add nvme-cli
>
> * gnu/packages/linux.scm (nvme-cli): New variable.
Thanks! Pushed as 323841bda4e5b8f9b30626ab768aaf711ee6aabf with the
following changes that I somehow forgot to mention. There was no need to
make you revise the patch again...
> + #:phases (modify-phases %standard-phases
> + (delete 'configure)
I added a comment about why the phase is deleted.
> + (replace 'install
> + (lambda _
> + (zero? (system* "make" "install-spec" "PREFIX="
> + (string-append "DESTDIR=" %output))))))
I replaced (zero? (system* ...)) with (invoke ...), which raises
exceptions on failure rather than returning a boolean #f. This is "the
Guix way" for a while now:
https://lists.gnu.org/archive/html/guix-devel/2017-12/msg00278.html
> + (description "Utility to provide standards compliant tooling for NVM-Express
> +drives. It was made specifically for Linux as it relies on the IOCTLs defined
And I made this first sentence into a complete sentence.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [bug#40032] [PATCH] gnu: Add nvme-cli
2020-03-15 17:57 ` bug#40032: " Leo Famulari
@ 2020-03-15 18:10 ` Vincent Legoll
2020-03-15 18:21 ` Leo Famulari
0 siblings, 1 reply; 9+ messages in thread
From: Vincent Legoll @ 2020-03-15 18:10 UTC (permalink / raw)
To: Leo Famulari; +Cc: 40032-done
Thanks for all the fixes, I'll try to get better at doing that myself...
On Sun, Mar 15, 2020 at 6:57 PM Leo Famulari <leo@famulari.name> wrote:
>
> On Sun, Mar 15, 2020 at 06:36:54PM +0100, Vincent Legoll wrote:
> > From 4f794f64ca5438773fc9980bbf0cf5739144dc87 Mon Sep 17 00:00:00 2001
> > From: Vincent Legoll <vincent.legoll@gmail.com>
> > Date: Thu, 12 Mar 2020 01:51:12 +0100
> > Subject: [PATCH] gnu: Add nvme-cli
> >
> > * gnu/packages/linux.scm (nvme-cli): New variable.
>
> Thanks! Pushed as 323841bda4e5b8f9b30626ab768aaf711ee6aabf with the
> following changes that I somehow forgot to mention. There was no need to
> make you revise the patch again...
>
> > + #:phases (modify-phases %standard-phases
> > + (delete 'configure)
>
> I added a comment about why the phase is deleted.
>
> > + (replace 'install
> > + (lambda _
> > + (zero? (system* "make" "install-spec" "PREFIX="
> > + (string-append "DESTDIR=" %output))))))
>
> I replaced (zero? (system* ...)) with (invoke ...), which raises
> exceptions on failure rather than returning a boolean #f. This is "the
> Guix way" for a while now:
>
> https://lists.gnu.org/archive/html/guix-devel/2017-12/msg00278.html
>
> > + (description "Utility to provide standards compliant tooling for NVM-Express
> > +drives. It was made specifically for Linux as it relies on the IOCTLs defined
>
> And I made this first sentence into a complete sentence.
--
Vincent Legoll
^ permalink raw reply [flat|nested] 9+ messages in thread
* [bug#40032] [PATCH] gnu: Add nvme-cli
2020-03-15 18:10 ` [bug#40032] " Vincent Legoll
@ 2020-03-15 18:21 ` Leo Famulari
0 siblings, 0 replies; 9+ messages in thread
From: Leo Famulari @ 2020-03-15 18:21 UTC (permalink / raw)
To: Vincent Legoll; +Cc: 40032-done
On Sun, Mar 15, 2020 at 07:10:18PM +0100, Vincent Legoll wrote:
> Thanks for all the fixes, I'll try to get better at doing that myself...
No worries! We're glad to have your patches :)
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-03-15 18:22 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-12 1:13 [bug#40032] [PATCH] gnu: Add nvme-cli Vincent Legoll
2020-03-12 18:15 ` Leo Famulari
2020-03-13 23:14 ` Vincent Legoll
2020-03-15 17:07 ` Vincent Legoll
2020-03-15 17:22 ` Leo Famulari
2020-03-15 17:36 ` Vincent Legoll
2020-03-15 17:57 ` bug#40032: " Leo Famulari
2020-03-15 18:10 ` [bug#40032] " Vincent Legoll
2020-03-15 18:21 ` Leo Famulari
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.