From: Vincent Legoll <vincent.legoll@gmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: 40032@debbugs.gnu.org
Subject: [bug#40032] [PATCH] gnu: Add nvme-cli
Date: Sun, 15 Mar 2020 18:07:44 +0100 [thread overview]
Message-ID: <CAEwRq=pMDGyhQvOBMex6PXYx+2W71kZGHGx3p_v=26APXbtw8w@mail.gmail.com> (raw)
In-Reply-To: <CAEwRq=qtHYZ7wXT-TWfZLh837mGMb+cCgjbKOrPagdsq5-r8MQ@mail.gmail.com>
It looks like the tests require the presence of /sys/devices...
Should I just add that explanation as comment ?
On Sat, Mar 14, 2020 at 12:14 AM Vincent Legoll
<vincent.legoll@gmail.com> wrote:
>
> I'll investigate further and amend the patch
>
> On Thu, Mar 12, 2020 at 7:15 PM Leo Famulari <leo@famulari.name> wrote:
> >
> > On Thu, Mar 12, 2020 at 02:13:06AM +0100, Vincent Legoll wrote:
> > > + #:tests? #f))
> >
> > Why are the tests skipped? Please, always add a code comment here for
> > reviewers.
>
>
>
> --
> Vincent Legoll
--
Vincent Legoll
next prev parent reply other threads:[~2020-03-15 17:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 1:13 [bug#40032] [PATCH] gnu: Add nvme-cli Vincent Legoll
2020-03-12 18:15 ` Leo Famulari
2020-03-13 23:14 ` Vincent Legoll
2020-03-15 17:07 ` Vincent Legoll [this message]
2020-03-15 17:22 ` Leo Famulari
2020-03-15 17:36 ` Vincent Legoll
2020-03-15 17:57 ` bug#40032: " Leo Famulari
2020-03-15 18:10 ` [bug#40032] " Vincent Legoll
2020-03-15 18:21 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEwRq=pMDGyhQvOBMex6PXYx+2W71kZGHGx3p_v=26APXbtw8w@mail.gmail.com' \
--to=vincent.legoll@gmail.com \
--cc=40032@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.