From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:55789) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDXj5-0004gH-My for guix-patches@gnu.org; Sun, 15 Mar 2020 14:11:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDXj4-0006Et-Eu for guix-patches@gnu.org; Sun, 15 Mar 2020 14:11:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57758) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jDXj4-0006CV-AR for guix-patches@gnu.org; Sun, 15 Mar 2020 14:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jDXj4-0003g0-4O for guix-patches@gnu.org; Sun, 15 Mar 2020 14:11:02 -0400 Subject: [bug#40032] [PATCH] gnu: Add nvme-cli Resent-Message-ID: MIME-Version: 1.0 References: <20200312181513.GA8595@jasmine.lan> <20200315172242.GA26892@jasmine.lan> <20200315175722.GE26892@jasmine.lan> In-Reply-To: <20200315175722.GE26892@jasmine.lan> From: Vincent Legoll Date: Sun, 15 Mar 2020 19:10:18 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 40032-done@debbugs.gnu.org Thanks for all the fixes, I'll try to get better at doing that myself... On Sun, Mar 15, 2020 at 6:57 PM Leo Famulari wrote: > > On Sun, Mar 15, 2020 at 06:36:54PM +0100, Vincent Legoll wrote: > > From 4f794f64ca5438773fc9980bbf0cf5739144dc87 Mon Sep 17 00:00:00 2001 > > From: Vincent Legoll > > Date: Thu, 12 Mar 2020 01:51:12 +0100 > > Subject: [PATCH] gnu: Add nvme-cli > > > > * gnu/packages/linux.scm (nvme-cli): New variable. > > Thanks! Pushed as 323841bda4e5b8f9b30626ab768aaf711ee6aabf with the > following changes that I somehow forgot to mention. There was no need to > make you revise the patch again... > > > + #:phases (modify-phases %standard-phases > > + (delete 'configure) > > I added a comment about why the phase is deleted. > > > + (replace 'install > > + (lambda _ > > + (zero? (system* "make" "install-spec" "PREFIX=" > > + (string-append "DESTDIR=" %output)))))) > > I replaced (zero? (system* ...)) with (invoke ...), which raises > exceptions on failure rather than returning a boolean #f. This is "the > Guix way" for a while now: > > https://lists.gnu.org/archive/html/guix-devel/2017-12/msg00278.html > > > + (description "Utility to provide standards compliant tooling for NVM-Express > > +drives. It was made specifically for Linux as it relies on the IOCTLs defined > > And I made this first sentence into a complete sentence. -- Vincent Legoll