[bug#61906] [PATCH] Replaced Pumpa origin (https://issues.guix.gnu.org/52257)

[bug#61906] [PATCH] Replaced Pumpa origin (https://issues.guix.gnu.org/52257)

[Sarthak Shah]

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

---
 gnu/packages/pumpio.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/pumpio.scm b/gnu/packages/pumpio.scm
index 2f4dd359d1..0c27041f5b 100644
--- a/gnu/packages/pumpio.scm
+++ b/gnu/packages/pumpio.scm
@@ -35,7 +35,7 @@ (define-public pumpa
     (source (origin
               (method git-fetch) ; no source tarballs
               (uri (git-reference
-                    (url "git://pumpa.branchable.com/")
+                    (url "https://source.pumpa.branchable.com/")
                     (commit (string-append "v" version))))
               (sha256
                (base32

base-commit: 7dc190f83ed29ca7e556700de13a3101e73ec745
-- 
2.39.1

[-- Attachment #2: Type: text/html, Size: 967 bytes --]

[bug#61906] [PATCH] Replaced Pumpa origin (https://issues.guix.gnu.org/52257)

[Simon Tournier]

Hi,

I miss a commit message which respects ChangeLog format; as documented
by the section ’(guix) Submitting Patches’ of the manual.  Please take
inspiration with other commits. :-)

Cheers,
simon

[bug#61906] [PATCH] Revised patch that respects changelog format

[Sarthak Shah]

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

* gnu/packages/pumio.scm (pumpa): Replace pumpa origin
---
 gnu/packages/pumpio.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/pumpio.scm b/gnu/packages/pumpio.scm
index 2f4dd359d1..0c27041f5b 100644
--- a/gnu/packages/pumpio.scm
+++ b/gnu/packages/pumpio.scm
@@ -35,7 +35,7 @@ (define-public pumpa
     (source (origin
               (method git-fetch) ; no source tarballs
               (uri (git-reference
-                    (url "git://pumpa.branchable.com/")
+                    (url "https://source.pumpa.branchable.com/")
                     (commit (string-append "v" version))))
               (sha256
                (base32

base-commit: 7dc190f83ed29ca7e556700de13a3101e73ec745
--

[-- Attachment #2: Type: text/html, Size: 1075 bytes --]

[bug#61906] [PATCH v3] gnu: pumpa: Update upsream URL.

[Simon Tournier]

From: Sarthak Shah <shahsarthakw@gmail.com>

Fixes <http://issues.guix.gnu.org/issue/52257>.

* gnu/packages/pumio.scm (pumpa)[source]: Replace pumpa origin.
---
 gnu/packages/pumpio.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/pumpio.scm b/gnu/packages/pumpio.scm
index 5fb6e338e8..dc5e1ec7bb 100644
--- a/gnu/packages/pumpio.scm
+++ b/gnu/packages/pumpio.scm
@@ -35,7 +35,7 @@ (define-public pumpa
     (source (origin
               (method git-fetch) ; no source tarballs
               (uri (git-reference
-                    (url "git://pumpa.branchable.com/")
+                    (url "https://source.pumpa.branchable.com/")
                     (commit (string-append "v" version))))
               (sha256
                (base32

base-commit: 203578eef286f3b44cd82fd2eb965a828e21fbe7
-- 
2.38.1

[bug#61906] [PATCH] Revised patch that respects changelog format

[Simon Tournier]

Hi,

Please see v3 for nitpicking. :-)  But since it is a more than trivial
patch, the only interesting part is the nitpicking part.


1. Since the Subject line is the Commit headline, it must also respect
   the format.  When modifying a package, it is:

      gnu: packag-name: One line summarizing the change.

On Wed, 08 Mar 2023 at 23:49, Sarthak Shah <shahsarthakw@gmail.com> wrote:

> * gnu/packages/pumio.scm (pumpa): Replace pumpa origin

2. The ChangeLog format ends with a period.          --^


Cheers,
simon

[bug#61906] [PATCH] Revised patch that respects changelog format

[Sarthak Shah]

[-- Attachment #1: Type: text/plain, Size: 832 bytes --]

Got it, thank you for your patience.
I guess it won't be necessary as you have already sent a corrected patch,
but should I resend my commit with the required fixes?

On Thu, Mar 9, 2023 at 3:32 PM Simon Tournier <zimon.toutoune@gmail.com>
wrote:

> Hi,
>
> Please see v3 for nitpicking. :-)  But since it is a more than trivial
> patch, the only interesting part is the nitpicking part.
>
>
> 1. Since the Subject line is the Commit headline, it must also respect
>    the format.  When modifying a package, it is:
>
>       gnu: packag-name: One line summarizing the change.
>
> On Wed, 08 Mar 2023 at 23:49, Sarthak Shah <shahsarthakw@gmail.com> wrote:
>
> > * gnu/packages/pumio.scm (pumpa): Replace pumpa origin
>
> 2. The ChangeLog format ends with a period.          --^
>
>
> Cheers,
> simon
>

[-- Attachment #2: Type: text/html, Size: 1243 bytes --]

bug#61906: [PATCH] Replaced Pumpa origin (https://issues.guix.gnu.org/52257)

[Ludovic Courtès]

Hi,

Simon Tournier <zimon.toutoune@gmail.com> skribis:

> From: Sarthak Shah <shahsarthakw@gmail.com>
>
> Fixes <http://issues.guix.gnu.org/issue/52257>.
>
> * gnu/packages/pumio.scm (pumpa)[source]: Replace pumpa origin.

Applied, thanks to the two of you!

Ludo’.