* [bug#61906] [PATCH] Replaced Pumpa origin (https://issues.guix.gnu.org/52257)
@ 2023-03-02 2:29 Sarthak Shah
2023-03-08 17:19 ` Simon Tournier
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Sarthak Shah @ 2023-03-02 2:29 UTC (permalink / raw)
To: 61906
[-- Attachment #1: Type: text/plain, Size: 689 bytes --]
---
gnu/packages/pumpio.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/pumpio.scm b/gnu/packages/pumpio.scm
index 2f4dd359d1..0c27041f5b 100644
--- a/gnu/packages/pumpio.scm
+++ b/gnu/packages/pumpio.scm
@@ -35,7 +35,7 @@ (define-public pumpa
(source (origin
(method git-fetch) ; no source tarballs
(uri (git-reference
- (url "git://pumpa.branchable.com/")
+ (url "https://source.pumpa.branchable.com/")
(commit (string-append "v" version))))
(sha256
(base32
base-commit: 7dc190f83ed29ca7e556700de13a3101e73ec745
--
2.39.1
[-- Attachment #2: Type: text/html, Size: 967 bytes --]
^ permalink raw reply related [flat|nested] 7+ messages in thread* [bug#61906] [PATCH] Replaced Pumpa origin (https://issues.guix.gnu.org/52257)
2023-03-02 2:29 [bug#61906] [PATCH] Replaced Pumpa origin (https://issues.guix.gnu.org/52257) Sarthak Shah
@ 2023-03-08 17:19 ` Simon Tournier
2023-03-08 18:19 ` [bug#61906] [PATCH] Revised patch that respects changelog format Sarthak Shah
2023-03-09 9:57 ` [bug#61906] [PATCH v3] gnu: pumpa: Update upsream URL Simon Tournier
2 siblings, 0 replies; 7+ messages in thread
From: Simon Tournier @ 2023-03-08 17:19 UTC (permalink / raw)
To: Sarthak Shah, 61906
Hi,
I miss a commit message which respects ChangeLog format; as documented
by the section ’(guix) Submitting Patches’ of the manual. Please take
inspiration with other commits. :-)
Cheers,
simon
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#61906] [PATCH] Revised patch that respects changelog format
2023-03-02 2:29 [bug#61906] [PATCH] Replaced Pumpa origin (https://issues.guix.gnu.org/52257) Sarthak Shah
2023-03-08 17:19 ` Simon Tournier
@ 2023-03-08 18:19 ` Sarthak Shah
2023-03-09 10:02 ` Simon Tournier
2023-03-09 9:57 ` [bug#61906] [PATCH v3] gnu: pumpa: Update upsream URL Simon Tournier
2 siblings, 1 reply; 7+ messages in thread
From: Sarthak Shah @ 2023-03-08 18:19 UTC (permalink / raw)
To: 61906
[-- Attachment #1: Type: text/plain, Size: 736 bytes --]
* gnu/packages/pumio.scm (pumpa): Replace pumpa origin
---
gnu/packages/pumpio.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/pumpio.scm b/gnu/packages/pumpio.scm
index 2f4dd359d1..0c27041f5b 100644
--- a/gnu/packages/pumpio.scm
+++ b/gnu/packages/pumpio.scm
@@ -35,7 +35,7 @@ (define-public pumpa
(source (origin
(method git-fetch) ; no source tarballs
(uri (git-reference
- (url "git://pumpa.branchable.com/")
+ (url "https://source.pumpa.branchable.com/")
(commit (string-append "v" version))))
(sha256
(base32
base-commit: 7dc190f83ed29ca7e556700de13a3101e73ec745
--
[-- Attachment #2: Type: text/html, Size: 1075 bytes --]
^ permalink raw reply related [flat|nested] 7+ messages in thread* [bug#61906] [PATCH] Revised patch that respects changelog format
2023-03-08 18:19 ` [bug#61906] [PATCH] Revised patch that respects changelog format Sarthak Shah
@ 2023-03-09 10:02 ` Simon Tournier
2023-03-09 11:14 ` Sarthak Shah
0 siblings, 1 reply; 7+ messages in thread
From: Simon Tournier @ 2023-03-09 10:02 UTC (permalink / raw)
To: Sarthak Shah, 61906
Hi,
Please see v3 for nitpicking. :-) But since it is a more than trivial
patch, the only interesting part is the nitpicking part.
1. Since the Subject line is the Commit headline, it must also respect
the format. When modifying a package, it is:
gnu: packag-name: One line summarizing the change.
On Wed, 08 Mar 2023 at 23:49, Sarthak Shah <shahsarthakw@gmail.com> wrote:
> * gnu/packages/pumio.scm (pumpa): Replace pumpa origin
2. The ChangeLog format ends with a period. --^
Cheers,
simon
^ permalink raw reply [flat|nested] 7+ messages in thread* [bug#61906] [PATCH] Revised patch that respects changelog format
2023-03-09 10:02 ` Simon Tournier
@ 2023-03-09 11:14 ` Sarthak Shah
0 siblings, 0 replies; 7+ messages in thread
From: Sarthak Shah @ 2023-03-09 11:14 UTC (permalink / raw)
To: Simon Tournier; +Cc: 61906
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
Got it, thank you for your patience.
I guess it won't be necessary as you have already sent a corrected patch,
but should I resend my commit with the required fixes?
On Thu, Mar 9, 2023 at 3:32 PM Simon Tournier <zimon.toutoune@gmail.com>
wrote:
> Hi,
>
> Please see v3 for nitpicking. :-) But since it is a more than trivial
> patch, the only interesting part is the nitpicking part.
>
>
> 1. Since the Subject line is the Commit headline, it must also respect
> the format. When modifying a package, it is:
>
> gnu: packag-name: One line summarizing the change.
>
> On Wed, 08 Mar 2023 at 23:49, Sarthak Shah <shahsarthakw@gmail.com> wrote:
>
> > * gnu/packages/pumio.scm (pumpa): Replace pumpa origin
>
> 2. The ChangeLog format ends with a period. --^
>
>
> Cheers,
> simon
>
[-- Attachment #2: Type: text/html, Size: 1243 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#61906] [PATCH v3] gnu: pumpa: Update upsream URL.
2023-03-02 2:29 [bug#61906] [PATCH] Replaced Pumpa origin (https://issues.guix.gnu.org/52257) Sarthak Shah
2023-03-08 17:19 ` Simon Tournier
2023-03-08 18:19 ` [bug#61906] [PATCH] Revised patch that respects changelog format Sarthak Shah
@ 2023-03-09 9:57 ` Simon Tournier
2023-03-13 13:49 ` bug#61906: [PATCH] Replaced Pumpa origin (https://issues.guix.gnu.org/52257) Ludovic Courtès
2 siblings, 1 reply; 7+ messages in thread
From: Simon Tournier @ 2023-03-09 9:57 UTC (permalink / raw)
To: 61906; +Cc: shahsarthakw
From: Sarthak Shah <shahsarthakw@gmail.com>
Fixes <http://issues.guix.gnu.org/issue/52257>.
* gnu/packages/pumio.scm (pumpa)[source]: Replace pumpa origin.
---
gnu/packages/pumpio.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/pumpio.scm b/gnu/packages/pumpio.scm
index 5fb6e338e8..dc5e1ec7bb 100644
--- a/gnu/packages/pumpio.scm
+++ b/gnu/packages/pumpio.scm
@@ -35,7 +35,7 @@ (define-public pumpa
(source (origin
(method git-fetch) ; no source tarballs
(uri (git-reference
- (url "git://pumpa.branchable.com/")
+ (url "https://source.pumpa.branchable.com/")
(commit (string-append "v" version))))
(sha256
(base32
base-commit: 203578eef286f3b44cd82fd2eb965a828e21fbe7
--
2.38.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-03-13 13:51 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-02 2:29 [bug#61906] [PATCH] Replaced Pumpa origin (https://issues.guix.gnu.org/52257) Sarthak Shah
2023-03-08 17:19 ` Simon Tournier
2023-03-08 18:19 ` [bug#61906] [PATCH] Revised patch that respects changelog format Sarthak Shah
2023-03-09 10:02 ` Simon Tournier
2023-03-09 11:14 ` Sarthak Shah
2023-03-09 9:57 ` [bug#61906] [PATCH v3] gnu: pumpa: Update upsream URL Simon Tournier
2023-03-13 13:49 ` bug#61906: [PATCH] Replaced Pumpa origin (https://issues.guix.gnu.org/52257) Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.