all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Simon Tournier <zimon.toutoune@gmail.com>
To: Sarthak Shah <shahsarthakw@gmail.com>, 61906@debbugs.gnu.org
Subject: [bug#61906] [PATCH] Revised patch that respects changelog format
Date: Thu, 09 Mar 2023 11:02:25 +0100	[thread overview]
Message-ID: <86fsaensy6.fsf@gmail.com> (raw)
In-Reply-To: <CADBZEVkJQars83HDvWpHxy4HCTipQJu+KqDckALUGJr5GkMn7Q@mail.gmail.com>

Hi,

Please see v3 for nitpicking. :-)  But since it is a more than trivial
patch, the only interesting part is the nitpicking part.


1. Since the Subject line is the Commit headline, it must also respect
   the format.  When modifying a package, it is:

      gnu: packag-name: One line summarizing the change.

On Wed, 08 Mar 2023 at 23:49, Sarthak Shah <shahsarthakw@gmail.com> wrote:

> * gnu/packages/pumio.scm (pumpa): Replace pumpa origin

2. The ChangeLog format ends with a period.          --^


Cheers,
simon




  reply	other threads:[~2023-03-09 10:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-02  2:29 [bug#61906] [PATCH] Replaced Pumpa origin (https://issues.guix.gnu.org/52257) Sarthak Shah
2023-03-08 17:19 ` Simon Tournier
2023-03-08 18:19 ` [bug#61906] [PATCH] Revised patch that respects changelog format Sarthak Shah
2023-03-09 10:02   ` Simon Tournier [this message]
2023-03-09 11:14     ` Sarthak Shah
2023-03-09  9:57 ` [bug#61906] [PATCH v3] gnu: pumpa: Update upsream URL Simon Tournier
2023-03-13 13:49   ` bug#61906: [PATCH] Replaced Pumpa origin (https://issues.guix.gnu.org/52257) Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86fsaensy6.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=61906@debbugs.gnu.org \
    --cc=shahsarthakw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.