* [bug#64155] [PATCH] gnu: emacs-piem: Update to 0.5.0. @ 2023-06-18 19:38 jlicht 2023-06-19 13:44 ` Andrew Tropin 2023-06-19 19:35 ` [bug#64155] [PATCH v2 1/2] gnu: emacs-piem: Do not propagate any inputs jlicht 0 siblings, 2 replies; 9+ messages in thread From: jlicht @ 2023-06-18 19:38 UTC (permalink / raw) To: 64155; +Cc: Jelle Licht, Andrew Tropin, Liliana Marie Prikler From: Jelle Licht <jlicht@fsfe.org> * gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0. [propagated-inputs]: Add emacs-debbugs. --- gnu/packages/emacs-xyz.scm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index f46af73aec..08ec87b94c 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -8337,7 +8337,7 @@ (define-public emacs-debbugs (define-public emacs-piem (package (name "emacs-piem") - (version "0.4.0") + (version "0.5.0") (source (origin (method git-fetch) @@ -8346,7 +8346,7 @@ (define-public emacs-piem (commit (string-append "v" version)))) (file-name (string-append name "-" version "-checkout")) (sha256 - (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z")))) + (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q")))) (build-system emacs-build-system) (arguments (list #:phases @@ -8359,7 +8359,8 @@ (define-public emacs-piem (inputs (list b4)) (propagated-inputs - (list emacs-elfeed + (list emacs-debbugs + emacs-elfeed emacs-notmuch)) (home-page "https://docs.kyleam.com/piem") (synopsis "Glue for working with public-inbox archives") base-commit: 726f2a944730a1edbdbebfe57fb9e7e0ba47d83e -- 2.40.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [bug#64155] [PATCH] gnu: emacs-piem: Update to 0.5.0. 2023-06-18 19:38 [bug#64155] [PATCH] gnu: emacs-piem: Update to 0.5.0 jlicht @ 2023-06-19 13:44 ` Andrew Tropin 2023-06-19 15:39 ` Jelle Licht 2023-06-19 18:24 ` Liliana Marie Prikler 2023-06-19 19:35 ` [bug#64155] [PATCH v2 1/2] gnu: emacs-piem: Do not propagate any inputs jlicht 1 sibling, 2 replies; 9+ messages in thread From: Andrew Tropin @ 2023-06-19 13:44 UTC (permalink / raw) To: jlicht, 64155; +Cc: Jelle Licht, Liliana Marie Prikler [-- Attachment #1: Type: text/plain, Size: 2005 bytes --] On 2023-06-18 21:38, jlicht@fsfe.org wrote: > From: Jelle Licht <jlicht@fsfe.org> > > * gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0. > [propagated-inputs]: Add emacs-debbugs. > --- > > gnu/packages/emacs-xyz.scm | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index f46af73aec..08ec87b94c 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -8337,7 +8337,7 @@ (define-public emacs-debbugs > (define-public emacs-piem > (package > (name "emacs-piem") > - (version "0.4.0") > + (version "0.5.0") > (source > (origin > (method git-fetch) > @@ -8346,7 +8346,7 @@ (define-public emacs-piem > (commit (string-append "v" version)))) > (file-name (string-append name "-" version "-checkout")) > (sha256 > - (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z")))) > + (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q")))) > (build-system emacs-build-system) > (arguments > (list #:phases > @@ -8359,7 +8359,8 @@ (define-public emacs-piem > (inputs > (list b4)) > (propagated-inputs > - (list emacs-elfeed > + (list emacs-debbugs > + emacs-elfeed > emacs-notmuch)) > (home-page "https://docs.kyleam.com/piem") > (synopsis "Glue for working with public-inbox archives") > > base-commit: 726f2a944730a1edbdbebfe57fb9e7e0ba47d83e Hi Jelle! Thank you very much for the patch. IMHO, optional dependencies should not be propagated. On user side installing additional packages is easier than transforming existing package and removing unneeded propagated deps. Personally, I would remove all the propagated inputs from piem and let the user install what he needs for his particular use case. Liliana, Jelle WDYT? -- Best regards, Andrew Tropin [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* [bug#64155] [PATCH] gnu: emacs-piem: Update to 0.5.0. 2023-06-19 13:44 ` Andrew Tropin @ 2023-06-19 15:39 ` Jelle Licht 2023-06-19 16:32 ` Andrew Tropin 2023-06-19 18:24 ` Liliana Marie Prikler 1 sibling, 1 reply; 9+ messages in thread From: Jelle Licht @ 2023-06-19 15:39 UTC (permalink / raw) To: Andrew Tropin, 64155; +Cc: Liliana Marie Prikler Hi Andrew + peanut gallery, Andrew Tropin <andrew@trop.in> writes: > On 2023-06-18 21:38, jlicht@fsfe.org wrote: > >> From: Jelle Licht <jlicht@fsfe.org> >> >> * gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0. >> [propagated-inputs]: Add emacs-debbugs. >> --- >> >> gnu/packages/emacs-xyz.scm | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm >> index f46af73aec..08ec87b94c 100644 >> --- a/gnu/packages/emacs-xyz.scm >> +++ b/gnu/packages/emacs-xyz.scm >> @@ -8337,7 +8337,7 @@ (define-public emacs-debbugs >> (define-public emacs-piem >> (package >> (name "emacs-piem") >> - (version "0.4.0") >> + (version "0.5.0") >> (source >> (origin >> (method git-fetch) >> @@ -8346,7 +8346,7 @@ (define-public emacs-piem >> (commit (string-append "v" version)))) >> (file-name (string-append name "-" version "-checkout")) >> (sha256 >> - (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z")))) >> + (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q")))) >> (build-system emacs-build-system) >> (arguments >> (list #:phases >> @@ -8359,7 +8359,8 @@ (define-public emacs-piem >> (inputs >> (list b4)) >> (propagated-inputs >> - (list emacs-elfeed >> + (list emacs-debbugs >> + emacs-elfeed >> emacs-notmuch)) >> (home-page "https://docs.kyleam.com/piem") >> (synopsis "Glue for working with public-inbox archives") >> >> base-commit: 726f2a944730a1edbdbebfe57fb9e7e0ba47d83e > > Hi Jelle! > > Thank you very much for the patch. > > IMHO, optional dependencies should not be propagated. On user side > installing additional packages is easier than transforming existing > package and removing unneeded propagated deps. Personally, I would > remove all the propagated inputs from piem and let the user install what > he needs for his particular use case. I'm of two minds, both for this particular patch, and the policy in general. I understand the point you are making, and see the elegance of offering a clean set of composable parts for users (and downstream) to compose. OTOH, it makes getting full-featured (and compiled) packages a chore, where users or downstream has to pick up the slack. Put another way; someone somewhere has to make a package variant if you want to cover all use cases. It is my understanding the guideline is (/was?) to have packages be full-featured, and offer a '-minimal' version in cases where it makes sense (e.g. bootstrapping, less-than-sane dependency graphs). If this guideline has since changed, or (in this case) the Emacs teams decides otherwise, that is something I'm obviously fine with. Some practical tips on how to make byte compilation happen would still be appreciated in that case :-). All the best, - Jelle ^ permalink raw reply [flat|nested] 9+ messages in thread
* [bug#64155] [PATCH] gnu: emacs-piem: Update to 0.5.0. 2023-06-19 15:39 ` Jelle Licht @ 2023-06-19 16:32 ` Andrew Tropin 0 siblings, 0 replies; 9+ messages in thread From: Andrew Tropin @ 2023-06-19 16:32 UTC (permalink / raw) To: Jelle Licht, 64155; +Cc: Liliana Marie Prikler [-- Attachment #1: Type: text/plain, Size: 3293 bytes --] On 2023-06-19 17:39, Jelle Licht wrote: > Hi Andrew + peanut gallery, > > Andrew Tropin <andrew@trop.in> writes: > >> On 2023-06-18 21:38, jlicht@fsfe.org wrote: >> >>> From: Jelle Licht <jlicht@fsfe.org> >>> >>> * gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0. >>> [propagated-inputs]: Add emacs-debbugs. >>> --- >>> >>> gnu/packages/emacs-xyz.scm | 7 ++++--- >>> 1 file changed, 4 insertions(+), 3 deletions(-) >>> >>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm >>> index f46af73aec..08ec87b94c 100644 >>> --- a/gnu/packages/emacs-xyz.scm >>> +++ b/gnu/packages/emacs-xyz.scm >>> @@ -8337,7 +8337,7 @@ (define-public emacs-debbugs >>> (define-public emacs-piem >>> (package >>> (name "emacs-piem") >>> - (version "0.4.0") >>> + (version "0.5.0") >>> (source >>> (origin >>> (method git-fetch) >>> @@ -8346,7 +8346,7 @@ (define-public emacs-piem >>> (commit (string-append "v" version)))) >>> (file-name (string-append name "-" version "-checkout")) >>> (sha256 >>> - (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z")))) >>> + (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q")))) >>> (build-system emacs-build-system) >>> (arguments >>> (list #:phases >>> @@ -8359,7 +8359,8 @@ (define-public emacs-piem >>> (inputs >>> (list b4)) >>> (propagated-inputs >>> - (list emacs-elfeed >>> + (list emacs-debbugs >>> + emacs-elfeed >>> emacs-notmuch)) >>> (home-page "https://docs.kyleam.com/piem") >>> (synopsis "Glue for working with public-inbox archives") >>> >>> base-commit: 726f2a944730a1edbdbebfe57fb9e7e0ba47d83e >> >> Hi Jelle! >> >> Thank you very much for the patch. >> >> IMHO, optional dependencies should not be propagated. On user side >> installing additional packages is easier than transforming existing >> package and removing unneeded propagated deps. Personally, I would >> remove all the propagated inputs from piem and let the user install what >> he needs for his particular use case. > > I'm of two minds, both for this particular patch, and the policy in > general. I understand the point you are making, and see the elegance of > offering a clean set of composable parts for users (and downstream) to > compose. > > OTOH, it makes getting full-featured (and compiled) packages a chore, > where users or downstream has to pick up the slack. Put another > way; someone somewhere has to make a package variant if you want to > cover all use cases. > > It is my understanding the guideline is (/was?) to have packages be > full-featured, and offer a '-minimal' version in cases where it makes > sense (e.g. bootstrapping, less-than-sane dependency graphs). If this > guideline has since changed, or (in this case) the Emacs teams decides > otherwise, that is something I'm obviously fine with. Some practical > tips on how to make byte compilation happen would still be appreciated > in that case :-). I think we can do byte/native compilation without propagating deps, so it's almost ready to consume, but doesn't pollute the profile. -- Best regards, Andrew Tropin [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* [bug#64155] [PATCH] gnu: emacs-piem: Update to 0.5.0. 2023-06-19 13:44 ` Andrew Tropin 2023-06-19 15:39 ` Jelle Licht @ 2023-06-19 18:24 ` Liliana Marie Prikler 1 sibling, 0 replies; 9+ messages in thread From: Liliana Marie Prikler @ 2023-06-19 18:24 UTC (permalink / raw) To: Andrew Tropin, jlicht, 64155 Am Montag, dem 19.06.2023 um 17:44 +0400 schrieb Andrew Tropin: > Hi Jelle! > > Thank you very much for the patch. > > IMHO, optional dependencies should not be propagated. On user side > installing additional packages is easier than transforming existing > package and removing unneeded propagated deps. Personally, I would > remove all the propagated inputs from piem and let the user install > what he needs for his particular use case. > > Liliana, Jelle WDYT? s/he needs/they need/ Other than that, I don't really have an opinion, but at the very least we don't *have* to propagate debbugs, given that users who want to use that probably already have it. As for why I don't really have an opinion: I don't know how central the existing propagations are towards the working of emacs-piem. That being said, we could always make those inputs regular (which might be helpful for byte/native-compilation). Cheers ^ permalink raw reply [flat|nested] 9+ messages in thread
* [bug#64155] [PATCH v2 1/2] gnu: emacs-piem: Do not propagate any inputs. 2023-06-18 19:38 [bug#64155] [PATCH] gnu: emacs-piem: Update to 0.5.0 jlicht 2023-06-19 13:44 ` Andrew Tropin @ 2023-06-19 19:35 ` jlicht 2023-06-19 19:35 ` [bug#64155] [PATCH v2 2/2] gnu: emacs-piem: Update to 0.5.0 jlicht 1 sibling, 1 reply; 9+ messages in thread From: jlicht @ 2023-06-19 19:35 UTC (permalink / raw) To: 64155 Cc: Jelle Licht, Liliana Marie Prikler, Andrew Tropin, Andrew Tropin, Liliana Marie Prikler From: Jelle Licht <jlicht@fsfe.org> * gnu/packages/emacs-xyz.scm (emacs-piem) [propagated-inputs]: Remove, moving emacs-elfeed and emacs-notmuch to... [inputs]: ...here. --- (no changes since v1) gnu/packages/emacs-xyz.scm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index f46af73aec..416656f243 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -8357,9 +8357,8 @@ (define-public emacs-piem ("piem-b4-b4-executable" (search-input-file inputs "/bin/b4")))))))) (inputs - (list b4)) - (propagated-inputs - (list emacs-elfeed + (list b4 + emacs-elfeed emacs-notmuch)) (home-page "https://docs.kyleam.com/piem") (synopsis "Glue for working with public-inbox archives") base-commit: d884fc9e2efecfba09af4694f5a13ad7fc6f704f -- 2.40.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [bug#64155] [PATCH v2 2/2] gnu: emacs-piem: Update to 0.5.0. 2023-06-19 19:35 ` [bug#64155] [PATCH v2 1/2] gnu: emacs-piem: Do not propagate any inputs jlicht @ 2023-06-19 19:35 ` jlicht 2023-06-20 3:23 ` Andrew Tropin 0 siblings, 1 reply; 9+ messages in thread From: jlicht @ 2023-06-19 19:35 UTC (permalink / raw) To: 64155 Cc: Jelle Licht, Liliana Marie Prikler, Andrew Tropin, Andrew Tropin, Liliana Marie Prikler From: Jelle Licht <jlicht@fsfe.org> * gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0. [inputs]: Add emacs-debbugs. --- (no changes since v1) gnu/packages/emacs-xyz.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 416656f243..08d53be8a9 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -8337,7 +8337,7 @@ (define-public emacs-debbugs (define-public emacs-piem (package (name "emacs-piem") - (version "0.4.0") + (version "0.5.0") (source (origin (method git-fetch) @@ -8346,7 +8346,7 @@ (define-public emacs-piem (commit (string-append "v" version)))) (file-name (string-append name "-" version "-checkout")) (sha256 - (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z")))) + (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q")))) (build-system emacs-build-system) (arguments (list #:phases @@ -8358,6 +8358,7 @@ (define-public emacs-piem (search-input-file inputs "/bin/b4")))))))) (inputs (list b4 + emacs-debbugs emacs-elfeed emacs-notmuch)) (home-page "https://docs.kyleam.com/piem") -- 2.40.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [bug#64155] [PATCH v2 2/2] gnu: emacs-piem: Update to 0.5.0. 2023-06-19 19:35 ` [bug#64155] [PATCH v2 2/2] gnu: emacs-piem: Update to 0.5.0 jlicht @ 2023-06-20 3:23 ` Andrew Tropin 2023-06-20 19:10 ` bug#64155: " Jelle Licht 0 siblings, 1 reply; 9+ messages in thread From: Andrew Tropin @ 2023-06-20 3:23 UTC (permalink / raw) To: jlicht, 64155; +Cc: Jelle Licht, Liliana Marie Prikler [-- Attachment #1: Type: text/plain, Size: 1538 bytes --] On 2023-06-19 21:35, jlicht@fsfe.org wrote: > From: Jelle Licht <jlicht@fsfe.org> > > * gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0. > [inputs]: Add emacs-debbugs. > > --- > > (no changes since v1) > > gnu/packages/emacs-xyz.scm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index 416656f243..08d53be8a9 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -8337,7 +8337,7 @@ (define-public emacs-debbugs > (define-public emacs-piem > (package > (name "emacs-piem") > - (version "0.4.0") > + (version "0.5.0") > (source > (origin > (method git-fetch) > @@ -8346,7 +8346,7 @@ (define-public emacs-piem > (commit (string-append "v" version)))) > (file-name (string-append name "-" version "-checkout")) > (sha256 > - (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z")))) > + (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q")))) > (build-system emacs-build-system) > (arguments > (list #:phases > @@ -8358,6 +8358,7 @@ (define-public emacs-piem > (search-input-file inputs "/bin/b4")))))))) > (inputs > (list b4 > + emacs-debbugs > emacs-elfeed > emacs-notmuch)) > (home-page "https://docs.kyleam.com/piem") It looks good to me! -- Best regards, Andrew Tropin [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#64155: [PATCH v2 2/2] gnu: emacs-piem: Update to 0.5.0. 2023-06-20 3:23 ` Andrew Tropin @ 2023-06-20 19:10 ` Jelle Licht 0 siblings, 0 replies; 9+ messages in thread From: Jelle Licht @ 2023-06-20 19:10 UTC (permalink / raw) To: Andrew Tropin, 64155-done; +Cc: Liliana Marie Prikler Andrew Tropin <andrew@trop.in> writes: > It looks good to me! Pushed to master, thanks for the reviews! - Jelle ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-06-20 19:11 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-06-18 19:38 [bug#64155] [PATCH] gnu: emacs-piem: Update to 0.5.0 jlicht 2023-06-19 13:44 ` Andrew Tropin 2023-06-19 15:39 ` Jelle Licht 2023-06-19 16:32 ` Andrew Tropin 2023-06-19 18:24 ` Liliana Marie Prikler 2023-06-19 19:35 ` [bug#64155] [PATCH v2 1/2] gnu: emacs-piem: Do not propagate any inputs jlicht 2023-06-19 19:35 ` [bug#64155] [PATCH v2 2/2] gnu: emacs-piem: Update to 0.5.0 jlicht 2023-06-20 3:23 ` Andrew Tropin 2023-06-20 19:10 ` bug#64155: " Jelle Licht
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/guix.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.